From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Yang Shi <shy828301@gmail.com>
Cc: Jann Horn <jannh@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Zach O'Keefe <zokeefe@google.com>,
linux-kernel@vger.kernel.org,
David Hildenbrand <david@redhat.com>
Subject: Re: [PATCH] mm/khugepaged: Fix ->anon_vma race
Date: Fri, 13 Jan 2023 03:10:37 +0300 [thread overview]
Message-ID: <20230113001037.adqha6lxj7lh75at@box.shutemov.name> (raw)
In-Reply-To: <CAHbLzkpAVTys9dBSodHBB3ovKhwP8imUsyXy=aPqY5SyXCT7ww@mail.gmail.com>
On Thu, Jan 12, 2023 at 10:12:53AM -0800, Yang Shi wrote:
> > This is totally wrong direction. Or I don't understand the race.
> >
> > At this point we already paid nearly all price of of pagetable retraction.
> > I don't see any correctness reason to stop here, except for the assert.
>
> Isn't it possible that collapse_and_free_pmd() clear the pmd which may
> point to a PTE which maps the COW'ed anon page if this race happens?
No. At this point we have huge page in the place in the page cache and it
is locked. COW fault would serialize on the page lock.
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2023-01-13 0:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 13:33 [PATCH] mm/khugepaged: Fix ->anon_vma race Jann Horn
2023-01-12 1:06 ` Yang Shi
2023-01-13 19:36 ` Jann Horn
2023-01-12 8:56 ` Kirill A. Shutemov
2023-01-12 18:12 ` Yang Shi
2023-01-13 0:10 ` Kirill A. Shutemov [this message]
2023-01-13 3:22 ` Yang Shi
2023-01-13 19:28 ` Jann Horn
2023-01-15 19:06 ` Kirill A. Shutemov
2023-01-16 12:06 ` Jann Horn
2023-01-16 12:34 ` Kirill A. Shutemov
2023-01-16 12:54 ` Jann Horn
2023-01-16 13:07 ` David Hildenbrand
2023-01-16 13:47 ` Kirill A. Shutemov
2023-01-23 11:07 ` David Hildenbrand
2023-01-24 0:51 ` Kirill A. Shutemov
2023-01-24 10:19 ` David Hildenbrand
2023-01-17 18:57 ` Yang Shi
2023-01-17 19:12 ` Jann Horn
2023-01-17 22:55 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230113001037.adqha6lxj7lh75at@box.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jannh@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).