From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFBD9C3DA78 for ; Tue, 17 Jan 2023 13:38:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50F776B0071; Tue, 17 Jan 2023 08:38:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BF0B6B0073; Tue, 17 Jan 2023 08:38:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 387A46B0074; Tue, 17 Jan 2023 08:38:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 29AF46B0071 for ; Tue, 17 Jan 2023 08:38:20 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E21581A0741 for ; Tue, 17 Jan 2023 13:38:19 +0000 (UTC) X-FDA: 80364395118.08.1193038 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by imf15.hostedemail.com (Postfix) with ESMTP id 4BB5EA0015 for ; Tue, 17 Jan 2023 13:38:17 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=E0rIeRlb; spf=none (imf15.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673962697; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nfWfqKr/PVzcb/oJc3L8XNTuez212taZGy6pj2oYdLY=; b=mmvahT2E1TSlJsnIH/AzrqomJ4BL/LbSNYBSGftBvYaoqLfb72JK4Pf8YrQQfJToH+hRIY Y0UMzJy2raHcgjW2IEcTtmAdQIh+nt0rAzofA5rz3/wPLsZdn2bdRms5FG9tWiKXqH2456 5I4SYutEK53FNh106OOICgYqdoHMIts= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=E0rIeRlb; spf=none (imf15.hostedemail.com: domain of chao.p.peng@linux.intel.com has no SPF policy when checking 192.55.52.115) smtp.mailfrom=chao.p.peng@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673962697; a=rsa-sha256; cv=none; b=f/kLhVadqJBgf0DCqIptQx5BaI9TilA5bTfBEN3SoOYVA6I/HvkGpVFc/r8n7G56oAJ4lc KAOh69LWi7VS7a/8o0JQJHK7tFGdVL0m6XyzuaM/8KW6WPCeSUPCQ1ACFEKXOFld/PdtSK SO+TEk2th9508YciPSmR6SShtYbwFO0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673962697; x=1705498697; h=date:from:to:cc:subject:message-id:reply-to:references: mime-version:in-reply-to; bh=1YxIhrDQKE2lDqlUyO/ARVgD5QjeSGAHzdlrkVl5mCo=; b=E0rIeRlbpOG/6sgZHEw/nCkixZbZXGewtvsII/Z1RaJlCfc/oVjqLDvt xtHCYsecIWLcAes3VYLyZXmH9Mf6cM08+ZcAlpt25uLtuksQ1C6bzlPZa uqNGs3sR6PGfjr6tnaM4ntMW2WxqZBN2kfYjI1d8l3fuBrj56+59w/ZYp rIIvh1Arg29OBMuamLk2T7DKKd+7EV/7uc15G3BZGUNzfUNZ8eXWAfQPX Df49QV0ypJ9L9erMlJFZUz/qUs1L8ieiSJHm8QRDhAeRKWhaQszlV8neB cG7HBdrqHw4nKI1gQ998FVpH+xsy4WlD20hCSYGGVI9vfubrd4HZYcXpS w==; X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="324748863" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="324748863" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 05:38:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10592"; a="783240137" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="783240137" Received: from chaop.bj.intel.com (HELO localhost) ([10.240.192.105]) by orsmga004.jf.intel.com with ESMTP; 17 Jan 2023 05:38:03 -0800 Date: Tue, 17 Jan 2023 21:30:15 +0800 From: Chao Peng To: Binbin Wu Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 2/9] KVM: Introduce per-page memory attributes Message-ID: <20230117133015.GE273037@chaop.bj.intel.com> Reply-To: Chao Peng References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-3-chao.p.peng@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4BB5EA0015 X-Stat-Signature: wh7m1oczf8ehmjokz8j6wyxfh1868n1b X-Rspam-User: X-HE-Tag: 1673962697-412186 X-HE-Meta: U2FsdGVkX1/4LhQnuy78kZ1PAbIWqFhAwuweeyhXBGAaqGDGfScuGdihE9UwW7+8MZc0ON8vft2mZ5aNcpB5Bq2BbbKXJv3Y88PyDcVgqRmeLu2NGz1VWxpGaq32q5JBzy3cyozrv5U6SdcIc1YR/SKNzFh3EmgiDg6hvX7q4Hn9d6RRPMpHOo00pPMELak3w89g51KBMnG2kBvxZZUSKedSY4x6wzbXwvJqcVpxvFoTttLtDgUOUed/HXn0WsRI52xXeTeXJ+qbM2WwuUnt8LMtEJ9oh8LSXmFVmIYDITCijKX2s02UFYzaG4nDD5zguABXry/95Ze2endfmprHOXal+Zw138pLUtLZIbwOLfuwaSarXKJcwH58ZVqk++r4NTZg9fIzuWlO0maFckYcdfYdDUsjucq9M5AwAp8a9M3U9thHc+Gj67Q7KHZ/WoNMu5ZTZqItXtSG8yKZP2Dwt5uopAoWgGoBysg5fK9EbrbIjLU2IpVTEjsuvHT3Ok1oYgNxWyxkUp7I7IH+Ej9p12uP5En08H+hlzj1qoxDC54YvE2lFktIV0qx+pbLdKuEgixo70EzgujXP6EmOyhkHGH+jqp8Xc1OahNmUxxtQ41Bs1UHOMzRmdXvNpcLf/uHMlPFvvp7xlit4hvyhV6tc5PVdVc+eYe531T3X/X2VY7Ubrocr+krlSgh3FInm1ys6W4MFO6snN5miyVBAJ2uTi8vR5R8jf8Sns+8QNYti4xOV80jY7UcDquWbqu8vBCi0QkdlHlUVepN8bm+0xX5QyYczQQJlARJH20QD2ewihExU73VrT8/aZ7oRm+izc+emOE1gfqlJrPDVHaMOKvIEFdmLtJwIdtfg65m9VxCHYohRbzD0Syuc88pHWcPRnA+iwf+pONv9eVAUrdNQyqkB4pYbawyVUdQEGenAjJZvFPU5wb4JOfHLmnQ50te4dd5I/s10k4DGGs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 17, 2023 at 11:21:10AM +0800, Binbin Wu wrote: > > On 12/2/2022 2:13 PM, Chao Peng wrote: > > In confidential computing usages, whether a page is private or shared is > > necessary information for KVM to perform operations like page fault > > handling, page zapping etc. There are other potential use cases for > > per-page memory attributes, e.g. to make memory read-only (or no-exec, > > or exec-only, etc.) without having to modify memslots. > > > > Introduce two ioctls (advertised by KVM_CAP_MEMORY_ATTRIBUTES) to allow > > userspace to operate on the per-page memory attributes. > > - KVM_SET_MEMORY_ATTRIBUTES to set the per-page memory attributes to > > a guest memory range. > > - KVM_GET_SUPPORTED_MEMORY_ATTRIBUTES to return the KVM supported > > memory attributes. > > > > KVM internally uses xarray to store the per-page memory attributes. > > > > Suggested-by: Sean Christopherson > > Signed-off-by: Chao Peng > > Link: https://lore.kernel.org/all/Y2WB48kD0J4VGynX@google.com/ > > --- > > Documentation/virt/kvm/api.rst | 63 ++++++++++++++++++++++++++++ > > arch/x86/kvm/Kconfig | 1 + > > include/linux/kvm_host.h | 3 ++ > > include/uapi/linux/kvm.h | 17 ++++++++ > > Should the changes introduced in this file also need to be added in > tools/include/uapi/linux/kvm.h ? Yes I think. But I'm hesitate to include in this patch or not. I see many commits sync kernel kvm.h to tools's copy. Looks that is done periodically and with a 'pull' model. Chao