From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D1F3C636CC for ; Mon, 13 Feb 2023 23:53:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD2DD6B0078; Mon, 13 Feb 2023 18:53:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A83B26B007B; Mon, 13 Feb 2023 18:53:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9249C6B007D; Mon, 13 Feb 2023 18:53:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 813866B0078 for ; Mon, 13 Feb 2023 18:53:49 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3FDC6A0C1A for ; Mon, 13 Feb 2023 23:53:49 +0000 (UTC) X-FDA: 80463923778.04.92BDED7 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf15.hostedemail.com (Postfix) with ESMTP id 7297BA0008 for ; Mon, 13 Feb 2023 23:53:47 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=C91FV0IH; spf=pass (imf15.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676332427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oN12p0IDxvmorHBGQ7GzjlWOyGaJlkT0wNKpNtRNPE8=; b=d9VlCHDbT/fPQogMs53gt22+TprazrtQvWY1NznyaEbFAAjJ0JQJtaO3DQhE2JLyhticx6 1RM09DhO56UdHkgdw5C9FhE5cGrsTO7oahFIql2K++dCfiRCiw79aJ7hUxNwF411htrK4z nQPofAZlf6qcFB7fV/b1DbiYr+KjwQ8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=C91FV0IH; spf=pass (imf15.hostedemail.com: domain of isaku.yamahata@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=isaku.yamahata@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676332427; a=rsa-sha256; cv=none; b=dQ7W4b+WGe2LRgi4372xoz9xNqO2xGJsGWV5YueWw70B9puCFetQky7S8gQRITIaw99p1f ys2KXDrgBrS5LkXfRzrOeQz3jc0vg/7XsV2nT33+uDhpiEByeZuazrXLTZNKkOO707ywhl aMV/mITVo44AH1HC4fK5hfRxZyd+cH8= Received: by mail-pl1-f173.google.com with SMTP id m2so15283949plg.4 for ; Mon, 13 Feb 2023 15:53:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=oN12p0IDxvmorHBGQ7GzjlWOyGaJlkT0wNKpNtRNPE8=; b=C91FV0IHIHySQTRkb86+GocwXDr8WlYgQiYnUNZd1Ke1PWzwc0Ui3swRKoM/EMugmd mtDyIYfBfzKVpqk3ZurWfE4C06NJuP7sWx9xClULK72fPaRyTgD475XUP5w0R0lmJSxg fqPMDhOQ1CLyvdP8vm+bEyoR42WnbkStnrKpQAmZxWuxcmJUuRvcyRi1Rk+aqkGEy+qK F0pLZENP3TbitJijIx7cS7NuofTEJwgwDOkN5GYMW48d2+LHtiHhs30rOQ3tZSv01O8e FB7gFZ7JbhxL0Pno8NSgZttpMsmCG6pRRBkbmMYW6rJKC8Z6IMP2dpIC+LDTcFZNOFFC kxfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oN12p0IDxvmorHBGQ7GzjlWOyGaJlkT0wNKpNtRNPE8=; b=ebJqhRmMGMUseZJ44JWV8XcFa9oVeznmwonYYplwB69bisLLIQ4kG4ZJWyMnKxMt1b DyTjegFgk74/xpZoPh47p4kR0foLyJP+7Wo4e5AeSyp3sTvzl0N5G56JqWspQnWWk7a1 Tr8g+Bv2pT/NaWjhP1oXYPaUq/y6glO7NMI15iqd+//zoaaRz4SuyoYCo974rxp01X2G /VMsaxrr3DzfuVMheWN5hs59zVZ6iA2gYf20rfFIQpRpfoiIRriJmCYH0RqCzxVGDPib bwsl2PCy/KMEt7pq3RJ3hOrY4yczxp1msbFVKev0b/mlTBKmzHKBgKr8fdFTYP2RyG9I oBUQ== X-Gm-Message-State: AO0yUKWqNf66S2UIhfg9ueTx4LsFUnTtV28uvGEu2XHXoFODlF2Wa8Uw Vt+7tXEr1Mka5hi/ZF84Qr0= X-Google-Smtp-Source: AK7set/amp4VFmNZkQNRNmMa3hykvI7jc+MqhCv8WD2YyR0i7BGfBFGLnLeucu0LFmUtyzTRowTMiQ== X-Received: by 2002:a05:6a20:12c7:b0:c3:161a:b954 with SMTP id v7-20020a056a2012c700b000c3161ab954mr391641pzg.44.1676332425999; Mon, 13 Feb 2023 15:53:45 -0800 (PST) Received: from localhost ([192.55.54.55]) by smtp.gmail.com with ESMTPSA id z20-20020aa791d4000000b0058e08796e98sm8406145pfa.196.2023.02.13.15.53.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Feb 2023 15:53:45 -0800 (PST) Date: Mon, 13 Feb 2023 15:53:43 -0800 From: Isaku Yamahata To: Sean Christopherson Cc: Isaku Yamahata , Chao Peng , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Naoya Horiguchi , Miaohe Lin , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Shuah Khan , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com, aarcange@redhat.com, ddutile@redhat.com, dhildenb@redhat.com, Quentin Perret , tabba@google.com, Michael Roth , mhocko@suse.com, wei.w.wang@intel.com Subject: Re: [PATCH v10 2/9] KVM: Introduce per-page memory attributes Message-ID: <20230213235343.GC4175971@ls.amr.corp.intel.com> References: <20221202061347.1070246-1-chao.p.peng@linux.intel.com> <20221202061347.1070246-3-chao.p.peng@linux.intel.com> <20230209072529.GB4175971@ls.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7297BA0008 X-Stat-Signature: b8mbnz87k1bg5psqcqmj9f95r8p377c9 X-HE-Tag: 1676332427-44166 X-HE-Meta: U2FsdGVkX18fCfLQ3X58YLqMbxEWviWrvNOX7W5adysP/2ITPACBOvza282cjlWDOlI1aEdf1QiPjTxymbpcSb1iumDAzAR+FUsPwSQGF4Sie19St7EqbrSuESocSY6I5E+SAyglHRZxVliGaYzSJfYtopp+rXNO85cJbbL+k/71Cptwx18w96JjZGXxZolcLKor+ugNQC/hhctSGBqzBdmQypoQHGbBWfm344B3Zk8OJeSZzwHsMcRTOCNXOnbKb0N2ZH2flMr9aF0G2ffttKpBpfXXd873fp7BqLlsOaTo9lCKW9nGIkYHw3CMpNcmEv5MvsUdc1j8hCp3lIe3I30BBT+rANMy4NJ+HpFeJs5Tcw+1WK50VF9RLxHwElw2o6Jt8WBfIQr2THaZHVK4076mVZWkoN1+JHUyiTxqQfIpjYsYmKOWGffKW1//myi4/4T917/sXdcgLQeJEdg6Dg2vZDsUBQ2FavjmSTJh2w4r60nW0LAETAakNLAKwx+cE1Heq98AyORmLDI5EAxz2g0ZSj9NLGe4dJoaSgOAD6yMOoTzOGQ2oUwhTZLzg0n6J6+3n1/XLLvgePXra4BPL7awFZl95UaD476oYKWqgFyxNYp+t4jVo8lbyuS3XC9UcWGYfcgUeF/G+uI4GhmCZpPCV7SaW3Iio61fK+dl52ZF0yPB8z8ZYY8k5bBMz5q8aYrEOGsRL+o6vy4FNQrLqY+lZUNOakog6RWFZ40u1Sb5y910FiKxmb04D3UG38tBl8IXH4ppiWroauroOBt+CvOKUx4IXh56u97gcZtN+7zaeEaCS/YTBny0c9uVClKJ4xQ4MGnoUtfVgzXFfURq7OiYcNNk5Kbyx6d9wkuiomTLXhbLBwFIH4Yh4RbPeRpKkLDzB2f/biLsj2fGijpQpN7PLsWc2Hn+rWzPUwhw50GzGfSvAzCTi+jDM+4LBvmwadr1R/N6iB3b30/FZzg pdMheSZ0 4f6NX/D/lQJwBqcf3Y0WPBDUqLrPbiu4qfxTZLUEf1RONJscCUCSsEGp7MA6NdtPVFR0xnOidrtADnF6rwv26vakU5vaRt8Y77kqbSnJ+wmhovNPL+xl4bjA/sO4pfcY8Pyo5RuHi01rIV4EH8+FhCN/DXRk8Wuk5gHB0iXOSAiXmglL4n9Ry1mlBQxwVQgisrxqg8XYSaRkKXehxuyFZ/Vy7FwHJgemofk0z6kBQE8TUaNgo7oRPxuL4RleGXEJRZ9gyAsvFY35FTGpjUB0x01Bw9fg6UKeT9L27WfxyNE2YZareGZSQ9Ajc/4Zl2b8JZ4nTOqtnm2utL8MrOXcref50qXgHBhd70t+xMaQAN+RgU5ewQjQsDIPEYssPZcKBt6J0wY2vJGhnzpDY/SC4riodSbMugJk8SXNh5/WDCy8IVtEOCNy0yKHZNibneYRRsJ1jofoz5+JWEqdocFNI0IuOWmXe/uyaC3J1zEd8BhOZYrSheCMIiWP+ecJkedBTizaP9EUGaVMcU4H7cVjD3QDan6NlKclS8yx9e/ghGHV/B7aBJ9nBQ4A/6Z93UmYt3UNZmnJG2jfH3Y4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 10, 2023 at 12:35:30AM +0000, Sean Christopherson wrote: > On Wed, Feb 08, 2023, Isaku Yamahata wrote: > > On Fri, Dec 02, 2022 at 02:13:40PM +0800, > > Chao Peng wrote: > > > > > +static int kvm_vm_ioctl_set_mem_attributes(struct kvm *kvm, > > > + struct kvm_memory_attributes *attrs) > > > +{ > > > + gfn_t start, end; > > > + unsigned long i; > > > + void *entry; > > > + u64 supported_attrs = kvm_supported_mem_attributes(kvm); > > > + > > > + /* flags is currently not used. */ > > > + if (attrs->flags) > > > + return -EINVAL; > > > + if (attrs->attributes & ~supported_attrs) > > > + return -EINVAL; > > > + if (attrs->size == 0 || attrs->address + attrs->size < attrs->address) > > > + return -EINVAL; > > > + if (!PAGE_ALIGNED(attrs->address) || !PAGE_ALIGNED(attrs->size)) > > > + return -EINVAL; > > > + > > > + start = attrs->address >> PAGE_SHIFT; > > > + end = (attrs->address + attrs->size - 1 + PAGE_SIZE) >> PAGE_SHIFT; > > > + > > > + entry = attrs->attributes ? xa_mk_value(attrs->attributes) : NULL; > > > + > > > + mutex_lock(&kvm->lock); > > > + for (i = start; i < end; i++) > > > + if (xa_err(xa_store(&kvm->mem_attr_array, i, entry, > > > + GFP_KERNEL_ACCOUNT))) > > > + break; > > > + mutex_unlock(&kvm->lock); > > > + > > > + attrs->address = i << PAGE_SHIFT; > > > + attrs->size = (end - i) << PAGE_SHIFT; > > > + > > > + return 0; > > > +} > > > +#endif /* CONFIG_HAVE_KVM_MEMORY_ATTRIBUTES */ > > > + > > > > If memslot isn't private, it should return error if private attribute is set. > > Why? I'd rather keep the two things separate. If we enforce this sort of thing > at KVM_SET_MEMORY_ATTRIBUTES, then we also have to enforce it at > KVM_SET_USER_MEMORY_REGION. For device assignment via shared GPA, non-private memory slot needs to be allowed. -- Isaku Yamahata