From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39C9BC761A6 for ; Tue, 4 Apr 2023 10:59:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2E7C6B0072; Tue, 4 Apr 2023 06:59:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB6AF6B0075; Tue, 4 Apr 2023 06:59:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9570B6B0078; Tue, 4 Apr 2023 06:59:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 820156B0072 for ; Tue, 4 Apr 2023 06:59:25 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 56A5DAC1E2 for ; Tue, 4 Apr 2023 10:59:25 +0000 (UTC) X-FDA: 80643412290.02.78E35A9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf28.hostedemail.com (Postfix) with ESMTP id 4951FC000E for ; Tue, 4 Apr 2023 10:59:23 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oCGwxlo6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/+iRrkz4"; spf=pass (imf28.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680605963; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ThcWicpsGQ2RnXyb8yTGtCo3F4UO6chUrSx4AOuifuM=; b=qrwgnGs7EDPNZsUkdvB7x7vGnxhHKK8Rxf7ilpTSq4eYZGP8K54VhHJl5nCr6QJoiz7NGl +rf0p2Rk8tAP550E/dn0LKGwZqCcLc2UdB8yP3wioM7isL6mboMdbXRiPBLoHRbnHWxhjS 32+xWN5j5YgQm3y/uJUhRcC7PR81Hxw= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oCGwxlo6; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="/+iRrkz4"; spf=pass (imf28.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680605963; a=rsa-sha256; cv=none; b=t1i8vPCkutl4Y88AfTY7b8dsYxhzwpumIZ3gpTayq7LVFjmxFq0oHo7rms8B95lUN6dY2N DDl3qhH0CCOkIz2A+yqldWKqq9+RJIDXO/OohvNRoa1kBrWeQgjO/bRApviaSxoKeYMJej 0PdYqGF477PK13GVvEc+HIINpBxP5AA= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7544821CFB; Tue, 4 Apr 2023 10:59:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1680605961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ThcWicpsGQ2RnXyb8yTGtCo3F4UO6chUrSx4AOuifuM=; b=oCGwxlo6rB4Xd011auZfMe9W2ldBs52wNCVR46MLknoHYu6yK6PVBZmHSFdE7b9ULneTFz tbLfuWhkX/lZGuXHY96oRMYPHLpqrABdygoT7u3IC5WMEaiNX7f2TdWHoNb8d9nyvyOiZO 173fUz8x4y2/bXakgYsDB5f414qbWPQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1680605961; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ThcWicpsGQ2RnXyb8yTGtCo3F4UO6chUrSx4AOuifuM=; b=/+iRrkz4cXi8dzS8sX/2tjFr/isUILBLFqy0Ma5UGi/4A3FKwxBDWmiQl81g6q1g2F++G8 8fhsPS3cjH52TuDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 67D8913920; Tue, 4 Apr 2023 10:59:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9DRXGQkDLGSobQAAMHmgww (envelope-from ); Tue, 04 Apr 2023 10:59:21 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id F3CD9A0732; Tue, 4 Apr 2023 12:59:20 +0200 (CEST) Date: Tue, 4 Apr 2023 12:59:20 +0200 From: Jan Kara To: cem@kernel.org Cc: hughd@google.com, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH 1/6] shmem: make shmem_inode_acct_block() return error Message-ID: <20230404105920.nlrxopw3zdwoa5su@quack3> References: <20230403084759.884681-1-cem@kernel.org> <20230403084759.884681-2-cem@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403084759.884681-2-cem@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4951FC000E X-Stat-Signature: oyn941hcaichda9y3osccc6zqwj7kyon X-HE-Tag: 1680605963-274780 X-HE-Meta: U2FsdGVkX19zMeSZu/HEgEHtt5oIpkZdRgTiyylIbCmGSm7IgmypGZxIA87lP16hQyvoEKkwuRHxUJ6Avdf4PYNlZlrQper3jqGSNvK1mfm4n3ktWwxNfhp1JKyCd8CmKF0BlAM7D8PjDgleYvKBp190f0ZiGF+avgyTNgdbDxuWk6gMtwdOdaGvI1xuq6JWHHj5NYpWuA6XZwHGN9KBpswT2lm43XD3Ej0uuwHXocVmIqruzj2EURplFShsk5ikf9wV01lu60RANX15598tSwdmn30ZCTUbBD8Pi57DtTwLyl6gRMqNnuFcNX3XvRcuWFFeQYYTONF5Foa8y7JJAllkVTm2SyFf/qNKQmFjMQPAiQo2JrRvRKdP7X8vllsjQ/+k5QSTJsLJ+U8kSYqWkv9GEGVa2j7k+nKdEAoKBL0RAC3qmc72LgQNAsUinrooZFyA3T2MdLRgkbQdHoIGYJrf7psPRSSOBWJlf2d+mqjSCoLvF1w5tCGFSNsbxcJQ+PD658r2oR0GkVET9z0G4J6Ak8py6S3S+a+cJmD4P5WdCYhkFnUxmeLAQGDxg+P5M8vTOpzeN6d9zYPtE8Ky+YFPjDouYVtpdavzxTKrUSbuoLeGzsZEd8FREit4YYaAtYP95aSUxRYPEDyXYtCJuFqZGu5b7rxFv0jKHG6SbYHAxHicOMOzDn1VPrBlKh01qfli2Y01IVSlHZO9i9mkk0r6v0zPLR4Pz+mG4/xM5Uxnl4zm3LN+TkCrzUEIQlW6Ft52GCJ9giZHbbMQC7INOjDHK4MRi/Jdm98UPCzvL87s9n2XNTvtvSwPPHYmChkMtMbFeynWCvsUwvRZG9stQn/kl1kJ6u6511RwC3JuE5WSEAe7/oPYEs+/D7TSgTJgpEY/LSeMZWJY9hnOsG9VlEVw8/l6jSj3VQrLoCR55p30sjDtNH/8vgCBghuzww14ZHBe3kyjeY5L8duikNv pKHRQzPa S3qLX/cFqfXHjp3Lhkd4uFdIAgMpvj8zDvvPhxlIrq0/XHiIjNqG1d94d6dcuPeY98LNO4ylad91CXUaHPtoJyMxJhTVCUpqBe5hF2O3Yho4FYp12xY1y41GJDC6ok4zSY/fKxIQ4tkTCJIs3bBtpMfH3RbokRR89n+QVhkExtxYkI/YuJGZNXQYZtRTot6bvmYjgKXs/D8voOVjFsbQsY9mx/Zzpq4X0VYFzQKo7BaAM8R/CElnfUA+hNvYOePi+dsp/MGqIFjcIx7zXi4TumSuHiHCBXFA2hPhdDyL3hRih/AkKtYJh7GBw4xU4PlGXqOMqsZDgDx+GPzN7VGHH7HwawiVOYdqiHotN0ae7Dr5c/TFHvNOjNXZtb4I9voFgz+g72aoDKk3vQYc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 03-04-23 10:47:54, cem@kernel.org wrote: > From: Lukas Czerner > > Make shmem_inode_acct_block() return proper error code instead of bool. > This will be useful later when we introduce quota support. > > There should be no functional change. > > Signed-off-by: Lukas Czerner > Signed-off-by: Carlos Maiolino Looks good to me, except one minor nit. > @@ -1589,7 +1590,8 @@ static struct folio *shmem_alloc_and_acct_folio(gfp_t gfp, struct inode *inode, > huge = false; > nr = huge ? HPAGE_PMD_NR : 1; > > - if (!shmem_inode_acct_block(inode, nr)) > + err = shmem_inode_acct_block(inode, nr); > + if (err) > goto failed; > > if (huge) The initialization of 'err' in this function is unused now so it can be dropped. Honza -- Jan Kara SUSE Labs, CR