From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15826C6FD1D for ; Tue, 4 Apr 2023 04:27:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EA416B0075; Tue, 4 Apr 2023 00:27:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 59A2E6B0078; Tue, 4 Apr 2023 00:27:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4620C6B007B; Tue, 4 Apr 2023 00:27:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 319F36B0075 for ; Tue, 4 Apr 2023 00:27:09 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 037A9160979 for ; Tue, 4 Apr 2023 04:27:08 +0000 (UTC) X-FDA: 80642423778.12.FDB13EC Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf05.hostedemail.com (Postfix) with ESMTP id F2E8D100003 for ; Tue, 4 Apr 2023 04:27:05 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="j/NzZ2Wa"; spf=pass (imf05.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680582427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4DGn+glEbf0D7NHgyQEG7ww4gzdYqFhhgwuGt0wm+NA=; b=UxApo05R/fBKBIGZUnJfEuuEzop4TVbww1GlMm8jqRhoyElytwCo0O26h/QD+P3rGhPiC7 hAxSGklCw4cYhV1+G37OLqhb9VEumQE1CPBfTDL8m5qE3qAuX0wzIfSEP4yArpN0SoSnS7 b3Q9XljG+AJagEkbWInRtEy9oToWP9o= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="j/NzZ2Wa"; spf=pass (imf05.hostedemail.com: domain of lkp@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680582427; a=rsa-sha256; cv=none; b=4J3VWT2T9wZ3ExVdjSsLolMJ7dlDQn0gpsuE+45et7T0kO/yWAa5bKTqfbQCFLDDxogqKB M93nz+83pFr1HXr0ePtL/5VISjIqAE6qq4eu/w1P/O7PhKsRr4NC61lEXeWUCElWYnIO9i I+j66pFjClkXpIFzv5hpdJwsATr+yDg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680582426; x=1712118426; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Lj5XWWDTc4taxfcqzqpVs4yKUk2XcTdv2lZpVWLffVI=; b=j/NzZ2WatgFDhRKe+d5Ss0ukHGZqIjWHy/hgk5hD699SBMnYnMhbDbz4 fVlyymQ59fUahX+33qUu6MgkXIYQoHr9+U7hb22gt/RxEJS7LqgVEC7nF gTWEVJiU2LaOvfn5oamokEHaDO8sp7QMi2nntw/5LfeEVtWxdSmsVVgru FGsjpEanrB3Wvd3ddqgL8hCSDdoQlotFBN7iGPMMmaYT04ChTqt1zXh1z R3qbEQBx11g5r3hChXd7i377zafRnsbbToqZTJhbSLXUBcLYnkhtBlG5D Tz7PABEQpi0S1uhY83WGnFzUAGLM1f2Jlrz761tXfLMwOPRZWd9VPJW0W g==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="343785815" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="343785815" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 21:27:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="797368710" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="797368710" Received: from lkp-server01.sh.intel.com (HELO b613635ddfff) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 03 Apr 2023 21:27:02 -0700 Received: from kbuild by b613635ddfff with local (Exim 4.96) (envelope-from ) id 1pjYG5-000PBC-1V; Tue, 04 Apr 2023 04:27:01 +0000 Date: Tue, 4 Apr 2023 12:26:24 +0800 From: kernel test robot To: cem@kernel.org, hughd@google.com Cc: oe-kbuild-all@lists.linux.dev, jack@suse.cz, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH 2/6] shmem: make shmem_get_inode() return ERR_PTR instead of NULL Message-ID: <202304041204.sEsaejmQ-lkp@intel.com> References: <20230403084759.884681-3-cem@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403084759.884681-3-cem@kernel.org> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: F2E8D100003 X-Stat-Signature: qkojypaasb69c7s9r4m3xqwmet6fmhyw X-Rspam-User: X-HE-Tag: 1680582425-603828 X-HE-Meta: U2FsdGVkX1/dXDuvAcvgDDkd+sITctbXp/MGI6kspYqn5+MssBErQC1XjhMCGR1qtGWqdvOuX2G8VM2QwLlvLetOkEm0NBM/sacvWU1u9CGVjkyrbeV78WqJOw6nEvWpVehX/ak+R6cEtP+4e4HBSeIlZlKNSWHA4mg/+pXElv7ZOa/3pRaD3VSTuALC9Uxv6lKXpky2wlyqZeKfhRl2KIdHrK1anhhijSeYVYqy6givr/JDY5WhkLJYmidlbxHeP5VuAWYawp0tO9s6A75I+JGw9bfupzmmgtdCnvJwUNiOQbkCLdFGx2y3Ala+va9Ozw9OML1GsrfB0cl51IaR8bkx5EWfTVvdPcfeYfP00EqbMIgmc4pcLa8X0VmYCgawTAQGiICmygepsaP45BTCbBgrXEhPWscMV5e5Zqk6xcitUw5un70guPluByfF7Zf4gafxX5wn2q4fR5JexgbqSP443VNi0Doj1tGLKwnfxFHVfCKjLUldHEGlcpCkQyb59RVG+CNo6II0uxhhvkRy33fD6+ZWuRK1DWK2NnaJMyHF4fJFIhO4lPPqbCobtkSR5BTxuC+LCwFTxRIKTe10URBl2Mis7RIOEZHJzjDsXgfiWwzjnyAnpP848qOjq1827iHKnQLWvH5qV+uAx5SXzRispqXcYqUrksS1gDyWhtkTWVOMfq+uZjqt8zSw4lliVrW/HBpkyIXgQKp/w5Pj5aRtnU2VAQdugU9JwuKZ98B7QJHQVvP2Oq/t72g82PYL8cqVSabyQ3i3NcEPsQMgfOhVcAQY8kPbptgcqPvCtP36Tfck7rBjcAq8tPG00kEUxnqmCKpW+Mboow5LYXpcRhWj/oRnqdNXt6WHH7ZZ4vgOAbdXe3LNtjPXWWWUUZPnNoksuPxv2prxEF3dnEfA1+cakf/NrJrD4lvIu57AdH27hWjKRWbkj1pqU1Z0qc63YEbeVpD9L0eYQ4jqcsV Y+SHtD2o Xnwf3KSHU3py7TSCjQN8ud7M8YICWfsarAHjhOnJB4lPfK+5qMUvsrdgucBQFVZkuYAoPogELoIQyjgTDoMguCwJYTYyAFBmaZQnpjyv864x3sf9xKA58z/lrxcriyoT4/CNKch8M94l5xhWVX6l4fVLA7toYA2ggiU2jCFtadIzZPUZ3/HXxkk2orLkoK2NVVVgsCSn87JAviOBO2txA4QueTXLSpH69xOmoAyqyddydzHUqw+udOetPAqtWwzHBnql+9kSLGV7LIi/qALa394cQykmJ1DkcHHMCiq/zkGvncdoJgiaH8eIj+rIJ2MkpMzhjvF7Rty0yCjDGDJ/VQyLvHirGuI1symfyXlEcQm0IpUvAAw6o4OPtetdTmvguviLJ0laxGYYcNQIShlrUEGQtUdooVh4iRCqC5fYDn2P/KErMYerAFPlbeawua7xgMxlh7cm34Porp1+MqY1uPZRnf8XsjeE7oXnRJVqitClG7wbL/s3bHpEpEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.3-rc5] [cannot apply to akpm-mm/mm-everything next-20230403] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/cem-kernel-org/shmem-make-shmem_inode_acct_block-return-error/20230403-165022 patch link: https://lore.kernel.org/r/20230403084759.884681-3-cem%40kernel.org patch subject: [PATCH 2/6] shmem: make shmem_get_inode() return ERR_PTR instead of NULL config: arm-randconfig-r033-20230403 (https://download.01.org/0day-ci/archive/20230404/202304041204.sEsaejmQ-lkp@intel.com/config) compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/98aa926ee22a768f6a2dc8b0b897d018fc47497e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review cem-kernel-org/shmem-make-shmem_inode_acct_block-return-error/20230403-165022 git checkout 98aa926ee22a768f6a2dc8b0b897d018fc47497e # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202304041204.sEsaejmQ-lkp@intel.com/ All error/warnings (new ones prefixed by >>): mm/shmem.c: In function '__shmem_file_setup': >> mm/shmem.c:4260:33: error: passing argument 1 of 'shmem_get_inode' from incompatible pointer type [-Werror=incompatible-pointer-types] 4260 | inode = shmem_get_inode(&nop_mnt_idmap, mnt->mnt_sb, NULL, | ^~~~~~~~~~~~~~ | | | struct mnt_idmap * mm/shmem.c:4231:65: note: expected 'struct super_block *' but argument is of type 'struct mnt_idmap *' 4231 | static inline struct inode *shmem_get_inode(struct super_block *sb, struct inode *dir, | ~~~~~~~~~~~~~~~~~~~~^~ mm/shmem.c:4260:52: error: passing argument 2 of 'shmem_get_inode' from incompatible pointer type [-Werror=incompatible-pointer-types] 4260 | inode = shmem_get_inode(&nop_mnt_idmap, mnt->mnt_sb, NULL, | ~~~^~~~~~~~ | | | struct super_block * mm/shmem.c:4231:83: note: expected 'struct inode *' but argument is of type 'struct super_block *' 4231 | static inline struct inode *shmem_get_inode(struct super_block *sb, struct inode *dir, | ~~~~~~~~~~~~~~^~~ In file included from include/uapi/linux/posix_types.h:5, from include/uapi/linux/types.h:14, from include/linux/types.h:6, from include/linux/kasan-checks.h:5, from include/asm-generic/rwonce.h:26, from ./arch/arm/include/generated/asm/rwonce.h:1, from include/linux/compiler.h:247, from include/linux/build_bug.h:5, from include/linux/container_of.h:5, from include/linux/list.h:5, from include/linux/wait.h:7, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from mm/shmem.c:24: >> include/linux/stddef.h:8:14: warning: passing argument 3 of 'shmem_get_inode' makes integer from pointer without a cast [-Wint-conversion] 8 | #define NULL ((void *)0) | ^~~~~~~~~~~ | | | void * mm/shmem.c:4260:62: note: in expansion of macro 'NULL' 4260 | inode = shmem_get_inode(&nop_mnt_idmap, mnt->mnt_sb, NULL, | ^~~~ mm/shmem.c:4232:53: note: expected 'umode_t' {aka 'short unsigned int'} but argument is of type 'void *' 4232 | umode_t mode, dev_t dev, unsigned long flags) | ~~~~~~~~^~~~ >> mm/shmem.c:4260:17: error: too many arguments to function 'shmem_get_inode' 4260 | inode = shmem_get_inode(&nop_mnt_idmap, mnt->mnt_sb, NULL, | ^~~~~~~~~~~~~~~ mm/shmem.c:4231:29: note: declared here 4231 | static inline struct inode *shmem_get_inode(struct super_block *sb, struct inode *dir, | ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/shmem_get_inode +4260 mm/shmem.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 4241 703321b60b605b Matthew Auld 2017-10-06 4242 static struct file *__shmem_file_setup(struct vfsmount *mnt, const char *name, loff_t size, c7277090927a5e Eric Paris 2013-12-02 4243 unsigned long flags, unsigned int i_flags) ^1da177e4c3f41 Linus Torvalds 2005-04-16 4244 { ^1da177e4c3f41 Linus Torvalds 2005-04-16 4245 struct inode *inode; 93dec2da7b2349 Al Viro 2018-07-08 4246 struct file *res; ^1da177e4c3f41 Linus Torvalds 2005-04-16 4247 703321b60b605b Matthew Auld 2017-10-06 4248 if (IS_ERR(mnt)) 703321b60b605b Matthew Auld 2017-10-06 4249 return ERR_CAST(mnt); ^1da177e4c3f41 Linus Torvalds 2005-04-16 4250 285b2c4fdd69ea Hugh Dickins 2011-08-03 4251 if (size < 0 || size > MAX_LFS_FILESIZE) ^1da177e4c3f41 Linus Torvalds 2005-04-16 4252 return ERR_PTR(-EINVAL); ^1da177e4c3f41 Linus Torvalds 2005-04-16 4253 ^1da177e4c3f41 Linus Torvalds 2005-04-16 4254 if (shmem_acct_size(flags, size)) ^1da177e4c3f41 Linus Torvalds 2005-04-16 4255 return ERR_PTR(-ENOMEM); ^1da177e4c3f41 Linus Torvalds 2005-04-16 4256 7a80e5b8c6fa7d Giuseppe Scrivano 2023-01-20 4257 if (is_idmapped_mnt(mnt)) 7a80e5b8c6fa7d Giuseppe Scrivano 2023-01-20 4258 return ERR_PTR(-EINVAL); 7a80e5b8c6fa7d Giuseppe Scrivano 2023-01-20 4259 7a80e5b8c6fa7d Giuseppe Scrivano 2023-01-20 @4260 inode = shmem_get_inode(&nop_mnt_idmap, mnt->mnt_sb, NULL, 7a80e5b8c6fa7d Giuseppe Scrivano 2023-01-20 4261 S_IFREG | S_IRWXUGO, 0, flags); 98aa926ee22a76 Lukas Czerner 2023-04-03 4262 98aa926ee22a76 Lukas Czerner 2023-04-03 4263 if (IS_ERR(inode)) { dac2d1f6cbfe3f Al Viro 2018-06-09 4264 shmem_unacct_size(flags, size); 98aa926ee22a76 Lukas Czerner 2023-04-03 4265 return ERR_CAST(inode); dac2d1f6cbfe3f Al Viro 2018-06-09 4266 } c7277090927a5e Eric Paris 2013-12-02 4267 inode->i_flags |= i_flags; ^1da177e4c3f41 Linus Torvalds 2005-04-16 4268 inode->i_size = size; 6d6b77f163c7ea Miklos Szeredi 2011-10-28 4269 clear_nlink(inode); /* It is unlinked */ 26567cdbbf1a6b Al Viro 2013-03-01 4270 res = ERR_PTR(ramfs_nommu_expand_for_mapping(inode, size)); 93dec2da7b2349 Al Viro 2018-07-08 4271 if (!IS_ERR(res)) 93dec2da7b2349 Al Viro 2018-07-08 4272 res = alloc_file_pseudo(inode, mnt, name, O_RDWR, 4b42af81f0d7f9 Al Viro 2009-08-05 4273 &shmem_file_operations); 6b4d0b2793337c Al Viro 2013-02-14 4274 if (IS_ERR(res)) 93dec2da7b2349 Al Viro 2018-07-08 4275 iput(inode); 6b4d0b2793337c Al Viro 2013-02-14 4276 return res; ^1da177e4c3f41 Linus Torvalds 2005-04-16 4277 } c7277090927a5e Eric Paris 2013-12-02 4278 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests