From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BBF9C77B6F for ; Tue, 11 Apr 2023 13:03:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CCDF900002; Tue, 11 Apr 2023 09:03:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AEE26B0075; Tue, 11 Apr 2023 09:03:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76BE9900002; Tue, 11 Apr 2023 09:03:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 690836B0074 for ; Tue, 11 Apr 2023 09:03:23 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3F89B1A0C0A for ; Tue, 11 Apr 2023 13:03:23 +0000 (UTC) X-FDA: 80669126286.15.CC8DC42 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id A81602002B for ; Tue, 11 Apr 2023 13:03:20 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3Cb6UsDg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="tQ/gsVMY"; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681218200; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=31Pc6Essa9yT1G1gaEpHoNq4CDQyULlkkDcBOL12Aa4=; b=vdDSPdqvioSFFxMt0T/U2rgdq+i1kjxtXyNZypNEi5y10cECJAAK3/Juc4OpkXFO4Pb8Zy TE25xXWV3ycBfqaqFTlEi2HQJepRZatoUSd8biwrKLoOUycPwH2YpnkNws4SsKm8Fow0PN vgoTpLM9XV5J9HmyGM07Cl8othiu7Io= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=3Cb6UsDg; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="tQ/gsVMY"; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681218200; a=rsa-sha256; cv=none; b=1q8D4yZbFbkqFRbCN1ktaYN4u2hIXQYQLHr0sRQkbyJ6D+PsWk+7bXjI7OloC2YNJn5NcU XYJ7mxS8MWw34QAeOroHIgslt7IqQixHhbOHhp33eIs1adT0rWx4RRULvCR3Kdkw62bBCU FsWO99qabEEuNi9QUBjFBKglGkDYri8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2C0D8219C4; Tue, 11 Apr 2023 13:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1681218199; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=31Pc6Essa9yT1G1gaEpHoNq4CDQyULlkkDcBOL12Aa4=; b=3Cb6UsDgbhD10DnTCgm6+v7mqFpCDe9QQYDSYB1i/WOWYrIW5c/Bl64orBwuFgWeGujBLA 9v+9Btv3rBxkLBAc4mWWfg5qeOGn/09x4dFI1j2s9QXZm7dtQoawqUT7oc0g+Y4PLa3+/a qUTGmBCbHhbi/5N7ZJ7llfRbpDQf6Ek= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1681218199; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=31Pc6Essa9yT1G1gaEpHoNq4CDQyULlkkDcBOL12Aa4=; b=tQ/gsVMYtF5WMCtbbZfbhyR0EBjY41mUkkzvwXaiW16Bma+rguj3lZILdwOdGgU3V7eINa GfRZwvdiaBZ7N0CQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1BE9D13638; Tue, 11 Apr 2023 13:03:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8KHIBpdaNWRyJwAAMHmgww (envelope-from ); Tue, 11 Apr 2023 13:03:19 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 8FB10A0732; Tue, 11 Apr 2023 15:03:18 +0200 (CEST) Date: Tue, 11 Apr 2023 15:03:18 +0200 From: Jan Kara To: Carlos Maiolino Cc: Jan Kara , hughd@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH 5/6] shmem: quota support Message-ID: <20230411130318.vp4yiywllys2xy7h@quack3> References: <20230403084759.884681-1-cem@kernel.org> <20230403084759.884681-6-cem@kernel.org> <20230405114245.nnzorjm5nlr4l4g6@quack3> <20230411093726.ry3e6espmocvwq6f@andromeda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230411093726.ry3e6espmocvwq6f@andromeda> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A81602002B X-Rspam-User: X-Stat-Signature: zt8itc8spceip8o9dughyiy5czcuxtxj X-HE-Tag: 1681218200-337278 X-HE-Meta: U2FsdGVkX1+eOTC1xjVsHtX/7lSsxEuXJfkUrVIHGicb9NQ8ircJy6ahJIsFdbzey+wLXvFLVFFw3CMQw/qASkzyuHicclLIxGSYCSwD85WIzG4rRET7OAQ5I3F8E4ShDr19UObQ1CxaWKqBTui2a25A1FZGtcQZPZIOWvJT56n+txxQcsD181g13JAPWcdiSDmp2iFhy5Fy1DpekkfANrN6GUxArKAApha8NhLFE5kqtp/LisgB7iGsOcMMaeBBe8fBNRlN1EHw3bcJaj+V4Hak5Q6T5z7Wzk6xK2Jcjfvw8Dn82PVA89z4SOdeytzqBQY7bUSqlUz1zn5l8T6Yh/n0XBs0CYqbJp8gJ+zhmo9Z9Rda9c1a+R73Ez9DBsAN1DLKM4ORLcVv9pcpO4EkcGSQqrtoLppmdK/dQRU1hbi0vdeM5wxG42yMQOcqNMnxzALaMlYfFeu09v0cN6Bwt6Jwu2BDdxhB5+9vvO85WUfw6Bu3T9yW2FjmJvtnzadTkRRAWay6ZKyiCVzrCx+FGYkZX+vHu7ctRIp/+Ha0tFnCvFY/wLWZW/ytOVnq5iKurv5bJIWlduCXfXcQcn2c5VzcdaxiInkSMX5ahNtuvnA8fgbUIUkbA3/WBPXGoRNWOfCw4xqYwjIonqvz0OVHWwzqog671kPsdWd1nV5iI7EFZesmRdIQKH9X/d8HB6ww0UQyGzvePhjBJyLLvaXDEKwCvkLxQhZxRf+ljNAB0w0kEwkAbj/YCdsZowE2ndX8dPftybVWf5L6X0aID2Jz/n9bZLBeyi0N/DKvkRbXjvpXdrDGJel3nvhHKCeqnZ+0KO+x58mAi0f5miFLmBRdYyXn3ib4V/svjcmS8iI+jLOR3NtAcjuAoOItZvh/XvdTizIoKrC2/9B/gC1Bin4AchGPtb82txXIiNFoI2C5PoODeO+v6+XwJ0ejGPgzOZuovSxYVhrQG1zgFqAPbMV RqJlGbjQ b66pHTZYplTCmpw9XKpkAMxf+SvX9MI3YMbyx6AGDb3kzq04q87YB7ebUGdNtVIQipFQ5sq53dKdOZeidvKrBmDstCECZ8y4VwV6lZKKc/jrTIs/ZKBFabRjHi12E3TVOPBOlL87t8IdyEVy2u/NciojpNc7Ibq4xG8pL/pXcrP0BT44LdV9Mb6F01j2kfdlj6XWcSt8Xuk16Y2zAcBLrSQPeV1tCHY+FMvb4odDjCtWO1l6JCcss/ek9zKX99sxvDg1jFzL+k4VTO6c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 11-04-23 11:37:26, Carlos Maiolino wrote: > On Wed, Apr 05, 2023 at 01:42:45PM +0200, Jan Kara wrote: > > > @@ -3763,6 +3878,9 @@ static void shmem_put_super(struct super_block *sb) > > > { > > > struct shmem_sb_info *sbinfo = SHMEM_SB(sb); > > > > > > +#ifdef CONFIG_TMPFS_QUOTA > > > + shmem_disable_quotas(sb); > > > +#endif > > > free_percpu(sbinfo->ino_batch); > > > percpu_counter_destroy(&sbinfo->used_blocks); > > > mpol_put(sbinfo->mpol); > > > @@ -3841,6 +3959,17 @@ static int shmem_fill_super(struct super_block *sb, struct fs_context *fc) > > > #endif > > > uuid_gen(&sb->s_uuid); > > > > > > +#ifdef CONFIG_TMPFS_QUOTA > > > + if (ctx->seen & SHMEM_SEEN_QUOTA) { > > > + sb->dq_op = &shmem_quota_operations; > > > + sb->s_qcop = &dquot_quotactl_sysfile_ops; > > > + sb->s_quota_types = QTYPE_MASK_USR | QTYPE_MASK_GRP; > > > > s_quota_types should rather be copied from ctx, shouldn't it? Or why is > > s_quota_types inconsistent with ctx->quota_types? > > I believe s_qupta_types here is a bitmask of supported quota types, while > ctx->quota_types refers to the mount options being passed from the user. > > So we should enable in sb->s_quota_types which quota types the filesystem > supports, not which were enabled by the user. Oh, right. Honza -- Jan Kara SUSE Labs, CR