From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18609C7619A for ; Wed, 12 Apr 2023 21:15:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D5BB900002; Wed, 12 Apr 2023 17:15:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 385BB6B007B; Wed, 12 Apr 2023 17:15:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24DB8900002; Wed, 12 Apr 2023 17:15:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 12C3E6B0078 for ; Wed, 12 Apr 2023 17:15:13 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CFA4FAAF97 for ; Wed, 12 Apr 2023 21:15:12 +0000 (UTC) X-FDA: 80673994464.18.0F4979B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 1BE4C100009 for ; Wed, 12 Apr 2023 21:15:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Rrr0D4OW; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681334111; a=rsa-sha256; cv=none; b=YGlQxHDuhAMW/Ma/YFDQHDZvZpXxdWNc8cTsHxSUMmJIsLJ0F4Bzh9/btVBGlMDL4LRpwL CLcNntdkRXbc0N+RaUbecCVzjKua5SVBEN1bd5mHrvorKKTyjkNr+rB30Bta3uPNpKTXDR QVnwSK9SSVJ6ihm0Ul0hcZ4gEVGlJnE= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Rrr0D4OW; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681334111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qIpqQvFcZZNrdUc7wexk7AQt2SgemP5D747U+HSajh8=; b=f40UHiAmyqxZVSrtODiNifCR2uD+0je7nHEi0seKz96EJzJ+rHm+rQ3QEuvd6+oVyfIaS5 j9dB+3MAlTPrPwwWk9IpAvg3vBtvMYwvwsN9BZVA6myxnGR5I7wKHT8JbgaZ4tjk9oqeZY 857vy4BwT+pEAX6Nu9BVr/lni/ZBXl0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A4DC62ED0; Wed, 12 Apr 2023 21:15:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04321C433D2; Wed, 12 Apr 2023 21:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1681334109; bh=rUARulnjOQ307xRRVyKm5Rnu9uPFHJQRoc2s3q/8t0c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Rrr0D4OWLyVLCRnjgYHThscFy+m3+ZBz+6ThAEp6ELd27jTeFGBOxTC5RicER1VCc TJu63jqtoYpV3rjCG/PhpJXDF4U08MrhJP7it6C2b36t/6y265PSgpNR80rSn/PybW cAuNxVHam5iVXb/KudaCh6BzpcsjET3APwu6m2fc= Date: Wed, 12 Apr 2023 14:15:08 -0700 From: Andrew Morton To: David Hildenbrand Cc: Sam Ravnborg , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, sparclinux@vger.kernel.org, "David S. Miller" , Peter Xu , Hugh Dickins , Shuah Khan , Yu Zhao , Anshuman Khandual Subject: Re: [PATCH v1 RESEND 3/6] sparc/mm: don't unconditionally set HW writable bit when setting PTE dirty on 64bit Message-Id: <20230412141508.d91f9e07df9dd840219098ed@linux-foundation.org> In-Reply-To: References: <20230411142512.438404-1-david@redhat.com> <20230411142512.438404-4-david@redhat.com> <20230411193548.GA2094947@ravnborg.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 1BE4C100009 X-Rspamd-Server: rspam01 X-Stat-Signature: 4fwjfw1o1cp5yk4yia654psk496xguy3 X-HE-Tag: 1681334110-487816 X-HE-Meta: U2FsdGVkX19qeWV6tZeBzr1XWpbjyc28GeX9wjorTyjKFI9znUEI5TgzVtjO6bteF9F0hxzXxtPKUt/RQbcdPW842+GSnP4UJIFC7xjbJwY3sXkVO5AFUj8an+DoyJRo40D5aIyr7iL/snwFQfUOxNnLwCg8Grpp0yEmigCcPbaUDNGYMR/dUP6bE6uYuIju8yg2sz6/1JzNp2aWokeDT6rsPkwPsgCZfZLoTfesywKmSgxMvMKoKO3AmEjhPhWCv0wlt2hW+o4cDR1Rl/pujshWvYMI3IXL3EB5KT/b2Y+BeNDoenSqHOAx1mqL/eBddK1DSA9svejC6UlE5KZNy3g5tzIDBExD/pFn3P0VyHBqmG+v632cY76TkZlPITXfQkWVXKo41RYYXXYq6wKAbvCN2QjTEjCRjckog2cIAYQQXsWX4LO71QPiyCT9zUN781IAqlcOFMuVvE7Lw7ri3JO8nTV0CxE9j+yiapdtsV2ysibDA9bSFqZFTpMfXsM4mHzFB1mKsv212GmHRlqfcQ8vsz50AcPOZN5j1ufDxOy1EJbHBcl+btopO4Ck3AuaZjpP8Gz33WO+dju7ytTfwbKVjK9gCKw2SVlb9duPlqtaq57ovyj0gHtxGWc4Afjj/SqUztuE94yKmGOOOTBvEWywujef6Cwa8nbLxzk4Qs1A+IoY6WuMl4yqud6slOoW4M7K9J7xTPZ3fQ1+NIx+wqHNFLdl7enbBlLqa2Qa2bPdXTUTzJE5x7NqlU+SQxmU0obdr+DzNbntoXP75xq5HooY7OqcreFciuDPeGu59WYRIxNKnIUf9CKBuJlaiHb+W5Eg/z+AZO7ZOZG1YetCCMENHlBiZmTWyI/7usTdBjxEEklyo2bg6/RU1IFFFh9+DtGaXo8f5o4/cS3fZzq56CGXdlXka4oNiaeh5t/1NcMKHYwuDs5fIDa5UkbAntdbG8e+xDXpBBwErubmgVz YFHHvp1x 62fja7XlB7tYFyAK6N7iRD6DEDslHfMQomYNz20g9vVsr9kXTILIzUGIgOi1NiCAVIU3/89bqeL3Ajc4TiAElM4Pl6q3l327BhamJYHNeVYQH7JiB7MaR93qDjOPTK0v/UVonFJ/JCYuMVZsVU4pfpf2B8oFjURWV+kEd2EY3SahWRsFHGBVdWyPWdEg+eXpmg8gClsf2gXaDzwDfq6Fr5QOLctQMJvX+07OKpQfdiwJ7LukJOM6unOOH1IPeKqF6kFW9DJVNU5gTsnl0WM5X3CHwqNuRoJfE0+ZECOhd0WvtALRcGsB0c669y3ttXLVLFcvpTaNyv+kfVQzGTXhVGoIJW3ligerprLWD4MX4EuQ74VBm7y4b1EU2TA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 12 Apr 2023 11:48:15 +0200 David Hildenbrand wrote: > >> We have to move pte_dirty() and pte_dirty() up. The code patching > > One of the pte_dirty() should be replaced with pte_write(). > > > > Indeed, thanks. I assume Andrew can change the latter to pte_write(). It was a struggle, but I managed to do this ;)