From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F547C77B6E for ; Wed, 12 Apr 2023 15:20:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B5D66B0074; Wed, 12 Apr 2023 11:20:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73E7F900005; Wed, 12 Apr 2023 11:20:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60702900004; Wed, 12 Apr 2023 11:20:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 49DE26B0074 for ; Wed, 12 Apr 2023 11:20:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D07F94011B for ; Wed, 12 Apr 2023 15:20:46 +0000 (UTC) X-FDA: 80673101292.07.ED4A92A Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf27.hostedemail.com (Postfix) with ESMTP id DA7224001E for ; Wed, 12 Apr 2023 15:20:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681312844; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2WC19rJXxAihzgCfOS6b733MqpAVNj+VT/XngzSDYUg=; b=692LGo/ISI+UCdtnTdLp86HTLhmmvuk+mCXdWFrayqyZQbnbCHmgNlIby5QEyEJKUYTvYn 09NdmqE/A6Dh4w3HdEGwdJo9lyB6f9Iw0ubnj9VD1shbP9ELXQf0U9GZcoIlBkkI3ptvx0 7jXDHOu/Xm/lE2wEH3nCsLkSxDv/2UQ= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=none; spf=none (imf27.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681312844; a=rsa-sha256; cv=none; b=Qs7s9nF34uI/e+1mGm5loaaFALwchfp2ge1Do5PE+KOZbJsHYMQWOdPT+sjb2VP0Bl/w2V L8OJ63GbE9k9tKinfKW8jpWmwH868I/chA9FhBN/Cj3BoB85qcIX9t9f3pCAXozmN1OY+z 0/KsyRo3EveYf4Nw4DmsxvgPBzPk9pI= Received: by verein.lst.de (Postfix, from userid 2407) id 241DB68AA6; Wed, 12 Apr 2023 17:20:39 +0200 (CEST) Date: Wed, 12 Apr 2023 17:20:38 +0200 From: Christoph Hellwig To: Liu Shixin Cc: Seth Jennings , Dan Streetman , Vitaly Wool , Andrew Morton , Nathan Chancellor , Christoph Hellwig , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next v9 3/3] mm/zswap: delay the initialization of zswap Message-ID: <20230412152038.GA26518@lst.de> References: <20230411093632.822290-1-liushixin2@huawei.com> <20230411093632.822290-4-liushixin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230411093632.822290-4-liushixin2@huawei.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: DA7224001E X-Stat-Signature: 78ihorg4yi7hmef3o3ku7mx6cgb7ukjo X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681312843-536948 X-HE-Meta: U2FsdGVkX1+xSBJwC/lxdzD7cOsO7udzKeYMjL5WwmObgzLoksNQTR5sTWwQ26o7UM6Egdqqpqor6WMNvo81LfL856BKFQ6n29D+yhh9D6POSQtOgM2Rmb2cOf/JBIgHAapD8PNjBDibBSnqwl8tODXdbkHkVypgKDZrMWsAInteTgevaurtwRZAq1aPqpBd0gs4ooCpgJqnyObLh1cfvVqquooTxy9hTlUC99FWFFJ0+K1cy6NrnQvFxF65G1/CgcqGOdMo35ctc0JXQ2wtloxxQ4x5/p4H4VhRu0zXYd7FakOpsk4NntOvuLs7ZA95vAPb7gpeJt5h5ntrxZ3szH3B+9bYVi36Yi3G/wcmTO4u83Zl/i9AuYKpriUb9m42XxGMkhOKY7wHiiK224T4xZyqLH3wuZT0kNgefGIU2q/F7sE63f/4i9GOu6w8vnHFvJsp1BQUWV4TridHDTg2Zoh6znarSuHUPaMoYCHpcvptNdnMB99jtbpgC6FpLgdq/9MF7ZvzQfh+I/W3IbZgMo13uMxhwCfCPNUptoqxlWMjDDVqw77Mn0HyfDpc0BSNenaWm+/Aa/kXq++D+i8uZryhGPRCDXEc48JcR+LIm/lXab623AmT5D6oL35zvs1PGDglkWW2a1stBgiMgD+eY1jkkyHFbb9b8P2vWmScCP3vyglB1JN/WB8yDgo0DGIwRhXjdpxJ//N+bVPN5M4rYhRPFM2TOp5FHooIWica0m1wQzy4B95H1c0pavl4SM78nZeSigzl5FupA6wEtyF14UQO8AHi3UjskMUt73p688IfYv5xCU8J5Pd/qlwD7Uhs7xBk8+H7CLCRoJ1J7ITJYiGS3uQuAZD0yyBxQUWP7VEwUtMRabwWP+1uhVhzj1aWZvCsZY8lBZVnJ8l9Ecn17nW/ynFI1ZtcHT/M6y5OfBb1Jsu1sxTal03YnAbONqAMv+5dv/gbkv11ouRHlyt KNMPgwIV cHP2cg8Cz78UiCyT7yvKCQPNP7pdQ/i0fvVkWEvW7//bC2oCtJs+iReDi5N05K+v8Zij2ASZyWop4iP5mV6vT88PyqalwXVIwUtQl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 11, 2023 at 05:36:32PM +0800, Liu Shixin wrote: > Since some users may not use zswap, the zswap_pool is wasted. Save memory > by delaying the initialization of zswap until enabled. > > Signed-off-by: Liu Shixin Looks good: Reviewed-by: Christoph Hellwig