From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E8DDC77B6E for ; Wed, 12 Apr 2023 16:43:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3EDE28000A; Wed, 12 Apr 2023 12:43:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF23F280001; Wed, 12 Apr 2023 12:43:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 990E128000A; Wed, 12 Apr 2023 12:43:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 87FDF280001 for ; Wed, 12 Apr 2023 12:43:10 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 57987140198 for ; Wed, 12 Apr 2023 16:43:10 +0000 (UTC) X-FDA: 80673308940.05.D72B727 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 28CE91A0011 for ; Wed, 12 Apr 2023 16:43:07 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jApp4+VN; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681317788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j2X1citdDCADI79RLi2EG2irLSOXCvsNG1ixWpJWId4=; b=A8zURgVP3mpLWG4ZwE2Tz4JqCwctk1WjRdlNMTL789fc3mdpiy5Nh1yhjCyRy//QNrRuoX cIPKyxWCofWmZLQYXgEpCGW2JZnXyjBNFIMkx/OvQRvhMm0Up4MX8CSqYH0A283n9z5bWS EdcJrkWAfJXftz7GkGtr0KCfYg3c5/8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jApp4+VN; spf=pass (imf19.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681317788; a=rsa-sha256; cv=none; b=0GFdRdy8giXwormKyS8U9UIpaw6FCcdlxcQ2y/j7TDDHCiLGC9yilnBcdH7iAQl3t9czwa 0NmdEgB00Fh6/mymBZ9SXjW5ZPnNKLyvBf/FVvB2ONxqpPTtgIQ5cBmi1kBZnvD9iqG6Oc 1tbV2BzQhgEKS5ZDmRqTEcC9fR0OoiM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681317786; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j2X1citdDCADI79RLi2EG2irLSOXCvsNG1ixWpJWId4=; b=jApp4+VNGmttBsApY3dwbKuIvF0u9kCxIGCUqVYgExY6gdnlvcPgczc/yjywT4+kNf6gyA ZLaPOAl7iMqsQeihUqdamVUzNfcukThfzWZCSY2kJCrwJiY8Nn3Wn7Ky2a1EBocw3MCqN6 73ZYTwQHquNdukIkVjk7FG8JaUNrPX4= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-261--dYaohRqM9-WwbgOryCQMw-1; Wed, 12 Apr 2023 12:43:04 -0400 X-MC-Unique: -dYaohRqM9-WwbgOryCQMw-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-74a90355636so62117985a.0 for ; Wed, 12 Apr 2023 09:43:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681317780; x=1683909780; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j2X1citdDCADI79RLi2EG2irLSOXCvsNG1ixWpJWId4=; b=MFSvyECbNxJ5tqRgtmPc76fJ/BUwTVzcFdgUa/6o/Kx9gpqi5e6S8zO8hbOGE01H4l cEh62+F4oux/6YA6FuaTXMRaXqpD+dfbC3UjA21LD2VHJMKjSwQq2mV+ISkV6L/JU3W2 1m+Bduf92SVxkBErvCzUzVmqqm0YBZvG53AMjYPZpHl08vzBK/k5TWskSLOopt4OhjHG SED9YX/YM4S2bIJZfhopxuZNML+SmigKrNBDkgVd4x3ec8MT34JSZkhSWqhqE6F3wHx1 wOmSn50t/kR/ylk9gobeYbRbqZ2mPGR6wZg5JCxfL0jhCfpna95r2ApxO3SYddR2YzLG wbGg== X-Gm-Message-State: AAQBX9fwDJ96AqaXbBDdQF0DCO/Uj14hTnS0eEtI76sqrprva4t2EREq h8f4+TgN/eW2kCK8HWX4IdWhXhN/IxNA2dgt/6HS+Dv/SfFguYVlH3OEWI5XrsJHmPkKSRw+KaU dt6F0G7pA/Ss= X-Received: by 2002:a05:622a:189a:b0:3d1:16f4:ae58 with SMTP id v26-20020a05622a189a00b003d116f4ae58mr31197650qtc.2.1681317780504; Wed, 12 Apr 2023 09:43:00 -0700 (PDT) X-Google-Smtp-Source: AKy350aPP59fS6v/hiPCzvysroXh8Pq2l2mHvfmOO33uNBWw/uqCl3sAmpEBcvmZzo74rNrgkQNwyQ== X-Received: by 2002:a05:622a:189a:b0:3d1:16f4:ae58 with SMTP id v26-20020a05622a189a00b003d116f4ae58mr31197613qtc.2.1681317780186; Wed, 12 Apr 2023 09:43:00 -0700 (PDT) Received: from x1n.redhat.com (bras-base-aurron9127w-grc-40-70-52-229-124.dsl.bell.ca. [70.52.229.124]) by smtp.gmail.com with ESMTPSA id p9-20020a05620a22e900b007486d9fa1d7sm4786784qki.95.2023.04.12.09.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 09:42:59 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Andrew Morton , Andrea Arcangeli , Mike Kravetz , Nadav Amit , David Hildenbrand , Mike Rapoport , Axel Rasmussen , Leonardo Bras Soares Passos , peterx@redhat.com Subject: [PATCH v2 16/31] selftests/mm: UFFDIO_API test Date: Wed, 12 Apr 2023 12:42:57 -0400 Message-Id: <20230412164257.328375-1-peterx@redhat.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230412163922.327282-1-peterx@redhat.com> References: <20230412163922.327282-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 28CE91A0011 X-Stat-Signature: 3djibhsmp8eau8nynrjccuir7hpwj75w X-Rspam-User: X-HE-Tag: 1681317787-996606 X-HE-Meta: U2FsdGVkX18v01mJAccdNH0gXLO60/Wsnv2cQy4Q1Mea7j6ZEl6BMr8g+F/J3FtZo/lWkTOXA2GliJowVAT2icABOSlBG7RMQh6k+EqqwMhlan6GrFrlUo0eE2dmKqDaENCtfTQ0pfzDHkKcWeQbB5Hv8usWi2yBMy37ZY+DE1Acl6LeoCt/DTDyr6bNeQYfxOad/hBZ2cHJU1at27tUCXGCll/SYTgRXrq3yBoMzEUvDm8GZ4uFO/zi/ot0FxwOIJla/a1lXFDBBgBV/u5B6Wlxe16E3R7arwnpn1NGnHaTzfrHP8RhGRhkkV7d0uN6voOQAup/rEnIO/Pn7yKgoghe2UQ3AH6YC4bkHzBr9qP8PRR7IIiBsjmbDKvPrq1cWlc6+1JBRavXAjzOvAxTKK3ir4s+xHaztiquB73UrZgRzxqICNX//HRSxJU6WbrF745AuO4A3aUKL/Pbs8NqidRZHMu3eY5GyhdGvi7ghJmsRN4TTO4fSOddFZptJ1GL3guDmGoydDzpYGp7JwNSqgrbcgPMX4dDIDRR5aG4YL5EzKi7vMWFvytPtG9Fx1QBIULXIRW/XhtVy/XVJ8lSKIFRjuY6Qje2rFpMuhvHq3bRdbAVdFz/njnN3zcRBttaL3k+dgCvjvlQuYqgvKXVfsiQZUTSXbHSJg1g1BHaHJyfMLv2z4Q0q5qqxGSUfRDgFrVQwabKN17ZbNp7m++yLgmYcWqLH1NBjwTyrl4hyWYPBZMANssZyFyyr9f+gfvVYW9fEPFEQjFIDsN2lx9FrOaRdS11wj9D4rM2BDp3tcrWuY4iXTAt+XFr33W0frwFsyFpBd3g/SmpDVjQf7kz0PUuTed/VEI80VcUmNRVjrWqhVcnogzyKM5W1XBwxEmCfA/PgPbb3OSzjy4QXAgUd+4sEYNpG7m2B2dePlB4gU4oPUsIHJUlGr210ez6QeToeotXY6dhPeVQjiI49S6 s9co1XyW rxl5SVsy1VZe16avViCmuEJUSiVrnnM09gmvKKGaThHfUZ0maYwYhiHC5ICmHH8NBlfmNQUout9hv9pZO/namj2OKyvv/y4HH+IsGkJ2q0ThEmDupYU//n45Bu2KB9WLLTcD56K3HC3vr8fhqYlvps/1c8gqkWlkKbH8oAQBFXFgqaNH9SLQBdGfCuZuLG5xqoanBX6Fb2Td8512D+ayYpVZAo56B3yTu4GP/Mjb8o7StMlMbfTTIq5OlgZ5UAQ2RqLZ/9nsgTvdkOJadBC0ED5AhFbbZirGgq3RfCUpIcIxApF3jUWMzFigP0a0na8/UcI3CMznTrnUZh+eFSt10DD1zACwtlZvV69C9hUfzCN4NhochHV21ZcHeyA8U7Q7vHn9S78lGDSQIjpxzNWL8OIHeOJD1fnbNJT37+PPNxgVszqpouoLA+Zf5GkhkdjnYTBZIxtT56IlzYAEUm5CtTVQxtQv1Jou7jqzVHf1MlLNauR9tO2mH6PRFWw2aoU5PsiBHSqfZ7QZ26oI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add one simple test for UFFDIO_API. With that, I also added a bunch of small but handy helpers along the way. Signed-off-by: Peter Xu --- tools/testing/selftests/mm/uffd-unit-tests.c | 109 ++++++++++++++++++- 1 file changed, 108 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/uffd-unit-tests.c b/tools/testing/selftests/mm/uffd-unit-tests.c index 6857388783be..bb492c258486 100644 --- a/tools/testing/selftests/mm/uffd-unit-tests.c +++ b/tools/testing/selftests/mm/uffd-unit-tests.c @@ -9,9 +9,116 @@ #ifdef __NR_userfaultfd +static void uffd_test_report(void) +{ + printf("Userfaults unit tests: pass=%u, skip=%u, fail=%u (total=%u)\n", + ksft_get_pass_cnt(), + ksft_get_xskip_cnt(), + ksft_get_fail_cnt(), + ksft_test_num()); +} + +static void uffd_test_pass(void) +{ + printf("done\n"); + ksft_inc_pass_cnt(); +} + +#define uffd_test_start(...) do { \ + printf("Testing "); \ + printf(__VA_ARGS__); \ + printf("... "); \ + fflush(stdout); \ + } while (0) + +#define uffd_test_fail(...) do { \ + printf("failed [reason: "); \ + printf(__VA_ARGS__); \ + printf("]\n"); \ + ksft_inc_fail_cnt(); \ + } while (0) + +#define uffd_test_skip(...) do { \ + printf("skipped [reason: "); \ + printf(__VA_ARGS__); \ + printf("]\n"); \ + ksft_inc_xskip_cnt(); \ + } while (0) + +/* + * Returns 1 if specific userfaultfd supported, 0 otherwise. Note, we'll + * return 1 even if some test failed as long as uffd supported, because in + * that case we still want to proceed with the rest uffd unit tests. + */ +static int test_uffd_api(bool use_dev) +{ + struct uffdio_api uffdio_api; + int uffd; + + uffd_test_start("UFFDIO_API (with %s)", + use_dev ? "/dev/userfaultfd" : "syscall"); + + if (use_dev) + uffd = uffd_open_dev(UFFD_FLAGS); + else + uffd = uffd_open_sys(UFFD_FLAGS); + if (uffd < 0) { + uffd_test_skip("cannot open userfaultfd handle"); + return 0; + } + + /* Test wrong UFFD_API */ + uffdio_api.api = 0xab; + uffdio_api.features = 0; + if (ioctl(uffd, UFFDIO_API, &uffdio_api) == 0) { + uffd_test_fail("UFFDIO_API should fail with wrong api but didn't"); + goto out; + } + + /* Test wrong feature bit */ + uffdio_api.api = UFFD_API; + uffdio_api.features = BIT_ULL(63); + if (ioctl(uffd, UFFDIO_API, &uffdio_api) == 0) { + uffd_test_fail("UFFDIO_API should fail with wrong feature but didn't"); + goto out; + } + + /* Test normal UFFDIO_API */ + uffdio_api.api = UFFD_API; + uffdio_api.features = 0; + if (ioctl(uffd, UFFDIO_API, &uffdio_api)) { + uffd_test_fail("UFFDIO_API should succeed but failed"); + goto out; + } + + /* Test double requests of UFFDIO_API with a random feature set */ + uffdio_api.features = BIT_ULL(0); + if (ioctl(uffd, UFFDIO_API, &uffdio_api) == 0) { + uffd_test_fail("UFFDIO_API should reject initialized uffd"); + goto out; + } + + uffd_test_pass(); +out: + close(uffd); + /* We have a valid uffd handle */ + return 1; +} + int main(int argc, char *argv[]) { - return KSFT_PASS; + int has_uffd; + + has_uffd = test_uffd_api(false); + has_uffd |= test_uffd_api(true); + + if (!has_uffd) { + printf("Userfaultfd not supported or unprivileged, skip all tests\n"); + exit(KSFT_SKIP); + } + uffd_test_report(); + + return ksft_get_fail_cnt() ? KSFT_FAIL : KSFT_PASS; } #else /* __NR_userfaultfd */ -- 2.39.1