From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42DDC77B6C for ; Thu, 13 Apr 2023 00:51:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 556656B0072; Wed, 12 Apr 2023 20:51:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DEA46B0074; Wed, 12 Apr 2023 20:51:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37FE46B0075; Wed, 12 Apr 2023 20:51:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 24CA66B0072 for ; Wed, 12 Apr 2023 20:51:55 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 576D2C019F for ; Thu, 13 Apr 2023 00:51:54 +0000 (UTC) X-FDA: 80674540548.25.4C1A1E9 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf17.hostedemail.com (Postfix) with ESMTP id 85AC84000C for ; Thu, 13 Apr 2023 00:51:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=LQ1Bz7Jt; spf=none (imf17.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681347112; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Di73Dcq4sxa3H9jRbxC9bukus+StxvYCTBkPSR1lRM=; b=wGB8TsPvDo5rNWLmwzRO6GZPp2j4syvF6n7tajytMilUS6w+TJTJPr7kc8xx1tGSHDq03D dDOf2/ABatctZDu1utUqkusLnn8n5G2v72gCbT1EfCL+wn/T/Y1JCy79O2oGkbnmnH8Yq7 Frt6i+Mklf/PD4IzwfdVsB53r2rB6Ok= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=LQ1Bz7Jt; spf=none (imf17.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681347112; a=rsa-sha256; cv=none; b=kysyrsv3ZEN//JsN7FvqS48MBED+u1TclmU5mjxp9sVpem818QZgvv5nlsqDw9YgkXCdX0 XT/4pQyf0PKCebGFezMvCKBhRTnnwpQxpdyQ/tvspJcVIt9NJo5CamAP67BUr3K3VHd9iW sArd+D7Er6lYLoQKJSGcEceJPuN95Vo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+Di73Dcq4sxa3H9jRbxC9bukus+StxvYCTBkPSR1lRM=; b=LQ1Bz7JtOuSH1niLgur107JVw4 gZXvIhGKayXkA2z1WSNtf0XSpfNtgdBbzpUM4NecQhIdXAONAqeqyyEdkQFfZLI3r0bgMpo+PDqSY KZ84fC2o/qEpzd7C6VtFgGpc8rNmqTrsqNgkyV09P/3JOCXKHsc1r7T4w2XbezJ7KOS8X9P0FteYS k4RxCT/Xkw5mo2dtTRZD6DV5WPaRnfUqb0Wfs5YDGjPPZ77/0W9/7jgVRw6qbYTQpDg/g3VuWxkQF cM1cNCFhaZ1UvAlqvGVs8lOTMRUDJcOnHBEY0CPZzdDjHq0IF75dh/1HDGn2nYYCrdBAPNlf2Mc1n RbwYiyuQ==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1pmlBR-008TvN-2U; Thu, 13 Apr 2023 00:51:30 +0000 Date: Thu, 13 Apr 2023 01:51:29 +0100 From: Al Viro To: David Howells Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Willem de Bruijn Subject: Re: [PATCH net-next v6 01/18] net: Declare MSG_SPLICE_PAGES internal sendmsg() flag Message-ID: <20230413005129.GZ3390869@ZenIV> References: <20230411160902.4134381-1-dhowells@redhat.com> <20230411160902.4134381-2-dhowells@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230411160902.4134381-2-dhowells@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 85AC84000C X-Rspam-User: X-Stat-Signature: fbumyccxafiw83ytr83tazu58d37wr6h X-HE-Tag: 1681347112-879791 X-HE-Meta: U2FsdGVkX1/7eKJ5JBDWCnJhQDqKGfL9WlUd4hfWoQhZBjKZi3iDDhlUf9IGpE3edlS5PkMXRiH77kf8+9fRQxVDbm1Uj+bUHammDfnzJTEEwDXEuucRNrkNBJlF4qg8VxwutDdjxRvgPkyhwhxgJUlz7GJdIo2+oVef2oPgy1/cn1hgXZEam/yU4P1W8MHpHZAGAIAIz04GlyKg1Fl9nsffecL8gZh97AaDOjXsIuXCsxOrYADy6iV75O6mlWQHhC3YQXxBCbYIHquqnHVbsGx5lDIEDGAQwQ9WHbE52PwubxpsDJPZ5cGFRab4mwFntqmri6i+s3c6kR414n0bDvQsdogankFFp/b7D4h7AljsA83pV4VC5KYqafRrGuQmbCg1DbZmpG1AIcRnCp+NTssDiTRk5+l//DjEBdmG3uJHLnON2K4lwoBtkN1Z4APtopqqEhy4kmYFmIv+9Ctw8XS4o1z3mr/6ZpZvezGhIGj2qBBx8t/Gtt8/vQ4CPHESZAdwOCDQfXhpCsvnLY/YdfOciSG29f9nSgPiQCL3fgda6iaWjAOrM7SAgHzx5ZpHSe5fFLtOUXspA3zGvOnSI32dRBLRSw+hQt6Lo5JPf9mo2oMxvaxDH30mPVE+8cWfd28xS38FkbMquL29ZHj7k3dG+1M2joSuxqV+qxQl5YpXc+eiNup/ogs6rQ6vazfgOBkVs5lJsBjICwxhwAmGOGBOrDS1RYltgWItMnxwVlrIhZ78SkZ/Xm5b4yvDxbq/wJT+wSa3GiOMXxLDed8SO+TJlh1fYQG3Q/FPMgyd9pxs/Mqi92kbCGuiPfycEZvpxQCuBqJHbyLe8yHQ3iy8g9s7DBvEJWBQwxtbwnt2XhuO9cWvGDbGCJT/75EjQ7nt5uoyerzpnq22Q0UkI6DCdJVvsPLljyOlALCI6SPSpWHFCDAtjUMHbBu2ThoEkJqzAEQYB6bIf6xbq/8z9jJ jBywY7/r UDzjY8jOMWaSUhRDJ8pLsz8hCiPLcg8gOpk4qQX67uk9+Rh2HCbSzehFSLNg0F06aNKObndb0JRn+MCBwJTDCDzv6SMCCC3/F6YY1Z/XYclpjyT/Teq80OsdUTsa23gLTadU3ByPv/HrNSCJBQOew00si++ZGjjsdjCCcf01huC2G+VVTlylgTM9IjppnFPN8qLMtLaTxQAobsKCmGnPSfGEXbn8prJcMAvuqfuebu/iCO//LTEfH9+UGh5sfGuFdtrxuabaSyFVK8N8m/Steq9cJJvM4MxzbhkCIO4E1hUKb9RqO2qY/ab7P5OAlVKOKryoKCqlIVXaA2H4eSGIoOyQIdWWQwrjNpeqX7+0bb80H+UheJIYtEIxX7x7eC3o6VAihvTQy/8ooY3QQqOzAw4qhhw17KJLysNyq5G5Psy8a8kR0inm0XlqbadAWc1WOh5PNFOve5BoV9vyO60EknIUdY+0IXySQKLsxPICe5483Up5NmmxYouNjWRaSSvgOdwgJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 11, 2023 at 05:08:45PM +0100, David Howells wrote: > @@ -2483,6 +2484,7 @@ static int ____sys_sendmsg(struct socket *sock, struct msghdr *msg_sys, > } > msg_sys->msg_flags = flags; > > + flags &= ~MSG_INTERNAL_SENDMSG_FLAGS; > if (sock->file->f_flags & O_NONBLOCK) > msg_sys->msg_flags |= MSG_DONTWAIT; A bit too late, innit? There's no users of 'flags' downstream of that assignment to ->msg_flags, so your &= is a no-op; it should be done *before* that assignment...