From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73049C77B6C for ; Thu, 13 Apr 2023 07:02:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE7726B0074; Thu, 13 Apr 2023 03:01:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C9711900004; Thu, 13 Apr 2023 03:01:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B36EA900003; Thu, 13 Apr 2023 03:01:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A4BDA6B0074 for ; Thu, 13 Apr 2023 03:01:59 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 61A5DC01AC for ; Thu, 13 Apr 2023 07:01:59 +0000 (UTC) X-FDA: 80675473158.17.55120C1 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by imf20.hostedemail.com (Postfix) with ESMTP id A7B2F1C0025 for ; Thu, 13 Apr 2023 07:01:55 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=kSGWldT+; spf=pass (imf20.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.34 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681369316; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ytD3gC+o6uQdMb9JsRQtUPDHm660IdMiQVFyF8sQSt0=; b=xKF6B0CBS4uWpCbtDwKUXg47T8hHEwqAVOWb4NkHJtbaPSmhmsTjT7htzCgGYGceUZuQ+Z 71N3x3fMSeKNxEdFuU92+D2tnYdH3WPAoN7aaTtG/ZmcscmixuuHP47QwNnwxXVZ6dvBJ5 G5xbmy9Ddq36dtxCl2dA/o7wnJpagOI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=kSGWldT+; spf=pass (imf20.hostedemail.com: domain of jaewon31.kim@samsung.com designates 203.254.224.34 as permitted sender) smtp.mailfrom=jaewon31.kim@samsung.com; dmarc=pass (policy=none) header.from=samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681369316; a=rsa-sha256; cv=none; b=l/uDJzxXDQy+mx7KzyVDEsi2/GdKWoB4vRkPXNTnf/gf0s+DQu/O5PTaIkKDj06hApmK2L qw3D8PD8VrjLtxW+PMODcS+YD3ToJ2bXYvLiGYXUAU2V5kGizO5eEIDVRMVQbX4w5kdK8k g2yukiaKNJq3gm4ZWz/gVus3TEus170= Received: from epcas1p1.samsung.com (unknown [182.195.41.45]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20230413070152epoutp0440bd74b103505b5ef508d5659017824d~VbHsrUCgz2370523705epoutp04R for ; Thu, 13 Apr 2023 07:01:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20230413070152epoutp0440bd74b103505b5ef508d5659017824d~VbHsrUCgz2370523705epoutp04R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1681369312; bh=ytD3gC+o6uQdMb9JsRQtUPDHm660IdMiQVFyF8sQSt0=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=kSGWldT+nrPPH1Hxll2gu1kMnjxxThhF/rVfgnHUfgKNbAyODh1d09oc6Ct5Hm9Vv ui8SYBOIJYXq9y4agK/iHyyQRGsKuNeyPJWk9caW/qRYy8zthgmrXxXpYE63kAwjL3 TbSgAxYHX8XM/dchIxD/QVQIZjAztIAxyyEyFpiE= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20230413070151epcas1p2fa916d723ecf9115689c531bf29e057a~VbHsL5Mla2745127451epcas1p23; Thu, 13 Apr 2023 07:01:51 +0000 (GMT) Received: from epsmges1p2.samsung.com (unknown [182.195.38.243]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4Pxr9C1nw5z4x9QG; Thu, 13 Apr 2023 07:01:51 +0000 (GMT) X-AuditID: b6c32a36-b27fa700000025c4-e6-6437a8df6f08 Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p2.samsung.com (Symantec Messaging Gateway) with SMTP id 1A.AE.09668.FD8A7346; Thu, 13 Apr 2023 16:01:51 +0900 (KST) Mime-Version: 1.0 Subject: RE: [PATCH v3] dma-buf/heaps: system_heap: avoid too much allocation Reply-To: jaewon31.kim@samsung.com From: Jaewon Kim To: Michal Hocko , Jaewon Kim CC: "T.J. Mercier" , "jstultz@google.com" , "sumit.semwal@linaro.org" , "daniel.vetter@ffwll.ch" , "akpm@linux-foundation.org" , "hannes@cmpxchg.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "jaewon31.kim@gmail.com" X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20230413070150epcms1p1f5cce7b0009d0b8e6466c4be74ed2b41@epcms1p1> Date: Thu, 13 Apr 2023 16:01:50 +0900 X-CMS-MailID: 20230413070150epcms1p1f5cce7b0009d0b8e6466c4be74ed2b41 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P X-CPGSPASS: Y X-CPGSPASS: Y X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrMJsWRmVeSWpSXmKPExsWy7bCmru79FeYpBmd7eCzmrF/DZvHykKbF wod3mS1Wb/K16N48k9Gi9/0rJos/JzayWVzeNYfN4t6a/6wW9/scLE7d/cxu8W79FzYHHo/D b94ze+z9toDFY+esu+weCzaVemz6NInd4861PWweJ2b8ZvHo27KK0WP9lqssHp83yQVwRWXb ZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gAdraRQlphT ChQKSCwuVtK3synKLy1JVcjILy6xVUotSMkpMCvQK07MLS7NS9fLSy2xMjQwMDIFKkzIzrjw 8DpTwUO+iov3vBsY73F3MXJySAiYSNxbtZGpi5GLQ0hgB6PEry83mbsYOTh4BQQl/u4QBqkR FvCX2PdiDiOILSSgJHH2xxV2iLiuRFP3ahYQm01AW+L9gkmsILaIgKfEvQ0NLCAzmQVOM0s0 HHnNArGMV2JG+1MoW1pi+/KtjCC7OAX0JK48yocIi0rcXP2WHcZ+f2w+I4QtItF67ywzhC0o 8eDnbkaYMX+OP2eDsIsllnU+YIKwayRWnFsFFTeXaHi7EszmFfCVeNh2AWw+i4CqRO/FBVDn uEg8OfMe7H5mAXmJ7W/ngIOBWUBTYv0ufYgSRYmdv+cyQpTwSbz72sMK81XDxt/s2Ng75j2B OkdNouXZV6h6GYm//56xTmBUmoUI6FlIFs9CWLyAkXkVo1hqQXFuemqxYYERPGqT83M3MYJT r5bZDsZJbz/oHWJk4mA8xCjBwawkwvvDxTRFiDclsbIqtSg/vqg0J7X4EKMp0MsTmaVEk/OB yT+vJN7QxNLAxMzIxMLY0thMSZz3y1PtFCGB9MSS1OzU1ILUIpg+Jg5OqQam+qVsr9XfBFx2 0LmVIPFovkjH7gK9lYsnHVTdKRCgkaPb/DtL/e1y6fCZYhXKsY5L5urf3S+7IP9M7Pz37xU3 HNmcusPLoOUMx7y92klyt7f3x2wMDLWJKBUtPn49603jz1L7Cu2CDzPa/+sXVG2rMwxmkg07 cMdka/rnX1VfJFXDXY/+lAx8Yb/3YursNzs/Jxf90ufjm2sponU5No7nefQrzpJVN/b9bc94 s2Za2KI7p1eHzGVsm+cuzqC3TnGhxTc+0SKntxY7nZZYL+SNv6tjL756Bo9vzJU9By/+vM6r W3bCe1P3y5NnV8fNXbSqLPnMyiMrTsydqd5Tt23DRVv5K5bT5zc4nQjofHv5ihJLcUaioRZz UXEiAGaHy6BGBAAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20230410073304epcas1p4cf3079b096994d69472b7801bd530bc7 References: <20230410073228.23043-1-jaewon31.kim@samsung.com> <20230412085726epcms1p7d2bec2526e47bd10a3b6ea6a113c9cc3@epcms1p7> <20230412094440epcms1p445319579ead0d0576bb616ebb07501b4@epcms1p4> <20230412113759epcms1p8cb15b54e3a96c7616419cb030d16f804@epcms1p8> <20230413001658epcms1p611d149fcbbbd06fc17387724f4f16359@epcms1p6> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A7B2F1C0025 X-Rspam-User: X-Stat-Signature: iprkdqkrasx1ie4z934ci1b4z7gq6i3p X-HE-Tag: 1681369315-528607 X-HE-Meta: U2FsdGVkX1+Fj7WDQZRGqxQPZVCwxjHW8ERa/HYVb6XbzasBRS6PNuRMt5q4y/FJmvg72Q2sOGMQKTZ+wZoqk4qUjLmFwVmtUCoggsLpzKL4pjibgcg08cS/CidcpJJV2hj4+nioEg1vCoAR71XgH7+KkgWOiG8FqgltUyEGQTEGKOY27nF7grp7VbapsPX7fayyHJKqNei5uyUHQKReTlDhPQR5gch9fFaqva27IZieA7dbkrWaUkDkP1wdVfzddTKG1HQTMxDaRTmCCLRatyTy3WtQ7CgDM2VCpc1FdoyWvRqLr60Nn/CKNRmnX5k6qXAirWIK1MfCJ33jNvTu0eaNMQ+/yf0nSwzu8IQqbZpzE/r2j/TobryZxHygRbkBYbfma669tRFELF363hud8zccj4oZiBASGeMyLtfjR59yzsakWPD6syXVS9LeNAdLTZ9IjUmHdbGS08RKPM+ZWiC/SrxmwRXcU3OFHfe9h/hor/8JnJPCXRXSDhzDugnDcZRj74XLC5rEkC9OnF3xXmUxUUNccrVCVkcRazYGjmt1Y6ZWbWnaR4XJZg/W1xg9K6clHBs6r1gqCywK/rDLsCYxnSPPZo1j6AVZHIzPAWNmKym1o5kRdM2vTGeenwJlLXL16BFvwEXWZxXKmbMvj8/EkfoMkQ+ef5d2vTGixTOavoIrSppMOPtY2DyfzRDkYcl8zE62Rl1ghmitbNY6ZKwhlrOvcynF3f70wIiF5H97FF80Ojj+s88OD4qDPIvPFkoNGfH9Kaum6yd1/mSXjR7b9RQk7bGsIqSsQyctwnqD7fEVAxRay8Vyi9rCVkhnqheUbYQ1DqxTSemCSiWyJENVJxLY1RE99jXBeuwNzIdCNI03KNeNenU5xsw2wZK2HtECusJ9QFCApw9ZPXP8UBpFF3OaDRsy9m0kOCQU2drrNJv42FqwX7jZUTMXEx1nUXcGZnN+zagLZ3UyKbn L8FZPCti oTz9EHZkJXAh/tnSgr/6altthwvYh5upv5QE4NXrXv4gbxDL6DKP4FRMQtcJ12ykqLFXx9Ct3zUCFBuCJlyKJanAVQ2PQzzFevuFDGP34MeiQRrzsACVV3ZNaU58CtcMhojZo0y5jx0V2LPENUISPu6JcNhfcfZKFfqqthlMFb58iDVK4a/epZC4xMte2vsdZcUK1wnSvSMwfmPJ5EN/k7G08KZKVLImAdJ2azlyMeE3SKHIywYS93UAS+l4EVNjtJ8KpJ7kWRaP/5ucjod+p28cEtSaB1znHWuNGyKRhndiVE6rHMgO9todZ/dxbVgTQ0/LGHskOjAZTQxHb79Vioo4eQnyAkyB2NwE6joOiARN5D6/WJNa2rZOC7UVigDCVPTdI3qfFG+rXL+w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: >On Thu 13-04-23 09:16:58, Jaewon Kim wrote: >> >On Wed, Apr 12, 2023 at 4:38?AM Jaewon Kim wrote: >> > >> >> Yes I think you're right. As a allocator, dma-buf system heap looks to be loose >> >> in memory allocation. Limiting dmabuf memory may be required. But I think there >> >> is no nice and reasonable way so far. And the dma-buf system heap is being >> >> widely used in Android mobile system. AFAIK the camera consumes huge memory >> >> through this dma-buf system heap. I actually even looked a huge size request >> >> over 2GB in one dma-buf request. >> >> >> >Hey can you point me to where you saw a request that big? That's a >> >non-buggy request?! >> >> (let me resend as plain text) >> It was one of camera scenarios. I internally asked and heard that was not a bug >> but normal. I think 2GB looks too big for one graphics buffer but it could be >> for other purposes like camera. I think the system heap should support that. > >Is that any of the upstream drivers or something sitting out of the >tree. I don't think so. I guess that is userspace library rather than kernel driver. The user library directly might request the size through dma-buf ioctl. Even though that is kernel driver, I think the driver may not be upstreamed. > >> Regarding __GFP_RETRY_MAYFAIL, we may need to say dma-buf system heap was >> designed to gather many pages up to a requested size. If mm returns NULL due to >> __GFP_RETRY_MAYFAIL, dma-buf system heap will release other already allocated >> pages, so that it may help to avoid oom. > >This really depends on the other activity on the system. If you have a >more concurrent memory demand at the time then you might be just out of >the luck. Really, claiming huge portion of the memory shouldn't be done >nilly willy. I agree on that. >-- >Michal Hocko >SUSE Labs