From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B390C7EE23 for ; Tue, 30 May 2023 23:24:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11DC36B0072; Tue, 30 May 2023 19:24:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CE906B0074; Tue, 30 May 2023 19:24:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED8A8900002; Tue, 30 May 2023 19:24:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DB6DA6B0072 for ; Tue, 30 May 2023 19:24:39 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 98C2B1202FE for ; Tue, 30 May 2023 23:24:39 +0000 (UTC) X-FDA: 80848503078.22.498290E Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf14.hostedemail.com (Postfix) with ESMTP id B33ED100009 for ; Tue, 30 May 2023 23:24:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=lgr7oULe; spf=pass (imf14.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685489077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y478xapysK5Y6/1ukdDKp0Ru49aHZ8upe1tGcc0Bcjo=; b=Pq2FkQRzVoUgUe0fFrJFim9gGHQZqBTcCF4lHIipHLQooMQ7Sh3+SIug7/I0r1DSF66Ri6 BmUvvrn1teUGssWUcY6RAvONUF0CzYGqIMoQMpBAYOXIel9WSeVF5RodYcKbHcTmgSG35p 0Abdfk+vFThbLnqjTBAuiXhoz8apE3o= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685489077; a=rsa-sha256; cv=none; b=GaPvua4lqWM5oQhnH0D+9ezX7e9Ui9wxSU9n5ZW4FmocD5nb7eWDlyYfsjGZDMPtm5s/2R kVU+PCBnciOzPds99CLKaVKiWW9AWO3hA95eqeW0ipvhaz80pr98Tgb25b/RNv+0ND8CZ7 Kl7xuVtRK8vX49AgZ1k+l1YUurC0auw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=lgr7oULe; spf=pass (imf14.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=nphamcs@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-64d2c865e4eso3858569b3a.0 for ; Tue, 30 May 2023 16:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685489076; x=1688081076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y478xapysK5Y6/1ukdDKp0Ru49aHZ8upe1tGcc0Bcjo=; b=lgr7oULerKqHszxccCrJYVgD/4Mb+Xf93whmI0BJUZ3Rk1zoloaPVLlE5mgGs0zvXC Hf2E5AFr6Mal6+7ICofW5MZOPuZN5QViJtY+7GNQcA/knXTMCcPkI455pTbJfnoRCh2Q azLiQmFSA0z8hhb0tOjHeEYHnwGauMCNSH3Wn9v7hwAKGgLiVTKiSsLkUQPkbWjkmm5e xcfmphymNFDSm7giK0ophLmOwbxkr2PkMsGTSLa62hlUXsUKiujKEFo8vbqPyQKblCDf fIYB/qS8IdzILlDY8kcqQzAaoOP9nm/DzWcJD7VYDSFAeeznLTJyaihwFULB+1VoVTCb fRfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685489076; x=1688081076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y478xapysK5Y6/1ukdDKp0Ru49aHZ8upe1tGcc0Bcjo=; b=NwsFCLjnLtDLwAuR5nO+UlU+lRbQIBcWKlUpabVC/J8N6GpxfzGT3AgX2kmK/oDlPI GIE21+7nSV3uAgZo+SM2MnZvbwdbJbSkdgBEdvkfPB+96V/aL/vl42IuWt54MDw7oR4N 03SElRgo+LkTHdLBwXcXDDbqSA5+Kz1s3s/ffNrKVpvogFfsrMsj2NW7sKwHV+oXjIBO O2fJfbt0qOP8rumnWdLUfP1BLrWGvupIGLW7crfzDO/LNC3HaOuj0sAFn6Sk2hEnBqHM HeMxM4dhpVOmSFm/JHF9oSC8fvd6lVjqqUxFXykOyfx2EedwWyt+d4jeDVhpO5R/opHC L1qg== X-Gm-Message-State: AC+VfDwkoRcfLgYmiVsaS9pNBT5WhfCEsPd68ODS3yrgNRhHbAmLTDIe QyWEjRnavqcS2eCRifSn0x0= X-Google-Smtp-Source: ACHHUZ6XC6V+fXFIqsU0xTsnhBmbya3jQDX3MU9I649f2Oze9PzKhOQsiGByYvvfL11dpEabCVA0/Q== X-Received: by 2002:a17:902:bb8d:b0:1ac:7ae7:3fdf with SMTP id m13-20020a170902bb8d00b001ac7ae73fdfmr3055806pls.41.1685489076332; Tue, 30 May 2023 16:24:36 -0700 (PDT) Received: from localhost (fwdproxy-prn-003.fbsv.net. [2a03:2880:ff:3::face:b00c]) by smtp.gmail.com with ESMTPSA id h6-20020a170902ac8600b001a1c721f7f8sm10821675plr.267.2023.05.30.16.24.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 16:24:36 -0700 (PDT) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, cerasuolodomenico@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, yosryahmed@google.com, kernel-team@meta.com Subject: [PATCH v3] zswap: do not shrink if cgroup may not zswap Date: Tue, 30 May 2023 16:24:35 -0700 Message-Id: <20230530232435.3097106-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: gi164rt81aidnswdob34nnpisq6pz5ci X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B33ED100009 X-Rspam-User: X-HE-Tag: 1685489077-616536 X-HE-Meta: U2FsdGVkX1+upE1pLWZkXaifheUHx8wAtiG54PAHlFsKJ7SBeMiRC9zMHsji2iaWUSjXY8pdACQVLzfmQzmfNtxTRhO0FqlQkAKb1DUKYOW9KubN1dpJpI+pVnSHM3LjBW/j3ZPzyucFp4F5Gknxg9U507xbv1/qqcNA74Q+30jsae5FJF6T3j1crAX3q6tFOWDX0TaBxdEV1RReEMEbGG6OaXr9P1wyJlogF2JamPghw6mvj7r9IDH8AjbPC8++BX28+f6dErCJhojnVS/Kk1HipAo+nQismWEvchE95W8/ppWZXazkVg2nWU9nTfb9YmiGtXULqzxRE5lB5wVJJjDf5plw/2iS4N8b6+aMCicPMJmualIvW3Yflam528FXzXAPTNpsAXBZuo9OqAKVedy1WOfFecZtpXCtO8IBXOXxKNbsUbqmsTJ+gmI5b/Fu2tHSr8eCoWiYflKGtWw836mICep7Wgch8ODB2FMGN/Bez89+G6NgZFbGo9QYtQ+osUvJZIhHRjxJ9x13LFWZdHpr/Yee6yUrdrKsfB9AwFWYhiTJ9FaAkQiB4m7hm5+cgwc17MjlEh6Vkcbx3hrjdAv5LYFgXSnGi2cIwM5fsoXr49lZHz4ucajTj5v88hx88rKZnGpiNSA2eMckIeMpWm0xFG6lYt7Hr6G/hDM15h/gPDaScul88EXDwDW0glNTjMAQ4G/jBHkBFB5P1mXJ3/If0C53S6BJXU9YJpZ33hon6aVZC9ZhXWo2cSrP3T7i6QYmEJ4Q1f+ANQs1crys9HT4/d9yVi3vYwv7wJpRA+pDExBer/Ra5N6gbPQuiwDolHmMzspi3yqD7XAd+/qzj55cHDmWmUPBClrji2CSJF786qKDxKaTEiFOQJlJKFbfZfVh5jjkwiB51ZGcs8ky62jWFifsYLCAechPqSvxIJNadl9INFaQePR5yhgrp/pIXqiyUDun63BgMxWKXm6 kMWL1jGx eAegobruSRNRZs674nuVdfN4df9zWTvrHOSRxwjysZkm4d6PxBwKDX948/rGcPwtSP+x6PEgia0khmYnjunkPsIWCaCY1nkLGoxsq0iibSoq48URjSvD/S2jyAGU/dYk2eSoA3UHDNUh2moz5LryE/WoizoMEQSkRy2691u1db+BfCLs7EIcEDDmzEWg+awhLv3noBZZ7OtijG24vID4he84Tdnt/5LKWY9F4dOSRYXN3jpS8a2l2jqt3CK0gYMtBl/QFom7608SPYyfuzqBs76aYh3fn6e6w0WTkeDcBY87fZMKyUMLTUfTroX7CZn14sxhvo51AjzkxpT5Q0BOj94+f6b143+ig63UAapfoxfPYCgRoHGrhwmWyQuQVlyu+RlJTVKc6UYZ9l6a5FrBBfyK1pp3NE/RxZ1OIA/1S5u18tTbaWWuZ6dyUbpTf/Pdbsnv2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000299, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Before storing a page, zswap first checks if the number of stored pages exceeds the limit specified by memory.zswap.max, for each cgroup in the hierarchy. If this limit is reached or exceeded, then zswap shrinking is triggered and short-circuits the store attempt. However, since the zswap's LRU is not memcg-aware, this can create the following pathological behavior: the cgroup whose zswap limit is 0 will evict pages from other cgroups continually, without lowering its own zswap usage. This means the shrinking will continue until the need for swap ceases or the pool becomes empty. As a result of this, we observe a disproportionate amount of zswap writeback and a perpetually small zswap pool in our experiments, even though the pool limit is never hit. More generally, a cgroup might unnecessarily evict pages from other cgroups before we drive the memcg back below its limit. This patch fixes the issue by rejecting zswap store attempt without shrinking the pool when obj_cgroup_may_zswap() returns false. Fixes: f4840ccfca25 ("zswap: memcg accounting") Reviewed-by: Yosry Ahmed Signed-off-by: Nhat Pham --- mm/zswap.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/zswap.c b/mm/zswap.c index 59da2a415fbb..cff93643a6ab 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1174,9 +1174,14 @@ static int zswap_frontswap_store(unsigned type, pgoff_t offset, goto reject; } + /* + * XXX: zswap reclaim does not work with cgroups yet. Without a + * cgroup-aware entry LRU, we will push out entries system-wide based on + * local cgroup limits. + */ objcg = get_obj_cgroup_from_page(page); if (objcg && !obj_cgroup_may_zswap(objcg)) - goto shrink; + goto reject; /* reclaim space if needed */ if (zswap_is_full()) { -- 2.34.1