From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E8B6C77B7A for ; Wed, 31 May 2023 11:04:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD70C8E0005; Wed, 31 May 2023 07:04:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B87028E0001; Wed, 31 May 2023 07:04:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A785D8E0005; Wed, 31 May 2023 07:04:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 95D6E8E0001 for ; Wed, 31 May 2023 07:04:35 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 70CA3ADF86 for ; Wed, 31 May 2023 11:04:35 +0000 (UTC) X-FDA: 80850266910.05.74898E7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 9FF2A140014 for ; Wed, 31 May 2023 11:04:33 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PaneWmNa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685531073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Bz65D2xx0gb4qdpRkIQI3YTwLtyS701r/8WE2ftqUAI=; b=8T5BpEeLygPBdPBs6YdQ//XDGTctCuVnZ1iGBwpaBuY0D+5yOc2gIPTbdhW0N4igkl59u6 nBZdft0a1AqV7s2Lji8hQ0TxKUqNLYu8c1IGDLGC4GiLXyl/My+v25YpMVibGvrQw+Gz+B HsHDgXemk+C9QO+dGZTxC/IfAHonQ6U= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PaneWmNa; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of dhowells@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dhowells@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685531073; a=rsa-sha256; cv=none; b=AUHRz7DI32z+2x4JV9WguMy+NwlvBz6Kvg/y5f8Avvzzi6Rf0eyrJBo6w2/jWiDfiCcElL vTFPTAWPgA1qjuCtNIRdHRNrDfuKn67va1cPibwXmtGpuFCDqT5Qxa14XgmJUZY+SHOkiF 7slciO9/qOAWCW4ZHsiVWlYiWc82t5E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685531072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Bz65D2xx0gb4qdpRkIQI3YTwLtyS701r/8WE2ftqUAI=; b=PaneWmNamdT3Pqo9G6nuY6ysQTT8pZhnOCoIC/DIJlVOow/WqY9a/g2c3qhi6IZ5sPi0/E IQQdzsPIM8CRvtXHF82O7HHVQj3YxH2aLHzHGerlGfcFZig7I86L6AB8EWm2QpJ5TB/r4o yMgQVPmJ3VjQ/+aMLlDfj8m3sF95y54= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-572-YLiSyU6kP3mOCadzX03i4g-1; Wed, 31 May 2023 07:04:29 -0400 X-MC-Unique: YLiSyU6kP3mOCadzX03i4g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 640EB1019C87; Wed, 31 May 2023 11:04:28 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0A90CC154D7; Wed, 31 May 2023 11:04:25 +0000 (UTC) From: David Howells To: netdev@vger.kernel.org Cc: David Howells , Tom Herbert , Tom Herbert , Cong Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 0/2] splice, net: Handle MSG_SPLICE_PAGES in AF_KCM Date: Wed, 31 May 2023 12:04:20 +0100 Message-ID: <20230531110423.643196-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Rspamd-Queue-Id: 9FF2A140014 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hykt43y8j1dc5x1d74n4i78mw6g4u9ym X-HE-Tag: 1685531073-103277 X-HE-Meta: U2FsdGVkX1/WZ91GsKUhlm4cLh6vrYE9kIVoun1Qw35u72lTExvx0QHwbHM40PDnOO2X0jpumfryZgyQ/qL/m7mTPzqNzEB/6Pd2IqprbuLwoIDX3jj/6jKFBH7L0oZJATQ4v2qPsCgfRnjdjdPhMo6X3WB351uUtca/Qr2+KFcXWKdJnAd6tEv7PLLsveV0CzrfMjwGg70h6TdnCj7ckF1AdcEEa5XD3Kse+GGYSq68fEujEHgbKn73xFZJwnYUJadqgtTFbQrpEfPO/AwalE4D6u3pFalPkFwo57Kp3kdaEngHWYyUVxmjFEAEZaYmDeUaPLY1sRXGmPDGkTOH9I5e3IGhQ4ap39M1pa8+chwyHrAXgr9khcR6BrsDlt13LxDTabLirE78RACreg0UTKIvCYcTXI3o9CcNnaHzgxnV2u1sqmssTK5380IiET8j+Ocy7tAo3Pv7CXYd4sFCQuYN7IE2x8X9b+nLgn5lOca8oR3Msh3m+3gwk8R3e8ZZGylqzCr1qOmAwkeoSDzYyJZApHUn3g4I8AG/FftZnYtd9J4G4hjc4MVDUVEii8oqwWYAgSJGtIiIA4Qalo3heVDT1nT5QfPMlXl7Dvz89iP/iXw6ZC2AOTPHEvcrhClbjclPfGEgZxEFuiSekpfKh7w/1JvNp3LPRfQTLaCi309be22nlUMzbBiO7JJPt3ewfD0nIPZddy7njMaOoqfQ7T43/xW2pltJOqeST53Tfw+cSV+vHnEsluguaik2zbpNpKmwfnOa4ruRTUtYjbVaAQF8SLg9HBjur6W09zNwxj7q2jYDUCyw2SL7zVtFbZvn4FSiwrIOwOPh8LQVtc+4pTytSKlO89dfFpex6T9Wcp4yhml4dXxjG8ccYxALzJDrwwkRXfHVVh0A5IDM5ThFCq1QLS8md3RXJiN2WXFtZtp7Is6zDotdxZ5+78ecPH/0/auw97+xbW1HChqcuSm ZxtCq/iS CHIyEgd6Q/qfS5GYg3AlKbOk5AY8T17H/bk+j/ntcLd3uva04WwxThM8fMraU7yYutmEYnNVOZvF34N4fqoyzyZzScZ3+g+iLaB+JVA0fGzMtlg+XIK+EWOiTDeDCg0q6rqHsVPWJVK0P7wRzo/gtog8qaZF0HMz7hrIdgsp/VuWXH0kUhOc/SEGL+CINkHJV4pOjMM3WkJPr4GciYLXXKn5/VCfeucCTf9+hMYb1hoNHPEOMRZLf/MJQtdLcRifPIrkxudhzYjNsDEn9B+o1RTDY7nwL2SDD8tpyPy2RFkII0kossXSSb5KL433MhtMGY8Gij9XdaYWbOZa5y8MR1/XGkslhG3viEoey X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Here are patches to make AF_KCM handle the MSG_SPLICE_PAGES internal sendmsg flag. MSG_SPLICE_PAGES is an internal hint that tells the protocol that it should splice the pages supplied if it can. Its sendpage implementation is then turned into a wrapper around that. Does anyone actually use AF_KCM? Upstream it has some issues. It doesn't seem able to handle a "message" longer than 113920 bytes without jamming and doesn't handle the client termination once it is jammed. I've pushed the patches here also: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=sendpage-2-kcm David ver #2) - In kcm_sendpage(), only account the amount actually copied. - Wrap at 80 chars. Link: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=51c78a4d532efe9543a4df019ff405f05c6157f6 # part 1 Link: https://lore.kernel.org/r/20230524144923.3623536-1-dhowells@redhat.com/ # v1 David Howells (2): kcm: Support MSG_SPLICE_PAGES kcm: Convert kcm_sendpage() to use MSG_SPLICE_PAGES net/kcm/kcmsock.c | 218 ++++++++++++---------------------------------- 1 file changed, 58 insertions(+), 160 deletions(-)