From: Qi Zheng <qi.zheng@linux.dev>
To: akpm@linux-foundation.org
Cc: david@fromorbit.com, tkhai@ya.ru, roman.gushchin@linux.dev,
vbabka@suse.cz, muchun.song@linux.dev, yujie.liu@intel.com,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Qi Zheng <zhengqi.arch@bytedance.com>
Subject: [PATCH 0/7] revert shrinker_srcu related changes
Date: Fri, 9 Jun 2023 08:15:11 +0000 [thread overview]
Message-ID: <20230609081518.3039120-1-qi.zheng@linux.dev> (raw)
From: Qi Zheng <zhengqi.arch@bytedance.com>
Hi all,
Kernel test robot reports -88.8% regression in stress-ng.ramfs.ops_per_sec
test case [1], which is caused by commit f95bdb700bc6 ("mm: vmscan: make
global slab shrink lockless"). The root cause is that SRCU has to be careful
to not frequently check for SRCU read-side critical section exits. Therefore,
even if no one is currently in the SRCU read-side critical section,
synchronize_srcu() cannot return quickly. That's why unregister_shrinker()
has become slower.
After discussion, we will try to use the refcount+RCU method [2] proposed
by Dave Chinner to continue to re-implement the lockless slab shrink. So
revert the shrinker_srcu related changes first.
[1]. https://lore.kernel.org/lkml/202305230837.db2c233f-yujie.liu@intel.com/
[2]. https://lore.kernel.org/lkml/ZIJhou1d55d4H1s0@dread.disaster.area/
And hi Andrew, the commit c3b5cb881de6 ("mm: vmscan: move
shrinker_debugfs_remove() before synchronize_srcu()") is still in the
mm-unstable branch, you can drop it directly.
This series is based on v6.4-rc5.
Thanks,
Qi
Qi Zheng (7):
Revert "mm: shrinkers: convert shrinker_rwsem to mutex"
Revert "mm: vmscan: remove shrinker_rwsem from
synchronize_shrinkers()"
Revert "mm: vmscan: hold write lock to reparent shrinker nr_deferred"
Revert "mm: shrinkers: make count and scan in shrinker debugfs
lockless"
Revert "mm: vmscan: add shrinker_srcu_generation"
Revert "mm: vmscan: make memcg slab shrink lockless"
Revert "mm: vmscan: make global slab shrink lockless"
drivers/md/dm-cache-metadata.c | 2 +-
drivers/md/dm-thin-metadata.c | 2 +-
fs/super.c | 2 +-
mm/shrinker_debug.c | 39 ++++++----
mm/vmscan.c | 125 +++++++++++++++------------------
5 files changed, 82 insertions(+), 88 deletions(-)
--
2.30.2
next reply other threads:[~2023-06-09 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 8:15 Qi Zheng [this message]
2023-06-09 8:15 ` [PATCH 1/7] Revert "mm: shrinkers: convert shrinker_rwsem to mutex" Qi Zheng
2023-06-09 8:15 ` [PATCH 2/7] Revert "mm: vmscan: remove shrinker_rwsem from synchronize_shrinkers()" Qi Zheng
2023-06-09 8:15 ` [PATCH 3/7] Revert "mm: vmscan: hold write lock to reparent shrinker nr_deferred" Qi Zheng
2023-06-09 8:15 ` [PATCH 4/7] Revert "mm: shrinkers: make count and scan in shrinker debugfs lockless" Qi Zheng
2023-06-09 8:15 ` [PATCH 5/7] Revert "mm: vmscan: add shrinker_srcu_generation" Qi Zheng
2023-06-09 8:15 ` [PATCH 6/7] Revert "mm: vmscan: make memcg slab shrink lockless" Qi Zheng
2023-06-09 8:15 ` [PATCH 7/7] Revert "mm: vmscan: make global " Qi Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609081518.3039120-1-qi.zheng@linux.dev \
--to=qi.zheng@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=tkhai@ya.ru \
--cc=vbabka@suse.cz \
--cc=yujie.liu@intel.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).