From: Kees Cook <keescook@chromium.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Eric Biederman <ebiederm@xmission.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] elf: correct note name comment
Date: Thu, 22 Jun 2023 13:07:04 -0700 [thread overview]
Message-ID: <202306221305.5F23BC4@keescook> (raw)
In-Reply-To: <a7e56e9c0f821348a4c833ac07e7518f457cbdb8.1687413763.git.baruch@tkos.co.il>
On Thu, Jun 22, 2023 at 09:02:43AM +0300, Baruch Siach wrote:
> Only the NT_PRFPREG note is named "LINUX". Correct the comment
> accordingly.
>
> Fixes: 00e19ceec80b ("ELF: Add ELF program property parsing support")
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>
> Resending in hope kvack.org mail server would be willing to accept my
> submission this time.
>
> Adding LKML as a safety net.
> ---
> include/uapi/linux/elf.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git include/uapi/linux/elf.h include/uapi/linux/elf.h
> index ac3da855fb19..a8a0cced62c6 100644
> --- include/uapi/linux/elf.h
> +++ include/uapi/linux/elf.h
> @@ -372,7 +372,7 @@ typedef struct elf64_shdr {
> * Notes used in ET_CORE. Architectures export some of the arch register sets
> * using the corresponding note types via the PTRACE_GETREGSET and
> * PTRACE_SETREGSET requests.
> - * The note name for all these is "LINUX".
> + * The note name for most types is "CORE". NT_PRFPREG note is named "LINUX".
> */
> #define NT_PRSTATUS 1
> #define NT_PRFPREG 2
Is this accurate? I see this logic in fs/binfmt_elf.c:
bool is_fpreg = note_type == NT_PRFPREG;
...
fill_note(&t->notes[note_iter], is_fpreg ? "CORE" : "LINUX",
note_type, ret, data);
i.e. only FPREG is named "CORE", otherwise "LINUX".
Shouldn't this patch have CORE and LINUX swapped?
--
Kees Cook
prev parent reply other threads:[~2023-06-22 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 6:02 [PATCH RESEND] elf: correct note name comment Baruch Siach
2023-06-22 20:07 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202306221305.5F23BC4@keescook \
--to=keescook@chromium.org \
--cc=baruch@tkos.co.il \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).