From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E198EB64DA for ; Wed, 19 Jul 2023 06:32:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5296280030; Wed, 19 Jul 2023 02:32:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDB888D0012; Wed, 19 Jul 2023 02:32:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7C38280030; Wed, 19 Jul 2023 02:32:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 955A48D0012 for ; Wed, 19 Jul 2023 02:32:17 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 63E6712019A for ; Wed, 19 Jul 2023 06:32:17 +0000 (UTC) X-FDA: 81027391914.23.971D876 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by imf29.hostedemail.com (Postfix) with ESMTP id EDAB8120018 for ; Wed, 19 Jul 2023 06:32:14 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=OdMNMSpE; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.44 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689748335; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=c9KrLLP8cL1uPsjJ1nSTy5SK2yTBHa/947mlcAdb160=; b=jychv+12Gp1AmErLxpcGHp+n1lvC0ty0/K2l8pH1XbHLW9YG3yh8YyBvaRA8AX69FrcBA4 rsH7/gvlscyBUXg/gwIRK3BXUuObPekvY4eTZ2muYV4cVPfyBU2zwK2uGfqx5Jk47bIcVR xlhumIrW2HTuXASJhOfv60wS483h9z8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=OdMNMSpE; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.44 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689748335; a=rsa-sha256; cv=none; b=TY9HnMzkufqiSJBXEVNwi/0REzXSLG5M18dUIG3oGzLCRb2uftX2CxzZr3iw/FCxxtJFrr tk+CDe3ZHAarHy997dFdeJpoBKIyowSSrJpnr3iS7Di6zmBFI1p2yq44w0QxtZLIZ8b/39 hmbpugw+xMM9gXhRX1lCW7+3xQ+4+c0= Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-6b9b427b4fcso4619687a34.3 for ; Tue, 18 Jul 2023 23:32:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1689748334; x=1692340334; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=c9KrLLP8cL1uPsjJ1nSTy5SK2yTBHa/947mlcAdb160=; b=OdMNMSpEfv/yH1YzdMwSElZuj3ZFDDe2Uvr+0uT/C9mKCgI3PnkaDphepFbwXZGaEh 4veUsr3yq4av+3Kyq+YmVd8InvdEWYYmEbxxSbxVZpDlbA8mF7IUCkYe0beFK37O129D HwZepvEjoG0zFUPtNuvTTJNeKyeFZNy5V0aLxZXX4omIC3Pi/jf6NyTqsEStkdHwzKpp KLIRLmMK5x4fsT0nFh8BTFe6u7ptjPcC8XeOO6h7Zj9FF0SK+Hg5C4Ln1YpMWgWaPOIQ DcqIgGRwYzCSxddeZapFOS1ZpehwxS41A/L2zcFcH55bH7WPxxoB8TARBVQ51D1vrgax vtSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689748334; x=1692340334; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=c9KrLLP8cL1uPsjJ1nSTy5SK2yTBHa/947mlcAdb160=; b=QKwdeOZiVgpPVgIb1KWwOV1u/Grb413H/LImvehh6tPuDFY/3oqZcLpffz0Sxowdtb WXXbNGsyz+yIAQ4oEKJ4mv8qxpAtVGZElQgGDVBFYelYSEiKMrrRNspzE2IH+Y8aZ9nl jt8kj5IXndr2oG4NeMFFM8RDPbGk16rhXKLcf688GibagYw2SuaV//qzDPpg+hgVAotF tj0by8seGI1Qx38zDOZL+aOwbk4lFpiS0Puk0DC2+fDVlhFuFLNas2ev6Ea8s4SF6/kB pxpLcXoj++i5wzPihFCCKw5RbXbi+7gah25Wj+8eB8t3ONxI0GbAvR163fBOVyPQqcWE RGeA== X-Gm-Message-State: ABy/qLZ1sI3sTHB+eABFTmI17S8iQLC6dwPgDcIixu2sv+4mKomiUBV5 zwNJG/Wb03j/VCHMiDWVqUgEgA== X-Google-Smtp-Source: APBJJlG7Hnr+DLSYxVj/kGW324BYuM9R7IW3z2osuMAejNGZ153KuMIBDUA2MT+Nc81tM5Yh8hK+Hg== X-Received: by 2002:a05:6830:1110:b0:6b8:90cd:47b5 with SMTP id w16-20020a056830111000b006b890cd47b5mr5139616otq.7.1689748333811; Tue, 18 Jul 2023 23:32:13 -0700 (PDT) Received: from PXLDJ45XCM.bytedance.net ([139.177.225.226]) by smtp.gmail.com with ESMTPSA id p12-20020a631e4c000000b005348af1b84csm2701678pgm.74.2023.07.18.23.32.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 18 Jul 2023 23:32:12 -0700 (PDT) From: Muchun Song To: mike.kravetz@oracle.com, muchun.song@linux.dev, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: [PATCH] mm: hugetlb_vmemmap: use PageCompound() instead of PageReserved() Date: Wed, 19 Jul 2023 14:31:31 +0800 Message-Id: <20230719063132.37676-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: EDAB8120018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: j57tz6zeru8h9exhxmwuw58hjsao4k6m X-HE-Tag: 1689748334-151928 X-HE-Meta: U2FsdGVkX18OPDxMyZ3IetjXzCCFQhxhOOXkXU3XOwwOgqvI/qLZCekNd+ataNtSRKeNJCFNGjwdIthxW+dnW6u3nhsPpdywWecdkeaFaaVcjyxT0PpAE5iWEwBIpGaqBIa6WQW9B7kpYLk1fg3bJ+94Ay6yAf6RpNrpmOsQIP9tp8rJr/7g8FOWUg07mwNTXCdp2msUpTM/T27m9o4qhUme/AW/8UV931qoRzCaXBkDW5o/BQq0S8ydb1G7y10Ri/0qh+biiL/p+SAehRZPEjx/wNiZHhEgHiHE7RcbjaK6+IgigTkx17qxcjdOywsuHhs4n6UYmIsagOZZ5hZIjGFpkj8/FSAiid6z7EIqhqO3kFyhs1+V23vCSBQlmZBmep0XPLITL2gkt2VCIw3bUbGLAtaBDpGq2J9/jhg3rUwWAo1bGB/Me/ple2cM+zz+0MloKXkX0zntFv8m6RrjzL8q1Almj0fSAo8qY+tl9NTzAtbD8SigOs5lc3kOcdZC+ClFKfAsDgShmaqgzJR/Hv0Dw5fXB9pHhVYQtSWnrclb1QhNmfXHegrNS2b1W7riyH8kPGPDDFjG87QoK7RfpWdTj/N4pQQWivkJKDyMSGsQthyUDdGhrOl+EYDCuVXGQGIVn1yAiVZOn1v2WOatWHWg7dhe9REowBXLPnNLYEjPhYKVszmgD6DrhtJiU7oNGT1scDw3uFznZ98merpf3Bzwu820Wnh6ctctA0Wt+xVn5ccst/7NxTlfK5WoqJg4uNyxZ3YhCmrBTLUWwl0g8rXIo8cMg+LEBur2RzTN6K7HPpgwm4vshEgQbYvIeOVd4Pdhs1MW3Kz+CKr50lyhTxe9S7TxnIWwkYNfA7/dE40wQwOHFgyohsRHeU54SrsEoFV3nRaPRvyh1iJkjdvsgSfymaRtoobC7slu2MzhZw2rhjDGpMmuh8gWQCRphd48zLYCna58CJi/JxduA6O A9NauUGV mthAKaUo/UodE/NkH9JlLQQFW/y+MzH0/1qk7G/SZXI256WwArWkYgq3E0Jx5Spl445S0/Zn6y5DRThhGJ3QiMzNWQwSjeHsWnPOQNFJwp6Y9eI7KyEvalChy4hWaQ9EuhjQqm4MpV+rqbDxr93JX2nv9cref0uFw+8MVL9QhsJNOpXTS706wOuxATLfv618JmSz+DquDz5+H/Yv4z2HNeXEQkiLLPgcSGwLC12mnwMp3zszGaOUw0dVDtytP1/Sn4JGNx8PGtNPknFvgo2q1sBwwuSISzSMTKGkSZY9d0/yVn2kkPYsfg0ZtUVMDTc7xZ+sGP5By10x8Gj2zdWY4SxlQXfoMfUESiweG7mCj6zkiHQOsg02dA6TYF+frnuP/G+9w7Ap/yX01vX2H5y/52JlMAnmYV4mzjAr2hyiN4AjPvtqm/tE41mebb8zXD7bgBNITCrEwXBdUn50= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The ckeck of PageReserved() is easy to be broken in the future, PageCompound() is more stable to check if the page should be split. Signed-off-by: Muchun Song --- mm/hugetlb_vmemmap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index 4b9734777f69..8068fe890f52 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -73,8 +73,10 @@ static int split_vmemmap_huge_pmd(pmd_t *pmd, unsigned long start) * be treated as indepdenent small pages (as they can be freed * individually). */ - if (!PageReserved(head)) + if (PageCompound(head)) { + VM_BUG_ON(compound_order(head) != get_order(PMD_SIZE)); split_page(head, get_order(PMD_SIZE)); + } /* Make pte visible before pmd. See comment in pmd_install(). */ smp_wmb(); -- 2.11.0