From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F5B5C83F12 for ; Mon, 28 Aug 2023 15:09:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7F5848E000E; Mon, 28 Aug 2023 11:09:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7A5A78E001A; Mon, 28 Aug 2023 11:09:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 670DA8E000E; Mon, 28 Aug 2023 11:09:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 598628E000E for ; Mon, 28 Aug 2023 11:09:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3BF7D140422 for ; Mon, 28 Aug 2023 15:09:08 +0000 (UTC) X-FDA: 81173846376.20.4670F37 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf29.hostedemail.com (Postfix) with ESMTP id 6A2EC120023 for ; Mon, 28 Aug 2023 15:09:06 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Ps6Ug/Mb"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf29.hostedemail.com: domain of revest@chromium.org designates 209.85.221.42 as permitted sender) smtp.mailfrom=revest@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693235346; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=nk67n76bWffKzPFNDlhyIKPeZKFaIzOGb7e8DY77Kug=; b=haRh955/lsxFDx4euIp91aTqAkgsOTlJMp/pmxaeyV6dzNkO9ZimNH8+/6MvYn0pSq+DC3 dg0y3VyTP8A7v3uXmbJ9f7CMRg0e1vr3L7QZNFJi+A7vcraNhjDk6K7cHOg1lhaJRJQen2 eHJVTZPFJDr1xLAa1OWDobIoyLHT1hc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="Ps6Ug/Mb"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf29.hostedemail.com: domain of revest@chromium.org designates 209.85.221.42 as permitted sender) smtp.mailfrom=revest@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693235346; a=rsa-sha256; cv=none; b=Arxx2tIH4edT+e0T4a2E1yB/TD9QkZifc9j+YCQr/7Nb8+E80RUqZTEv9zPddV7kIRTwGV iHt0HnEa1q1r1n+gyffHzTXq/eCC8THFK77XkObrJbeY0GceCPZzElF7Xxv7jQ+ixr41LO l/rMO07DPnzMiUOGaK68IzwHFXJkJUQ= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-31ad779e6b3so2722222f8f.2 for ; Mon, 28 Aug 2023 08:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1693235345; x=1693840145; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nk67n76bWffKzPFNDlhyIKPeZKFaIzOGb7e8DY77Kug=; b=Ps6Ug/MbVZfF1WnG0Xo86FyNGanHGgMs/NWfuk9ZoD9qAa9fCW1q6dFA0DtPKR4v5s 7aq0RD68DSDxj0UlihZLRvQtJRxW78pPE70183dhmI+j/2y3opUH4XJy3ti7YY50HZTP 3ozkH0IWk2RTQk88PcNOqGP6K2M1ZvsLH02pc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693235345; x=1693840145; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nk67n76bWffKzPFNDlhyIKPeZKFaIzOGb7e8DY77Kug=; b=dysi9ZouNkkC4B/UwA8B5dBoPlrvCv0GZAbNJ1nhprevQCM6He+fkL6r/wELzvN1jC NgpwpPuMvrEWKIs+i6WaushI8KVy1rdEgih1qpN0RHhUDCIZME9wlgUHuOKH2YT6t6Vw D8dfBNPMOets25SMRdTuPq69gmp0Hs3tdNie5OZ5W+wIU0b/nILdOdsmbGzyHMv5Eq5V M0aL43TOysozktVzFGiStAt5wr2OpV5d4RCaFhZWDL3pm8LHZ6J42pEBLCepTputJa+z OrIxITdZSypiB/LsnZ6kOcoi8P3RPwF3BZHrixF25PZWULw6/JvFmtUA6qYAH5x7wQVn wpew== X-Gm-Message-State: AOJu0Yw5Wid61wHUYH0wmOfeo45nySuELte13bBVDQhrBH1DXR6Lbpl1 /HOp4KSCT6Ndoum3prPcG3P48w== X-Google-Smtp-Source: AGHT+IGoXzzFSUGxduA2rZXXMmGWetii0IG5xXH3CT+sQ+sMZVQLPjQjqM011ItlU52gfoVjsC3YxQ== X-Received: by 2002:a5d:5308:0:b0:316:f24b:597a with SMTP id e8-20020a5d5308000000b00316f24b597amr18000575wrv.46.1693235344820; Mon, 28 Aug 2023 08:09:04 -0700 (PDT) Received: from revest.zrh.corp.google.com ([2a00:79e0:9d:6:40c6:6cff:63b:c70a]) by smtp.gmail.com with ESMTPSA id v3-20020a5d43c3000000b003140fff4f75sm10730522wrr.17.2023.08.28.08.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Aug 2023 08:09:03 -0700 (PDT) From: Florent Revest To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com, ayush.jain3@amd.com, Florent Revest Subject: [PATCH v4 0/6] MDWE without inheritance Date: Mon, 28 Aug 2023 17:08:52 +0200 Message-ID: <20230828150858.393570-1-revest@chromium.org> X-Mailer: git-send-email 2.42.0.rc2.253.gd59a3bf2b4-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 6A2EC120023 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: oumfsxy7kgjabe4k1ep4x13wsnuyo6kq X-HE-Tag: 1693235346-958375 X-HE-Meta: U2FsdGVkX19yJgui+Lk6lkpBE3BROC4vbks4BhRvPKk8SZjGHh0Iry4kRHuEPoLVkuRarSAtkzIlbSUxHQ1MrF1sdpLIWSrI/mPoc0+whz1sHeBhZzWzpJez22z/fzyi5e1xI7EYWcSaeqQPCJrCI+n8bwtbMJV1+2Kta6EFjhsm+xJclDZ9UOD6NV2ewRgcw6M1rmgpzTl97sGTAKyh3JfIXsgvcJqdMjdhqJ5SZCw++PtiLCq60dUqlDaLz7vo5ozNUIioU9gaumayH0GTFmjim1GNDjnu/s+Q+uPK2vddY/RYaZljC8uYoHcthNymvkSvvIKAOrn13ZzD8xfBxe2PDoF08oopDw7C42rvENC0jK7AH7HIDqB9Csu61bje+yOy/+wWU5a9O4hksfuWJGzHxJz7Xf15/3S1x0OCLQcPfErSDnhti+o0YFcGX5uIROrSpvQvl98GjWcnJ93jVNHfaXm/K/mrvkVko5q3olxYrnTMK9vLOPhEiRbVkGJL7q196aehIYBKz+Nz0YQLnp0cfLHa3Z2Bnku/bg1EWL58vCEX9zjLP8b7K/V6eLShMqdpPbJ46Oc+Yto8KWSlzo610StovGTFBKnrwcG8VQG4oZ7EkDjPcarjQQJioAzbzZthjBaoPoZYWFKYCCoJkByHBzolx0SiWz4DTB9fyF5lVM3IVasERPZqb/xzSt/LUd6vJw6Q7fnOSoePpVXdnRco4CLoN4MKkWLbVaGo3Aw4lKa+uftbXYqrwfauQOZo3fNodUl3PWRaS68io/f6+oIi+aIqxfG9MxavujYsYgmK1KAwBPIcC87xrgWnKlZPF1bDnH6jirhi5EVVWeeqmsTcPGah/N4kzE2f9KeQNMnkHHdBxn4XMDM1VDI0glyUCMYKJoFrODDOHzBmQgtaKzwGapQ5DkYJ1R6W3nhHra4K4XYPE4076K2YIVZkgdRPzbd6IjL2T8O8JFk/yZF BUON4e6D E40aWc6FhAJFRisgrutwPqeLXTa1BqhldOxU6flVqmzx4gYgLI7PYXtVsGnkVQi9h7Ms8MRPjzC1QyD4LxBQJGs0XW/M7DRhB8rzelgxNZt6nrcOCgVqgn44o+YXDD6cyNwE85p1Fjsj4jFTpCw1XOm5gGBkwEaugE8LI5hCR1K6YjZ4jQSbCAvvJhX2Y5A81BgWok1dm4q3wWYYLXyzt+LV5SLvqptGGPtXLVuBcupsb0hBw/Jf44lU8G52+qxjvYZrgFwBlxlOxZcsZpuLGecvymas6VGypzBREfFKZv9bF3ti/HkHnpgwmSMQCH27cU6c+GQyKS8i/xEijQLJKOmeHSjMr9G7k6B3PHNBMV8zsUWQgdxKVNn4DAMAn8xF9qBN2jK2Wa2ZRGI9fdEccbmD9Z843FFmoG5aS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Joey recently introduced a Memory-Deny-Write-Executable (MDWE) prctl which tags current with a flag that prevents pages that were previously not executable from becoming executable. This tag always gets inherited by children tasks. (it's in MMF_INIT_MASK) At Google, we've been using a somewhat similar downstream patch for a few years now. To make the adoption of this feature easier, we've had it support a mode in which the W^X flag does not propagate to children. For example, this is handy if a C process which wants W^X protection suspects it could start children processes that would use a JIT. I'd like to align our features with the upstream prctl. This series proposes a new NO_INHERIT flag to the MDWE prctl to make this kind of adoption easier. It sets a different flag in current that is not in MMF_INIT_MASK and which does not propagate. As part of looking into MDWE, I also fixed a couple of things in the MDWE test. This series applies on the mm-everything-2023-08-25-20-06 tag of the mm tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/ Diff since v3: - Added a bunch of Reviewed-by, Acked-by and Tested-by. Thanks everyone! - Reworded patch 2's description for clarity - Removed an unnecessary int cast - Added test coverage for errnos of invalid prctls (EPERM/EINVAL) - Added test coverage for can_keep_no_flags and can_keep_both_flags Diff since v2: - Turned the MMF_INIT_FLAGS macro into a mmf_init_flags function as suggested by David Hildenbrand - Removed the ability to transition from to PR_MDWE_REFUSE_EXEC_GAIN from (PR_MDWE_REFUSE_EXEC_GAIN | PR_MDWE_NO_INHERIT) which also significantly simplifies the prctl_set_mdwe logic - Cc-ed -stable on patch 3 as suggested by Alexey Izbyshev - Added a handful of Reviewed-by/Acked-by trailers Diff since v1: - MMF_HAS_MDWE_NO_INHERIT clears MMF_HAS_MDWE in the fork path as part of a MMF_INIT_FLAGS macro (suggested by Catalin) - PR_MDWE_* are defined as unsigned long rather than int (suggested by Andrey) Florent Revest (6): kselftest: vm: Fix tabs/spaces inconsistency in the mdwe test kselftest: vm: Fix mdwe's mmap_FIXED test case kselftest: vm: Check errnos in mdwe_test mm: Make PR_MDWE_REFUSE_EXEC_GAIN an unsigned long mm: Add a NO_INHERIT flag to the PR_SET_MDWE prctl kselftest: vm: Add tests for no-inherit memory-deny-write-execute include/linux/sched/coredump.h | 10 ++ include/uapi/linux/prctl.h | 3 +- kernel/fork.c | 2 +- kernel/sys.c | 32 ++++-- tools/include/uapi/linux/prctl.h | 3 +- tools/testing/selftests/mm/mdwe_test.c | 137 ++++++++++++++++++++++--- 6 files changed, 163 insertions(+), 24 deletions(-) -- 2.42.0.rc2.253.gd59a3bf2b4-goog