From: Yosry Ahmed <yosryahmed@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Shakeel Butt" <shakeelb@google.com>,
"Muchun Song" <muchun.song@linux.dev>,
"Ivan Babrou" <ivan@cloudflare.com>, "Tejun Heo" <tj@kernel.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Waiman Long" <longman@redhat.com>,
kernel-team@cloudflare.com, "Wei Xu" <weixugc@google.com>,
"Greg Thelen" <gthelen@google.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Yosry Ahmed" <yosryahmed@google.com>
Subject: [PATCH v2 0/5] mm: memcg: subtree stats flushing and thresholds
Date: Tue, 10 Oct 2023 03:21:11 +0000 [thread overview]
Message-ID: <20231010032117.1577496-1-yosryahmed@google.com> (raw)
This series attempts to address shortages in today's approach for memcg
stats flushing, namely occasionally stale or expensive stat reads. The
series does so by changing the threshold that we use to decide whether
to trigger a flush to be per memcg instead of global (patch 3), and then
changing flushing to be per memcg (i.e. subtree flushes) instead of
global (patch 5).
Patch 3 & 5 are the core of the series, and they include more details
and testing results. The rest are either cleanups or prep work.
This series replaces the "memcg: more sophisticated stats flushing"
series [1], which also replaces another series, in a long list of
attempts to improve memcg stats flushing. It is not a new version of
the same patchset as it is a completely different approach. This is
based on collected feedback from discussions on lkml in all previous
attempts. Hopefully, this is the final attempt.
[1]https://lore.kernel.org/lkml/20230913073846.1528938-1-yosryahmed@google.com/
v1 -> v2:
- Fixed compilation error reported by the kernel robot in patch 4, also
added a missing rcu_read_unlock().
- More testing results in the commit message of patch 3.
Yosry Ahmed (5):
mm: memcg: change flush_next_time to flush_last_time
mm: memcg: move vmstats structs definition above flushing code
mm: memcg: make stats flushing threshold per-memcg
mm: workingset: move the stats flush into workingset_test_recent()
mm: memcg: restore subtree stats flushing
include/linux/memcontrol.h | 8 +-
mm/memcontrol.c | 269 +++++++++++++++++++++----------------
mm/vmscan.c | 2 +-
mm/workingset.c | 42 ++++--
4 files changed, 185 insertions(+), 136 deletions(-)
--
2.42.0.609.gbb76f46606-goog
next reply other threads:[~2023-10-10 3:21 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 3:21 Yosry Ahmed [this message]
2023-10-10 3:21 ` [PATCH v2 1/5] mm: memcg: change flush_next_time to flush_last_time Yosry Ahmed
2023-10-10 3:21 ` [PATCH v2 2/5] mm: memcg: move vmstats structs definition above flushing code Yosry Ahmed
2023-10-10 3:21 ` [PATCH v2 3/5] mm: memcg: make stats flushing threshold per-memcg Yosry Ahmed
2023-10-10 3:24 ` Yosry Ahmed
2023-10-10 20:45 ` Shakeel Butt
2023-10-10 21:02 ` Yosry Ahmed
2023-10-10 22:21 ` Yosry Ahmed
2023-10-11 0:36 ` Shakeel Butt
2023-10-11 1:48 ` Yosry Ahmed
2023-10-11 12:45 ` Shakeel Butt
2023-10-12 3:13 ` Yosry Ahmed
2023-10-12 8:01 ` Yosry Ahmed
2023-10-12 8:04 ` Yosry Ahmed
2023-10-12 13:29 ` Johannes Weiner
2023-10-12 23:28 ` Yosry Ahmed
2023-10-13 2:33 ` Johannes Weiner
2023-10-13 2:38 ` Yosry Ahmed
2023-10-12 13:35 ` Shakeel Butt
2023-10-12 15:10 ` Yosry Ahmed
2023-10-12 21:05 ` Yosry Ahmed
2023-10-12 21:16 ` Shakeel Butt
2023-10-12 21:19 ` Yosry Ahmed
2023-10-12 21:38 ` Shakeel Butt
2023-10-12 22:23 ` Yosry Ahmed
2023-10-14 23:08 ` Andrew Morton
2023-10-16 18:42 ` Yosry Ahmed
2023-10-17 23:52 ` Yosry Ahmed
2023-10-18 8:22 ` Oliver Sang
2023-10-18 8:54 ` Yosry Ahmed
2023-10-20 16:17 ` kernel test robot
2023-10-20 17:23 ` Shakeel Butt
2023-10-20 17:42 ` Yosry Ahmed
2023-10-23 1:25 ` Feng Tang
2023-10-23 18:25 ` Yosry Ahmed
2023-10-24 2:13 ` Yosry Ahmed
2023-10-24 6:56 ` Oliver Sang
2023-10-24 7:14 ` Yosry Ahmed
2023-10-25 6:09 ` Oliver Sang
2023-10-25 6:22 ` Yosry Ahmed
2023-10-25 17:06 ` Shakeel Butt
2023-10-25 18:36 ` Yosry Ahmed
2023-10-10 3:21 ` [PATCH v2 4/5] mm: workingset: move the stats flush into workingset_test_recent() Yosry Ahmed
2023-10-10 3:21 ` [PATCH v2 5/5] mm: memcg: restore subtree stats flushing Yosry Ahmed
2023-10-10 16:48 ` [PATCH v2 0/5] mm: memcg: subtree stats flushing and thresholds domenico cerasuolo
2023-10-10 19:01 ` Yosry Ahmed
2023-10-18 21:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010032117.1577496-1-yosryahmed@google.com \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=ivan@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=weixugc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).