From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C492C35274 for ; Mon, 18 Dec 2023 06:54:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E71A6B0089; Mon, 18 Dec 2023 01:54:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 397686B008A; Mon, 18 Dec 2023 01:54:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25EC16B008C; Mon, 18 Dec 2023 01:54:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 175A96B0089 for ; Mon, 18 Dec 2023 01:54:30 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E539B1A08DF for ; Mon, 18 Dec 2023 06:54:29 +0000 (UTC) X-FDA: 81579025458.20.C051DFD Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id DD4532000A for ; Mon, 18 Dec 2023 06:54:27 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="iyTclJ8/"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702882468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9ksOGpeiRCLU29VRf86vnJKLk51JA4ZNWagXVPsA528=; b=MNLjvTPGWn50qp5t6shMwAcitu5FWDzIEREDvX2jciNMucS7mAqFJu9yTakf3ZfG0yT9IH AvSjHRhcqfsh5QT2Rt2/HktGPIQjAp4CrcjEo4Y4Qz+AbAOhPkx10/13HXS5M2ul1VrexQ JsWHeSpy4I20zO8Y0NbJY4D+1c+knK8= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b="iyTclJ8/"; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf03.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702882468; a=rsa-sha256; cv=none; b=J8LbKoPkfP8t4+DuuuWkiX7mDwBXvCEK7gL7DKABlr3s3Sj9eS7dpPc3I+vdDskGcp37Yn 0/Do+Oiy9YSY1WjkjUH2Ul0nZouAKZR10/IhR2YP0Z1RGqlmBEb39T96biBTGia9DnO0kD PFTKV/UU19YEC9LSwoamPsuQ50jtU3U= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 42DF4CE0EE2; Mon, 18 Dec 2023 06:54:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04D47C433C7; Mon, 18 Dec 2023 06:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702882462; bh=WqSdOGaMwSBPoEtUznslg5s7PXAyzsMtO2SlEkxyWGY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iyTclJ8/wMW+zu7NPf5HxB+KPpilY4WTl38/pGkHfTLt355xwMgIZfyU7dIReIUB9 dCraaErrmnktGo/N4KrHf0CS0DGxi1/eP5nKRH7eu1y0DlGqJ5zZxRNe0WyMz10aw4 v4zHkvihss/8toJXCHaAJxfTfER2aI8wyDGUJs78= Date: Mon, 18 Dec 2023 07:54:20 +0100 From: Greg KH To: Shuai Xue Cc: bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, will@kernel.org, jarkko@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, stable@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com Subject: Re: [PATCH v10 4/4] ACPI: APEI: handle synchronous exceptions in task work Message-ID: <2023121813-monthly-matriarch-2df4@gregkh> References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20231218064521.37324-5-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218064521.37324-5-xueshuai@linux.alibaba.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DD4532000A X-Stat-Signature: jy9msehq16wtj53nbue19yi3ig1wjb5q X-HE-Tag: 1702882467-892257 X-HE-Meta: U2FsdGVkX1/aVYhO/B4HWEm5c08erfbp3QbxIPWEu2Cymks234VucDgaFP9QeunLDNBr809j/scMarP8zXidCnGC3nMSLIIem6jGakl19sTvgEqs7UceUPxRtY99Dmc5HXVDLzSOZJ4ZEWfO55OSmcg0GJgnKJeS5FEJUsupHNrjmqDobr4K7mjhkeVHfn6NRHUnojtRaJcuNfUsj+2/R31M/MSwUGty1IqhzIyqELctS09l2UZ56vnUcUo8igIOgYL/52CCJzAmvbIbpSLoe9eiAKbbM1FyerwKdaboWxzbx0T5qKqUn47V311jrc5VC96CfYSHGt76V3gknYA2En3oIANlHTXsGjCm6Ao8VeiG4Bh9RuDeio+4RKhZPF8Cs8OqitrktRXKcLljpne+i+RQUOlQ2iihEaSgMf5DV74jvrvYY2MFGJ+H21e8ati7OU97lG0D5eySEWY+sWh/XcmRwuSuS4ifWGjOijj4IVFIShFZi0SmNxAeN1BFscXFrt/hN1SYFZYSG/9dGIU8mrYGlS4ZvCly8GOnAyht88Lo2WQMgKMfDXFz+aTDI0zY9Q9RWVVToIFM3SohBvD7wtml32RIjQXNgheff5MP1/033OsgLHYwVxPRwuQX1fY3xQtupcDE1AidtkNpRn0fJYc/SqsRIlOGxdBfFC8Zjyyclg63h2mDz9PC69coE9gD1NaQVHptrZjuXvhV5uvCsnVYqVnWIA7VaQLLBwpjbb//811t5R/bZKAawlQbAlrhkW2ubqwThHBorFQdv0tFZIWavW/PgTNv/qfWmduAiJYuzmmEqpoCbUWeKuq45kuydQcKBi0xLdkMRYorPPgjLDeBtdugiddgMfxj1kGnsxqPmdDZKDwWMa1OCkcTpEqTyBEHSRf+gDmlFvt3g5/l9DLZ0ME1QD0+iHdQSVy0DeT8x6tAk+naBIAiHMDlHEjcHYk4lnCt2cvMK8OzEBT GpoEULoF WJkpGJliSw7j1IGKo1IKShQevyFRYQW8iHfg/ZRu+0ACfhWptCdhzCLNCqDjKITE85WXGunZdgjPn8ARGvobRtUmGZd6KnZT/3hRoSLcz2lFY7lftuHwWh7yQkOw/kwQL3I6tPYeXCiv+pcjOY1oF2mjTjoxdCqMuJpIXyGyLau1ajXiAbuPhIW6F6zRBz9stwxADVUw0tiPl7QCAOI7EAEegEQaaJiNdrrGdYAOluuAsnoGzaF8KfRvyBE+XIDI9t7BiV0j1lN0UZs8OY9sbPY1k7atRGh6cWeD5lcNX5L4BdD6jYqCpo4BfUwbU0BRjsSToU3aPkNV4ME3hKIVp2h4TkGT7bh3r8/RnfaFpfcWT9TB0U9J6HOk5yQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 18, 2023 at 02:45:21PM +0800, Shuai Xue wrote: > Hardware errors could be signaled by asynchronous interrupt, e.g. when an > error is detected by a background scrubber, or signaled by synchronous > exception, e.g. when a CPU tries to access a poisoned cache line. Both > synchronous and asynchronous error are queued as a memory_failure() work > and handled by a dedicated kthread in workqueue. > > However, the memory failure recovery sends SIBUS with wrong BUS_MCEERR_AO > si_code for synchronous errors in early kill mode, even MF_ACTION_REQUIRED > is set. The main problem is that the memory failure work is handled in > kthread context but not the user-space process which is accessing the > corrupt memory location, so it will send SIGBUS with BUS_MCEERR_AO si_code > to the user-space process instead of BUS_MCEERR_AR in kill_proc(). > > To this end, queue memory_failure() as a task_work so that the current > context in memory_failure() is exactly belongs to the process consuming > poison data and it will send SIBBUS with proper si_code. > > Signed-off-by: Shuai Xue > Tested-by: Ma Wupeng > Reviewed-by: Kefeng Wang > Reviewed-by: Xiaofei Tan > Reviewed-by: Baolin Wang > --- > drivers/acpi/apei/ghes.c | 77 +++++++++++++++++++++++----------------- > include/acpi/ghes.h | 3 -- > mm/memory-failure.c | 13 ------- > 3 files changed, 44 insertions(+), 49 deletions(-) > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.