From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA32C35274 for ; Mon, 18 Dec 2023 06:54:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5ED76B0083; Mon, 18 Dec 2023 01:54:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0FD16B0085; Mon, 18 Dec 2023 01:54:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D8406B0087; Mon, 18 Dec 2023 01:54:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8CA726B0083 for ; Mon, 18 Dec 2023 01:54:09 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 56F011A085F for ; Mon, 18 Dec 2023 06:54:09 +0000 (UTC) X-FDA: 81579024618.05.4FFF7A2 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf22.hostedemail.com (Postfix) with ESMTP id 9FE29C0002 for ; Mon, 18 Dec 2023 06:54:07 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=IzjAMFF0; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf22.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702882447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v67XFPIWNLTawYP6JOl7+i6llSkDm15NEK6J3pJRCIE=; b=rouzIp36nD+gcZqGWZ1R9xV4l1sr90yMf7d050YXrgXX43iiNNuV/W5tn+PAhRWpFDe4kC VJH1xlnCQsbSnRu/2a45Su6HI3TB0K6g98QeaE8+UqnegqkLhKfp9JS0c82Mv5zmww92Fd l4AwofSQeWjTtE9muKk4HrMb4wFhGCI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=IzjAMFF0; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf22.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702882447; a=rsa-sha256; cv=none; b=7pf0dilUYBWpgjxSkGcvaoxTwduJmjhdSCt+upI3OyL/3sQ6PZhl6xxCJXFu0LXFEKnFLn pcti3AokOdx9AiQecsDJAhMer/hFu3GdWiNv+vaV9BHWYnewsaiYBgiChLG9FuBCqZkDwT iHKTll5PXkN9vAm8+rm225GH1vt6xyw= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 0D453B80D90; Mon, 18 Dec 2023 06:54:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCE19C433C7; Mon, 18 Dec 2023 06:54:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1702882445; bh=8Kl+lj+tSnogG6JvAU6RoT4pxakzbvX1ijwD+7zp3I8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IzjAMFF0vQGHpA1qzgdXpaupuutj/CMlFSu+srLaE4/MSS90lmByqlQxFcnKQ2YZI UTZ9b/kgzi+IyyUadHjzR6BhguXzBlJ0Abcasx/BmfRYLxd5M+ZSkgxFAqN13uQ2zD uJ+xuIOKS3IGeVwgR1yS1ZaVtzFMDWdMdHgai6UQ= Date: Mon, 18 Dec 2023 07:54:03 +0100 From: Greg KH To: Shuai Xue Cc: bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, will@kernel.org, jarkko@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, stable@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com Subject: Re: [PATCH v10 2/4] ACPI: APEI: send SIGBUS to current task if synchronous memory error not recovered Message-ID: <2023121855-crimson-hamper-57ef@gregkh> References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20231218064521.37324-3-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231218064521.37324-3-xueshuai@linux.alibaba.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 9FE29C0002 X-Stat-Signature: 4duxdi68ufy53rhzgkdsm4b6sp3h8crw X-Rspam-User: X-HE-Tag: 1702882447-471635 X-HE-Meta: U2FsdGVkX1+myuOwuzYecniFfPExMhVjndrngBgFc3urlechvRVBxBfko4beq8jpeodyVkqO7M1ZinH2GlerK/fCxmw+uGsBhi3OZ5o6XMPtdQAGabUXrKD+G/76vP3ZPYE42z0dsaVS39TuUqc4FAkrsIztiUsAP7o0oF9s/CsuWicnF2oMw2Y5oJRKO1vISYXC3mnzV1o3c4cf/CssYX3M8rX7ZpA77J5Bbl5zBZknhzkKfh/E3bmWrUoAQ6wHZs9VgBrQp6PLHoGnaCPOXW+oH7mZI6yWuad6n+0jX+uH9eqPLS+VypCr4OpE7LAVU4ShpMgrXRVsP10Nc+pClFlSRokAr+cMu73OWfE3qJ3Rifgwh1SQk35+xMHIlEoKKQ5/cCZHPScMUieUmzD0mJuRTZYvd1OcEs3CYq3OJQmFcPkUTo62SVPdKN2tvIhEkElpsD/br7JlkuHfuhA0JIWR/wR9EHoyTTAZx7pQscsG1GoidOvkNiHCMKhzfmCt49zgvXwBP/EiEt/PzF+o/ANvBnrZVPi0X0B7VnWQLWHO0C+dxL/QLTSW5BRudWmbPE7sxJFw/92+5YhcMwGs7z1Dw7YaNBtIIC0XXqVJKar+mNqSj/oIj021FZIyhQD6METttOdjZicmrUBxDO21AXoQzXJ48Ol+FnYcKLPHchPPTS5fUPZy6rqU5hXr1cFSu56YciuX4lhWZH3UcMrs7UwAbict+FPl1LMyRgkghKG4zbA+BkqFlD0L1jhZtonUuSfLrJ5TCGaTBzMwxWIQa08AeV/9Yipve+25jSj/bp8eMx/CoSjdOoq5WPD1ohUB1oMpBbt4FBSpFsw26GG4PTa3C7a9BgEC0vnQpHt34oLgyxgqFmr0zXmi6HHTGeQY0Gxw8JxOrex+LLWu2wKa+yLRM9SFUrl7Hn0dmNq3sxKTFxb2TZg6ZNQ43hnN7PIZl2AESPwqnZ4vybcDTkD bk3/JOho rXRNBTCAuPPrYJm8JzIaKBSszthcypDD92qOMRmYYuNVZFx1/hmqiYLDUD2SlJrmmnPPbGE9A0IZIiSMiEAefbEwLqu51TtmpK6DD826CNhCFYVDKm/I/42TMEo14DPX0j1B6umKDxNPuaS2alU+o8n//qMxSN+i755HqPKWgTipMACP75cDJbt83M2yxkkw3F+IvonmyoqlN+IEKDlwnr1i5JtSWweDmY2fALBeThnnSJ78RQehbjmTjMO/ipYM47EBc9CbRxQ4PH7czb4+ANqFuZVleg2QBcvvWPY8/vtatcBdHD1nocxpk4ZQQE24pdJyrGv9TZYwYmFgBxdRpLGMWtboWCw/gLmrg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 18, 2023 at 02:45:19PM +0800, Shuai Xue wrote: > Synchronous error was detected as a result of user-space process accessing > a 2-bit uncorrected error. The CPU will take a synchronous error exception > such as Synchronous External Abort (SEA) on Arm64. The kernel will queue a > memory_failure() work which poisons the related page, unmaps the page, and > then sends a SIGBUS to the process, so that a system wide panic can be > avoided. > > However, no memory_failure() work will be queued when abnormal synchronous > errors occur. These errors can include situations such as invalid PA, > unexpected severity, no memory failure config support, invalid GUID > section, etc. In such case, the user-space process will trigger SEA again. > This loop can potentially exceed the platform firmware threshold or even > trigger a kernel hard lockup, leading to a system reboot. > > Fix it by performing a force kill if no memory_failure() work is queued for synchronous errors. > > Signed-off-by: Shuai Xue > --- > drivers/acpi/apei/ghes.c | 9 +++++++++ > 1 file changed, 9 insertions(+) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.