From: kernel test robot <lkp@intel.com>
To: Byungchul Park <byungchul@sk.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: oe-kbuild-all@lists.linux.dev, kernel_team@skhynix.com,
akpm@linux-foundation.org, ying.huang@intel.com,
namit@vmware.com, vernhao@tencent.com,
mgorman@techsingularity.net, hughd@google.com,
willy@infradead.org, david@redhat.com, peterz@infradead.org,
luto@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, rjgolo@gmail.com
Subject: Re: [PATCH v6 6/7] mm: Defer TLB flush by keeping both src and dst folios at migration
Date: Tue, 16 Jan 2024 07:49:52 +0800 [thread overview]
Message-ID: <202401160753.u2pxHstH-lkp@intel.com> (raw)
In-Reply-To: <20240115081953.2521-7-byungchul@sk.com>
Hi Byungchul,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 0dd3ee31125508cd67f7e7172247f05b7fd1753a]
url: https://github.com/intel-lab-lkp/linux/commits/Byungchul-Park/x86-tlb-Add-APIs-manipulating-tlb-batch-s-arch-data/20240115-162220
base: 0dd3ee31125508cd67f7e7172247f05b7fd1753a
patch link: https://lore.kernel.org/r/20240115081953.2521-7-byungchul%40sk.com
patch subject: [PATCH v6 6/7] mm: Defer TLB flush by keeping both src and dst folios at migration
config: alpha-allnoconfig (https://download.01.org/0day-ci/archive/20240116/202401160753.u2pxHstH-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240116/202401160753.u2pxHstH-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401160753.u2pxHstH-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from include/linux/pid_namespace.h:7,
from include/linux/ptrace.h:10,
from arch/alpha/kernel/asm-offsets.c:11:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/asm-offsets.c:15:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
15 | void foo(void)
| ^~~
--
In file included from arch/alpha/kernel/traps.c:13:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/traps.c:210:1: warning: no previous prototype for 'do_entArith' [-Wmissing-prototypes]
210 | do_entArith(unsigned long summary, unsigned long write_mask,
| ^~~~~~~~~~~
arch/alpha/kernel/traps.c:232:1: warning: no previous prototype for 'do_entIF' [-Wmissing-prototypes]
232 | do_entIF(unsigned long type, struct pt_regs *regs)
| ^~~~~~~~
arch/alpha/kernel/traps.c:399:1: warning: no previous prototype for 'do_entDbg' [-Wmissing-prototypes]
399 | do_entDbg(struct pt_regs *regs)
| ^~~~~~~~~
arch/alpha/kernel/traps.c:435:1: warning: no previous prototype for 'do_entUna' [-Wmissing-prototypes]
435 | do_entUna(void * va, unsigned long opcode, unsigned long reg,
| ^~~~~~~~~
arch/alpha/kernel/traps.c:720:1: warning: no previous prototype for 'do_entUnaUser' [-Wmissing-prototypes]
720 | do_entUnaUser(void __user * va, unsigned long opcode,
| ^~~~~~~~~~~~~
arch/alpha/kernel/traps.c:975:1: warning: no previous prototype for 'trap_init' [-Wmissing-prototypes]
975 | trap_init(void)
| ^~~~~~~~~
--
In file included from arch/alpha/kernel/process.c:20:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from arch/alpha/include/asm/io.h:8,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:17,
from arch/alpha/include/asm/hardirq.h:8,
from include/linux/hardirq.h:11,
from include/linux/interrupt.h:11,
from include/linux/kernel_stat.h:9,
from arch/alpha/kernel/irq.c:17:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/irq.c:96:1: warning: no previous prototype for 'handle_irq' [-Wmissing-prototypes]
96 | handle_irq(int irq)
| ^~~~~~~~~~
--
In file included from arch/alpha/include/asm/io.h:8,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from arch/alpha/kernel/irq_alpha.c:8:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/irq_alpha.c:45:1: warning: no previous prototype for 'do_entInt' [-Wmissing-prototypes]
45 | do_entInt(unsigned long type, unsigned long vector,
| ^~~~~~~~~
--
In file included from include/linux/pid_namespace.h:7,
from include/linux/ptrace.h:10,
from arch/alpha/kernel/signal.c:16:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/signal.c:205:1: warning: no previous prototype for 'do_sigreturn' [-Wmissing-prototypes]
205 | do_sigreturn(struct sigcontext __user *sc)
| ^~~~~~~~~~~~
arch/alpha/kernel/signal.c:233:1: warning: no previous prototype for 'do_rt_sigreturn' [-Wmissing-prototypes]
233 | do_rt_sigreturn(struct rt_sigframe __user *frame)
| ^~~~~~~~~~~~~~~
arch/alpha/kernel/signal.c:523:1: warning: no previous prototype for 'do_work_pending' [-Wmissing-prototypes]
523 | do_work_pending(struct pt_regs *regs, unsigned long thread_flags,
| ^~~~~~~~~~~~~~~
--
In file included from arch/alpha/kernel/ptrace.c:11:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/ptrace.c:322:26: warning: no previous prototype for 'syscall_trace_enter' [-Wmissing-prototypes]
322 | asmlinkage unsigned long syscall_trace_enter(void)
| ^~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/ptrace.c:334:1: warning: no previous prototype for 'syscall_trace_leave' [-Wmissing-prototypes]
334 | syscall_trace_leave(void)
| ^~~~~~~~~~~~~~~~~~~
--
In file included from arch/alpha/kernel/time.c:28:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/time.c:64:6: warning: no previous prototype for 'arch_irq_work_raise' [-Wmissing-prototypes]
64 | void arch_irq_work_raise(void)
| ^~~~~~~~~~~~~~~~~~~
--
In file included from arch/alpha/include/asm/io.h:8,
from arch/alpha/kernel/io.c:10:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/io.c:654:1: warning: no previous prototype for 'scr_memcpyw' [-Wmissing-prototypes]
654 | scr_memcpyw(u16 *d, const u16 *s, unsigned int count)
| ^~~~~~~~~~~
--
In file included from arch/alpha/include/asm/io.h:8,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:17,
from arch/alpha/include/asm/hardirq.h:8,
from include/linux/hardirq.h:11,
from include/linux/interrupt.h:11,
from include/linux/pci.h:38,
from arch/alpha/kernel/pci.c:17:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/pci.c:285:1: warning: no previous prototype for 'pcibios_claim_one_bus' [-Wmissing-prototypes]
285 | pcibios_claim_one_bus(struct pci_bus *b)
| ^~~~~~~~~~~~~~~~~~~~~
--
In file included from arch/alpha/include/asm/io.h:8,
from arch/alpha/kernel/core_cia.c:16:
>> include/linux/mm.h:2046:43: warning: 'struct arch_tlbflush_unmap_batch' declared inside parameter list will not be visible outside of this definition or declaration
2046 | static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/core_cia.c:284:1: warning: no previous prototype for 'cia_pci_tbi_try2' [-Wmissing-prototypes]
284 | cia_pci_tbi_try2(struct pci_controller *hose,
| ^~~~~~~~~~~~~~~~
arch/alpha/kernel/core_cia.c:580:1: warning: no previous prototype for 'cia_save_srm_settings' [-Wmissing-prototypes]
580 | cia_save_srm_settings(int is_pyxis)
| ^~~~~~~~~~~~~~~~~~~~~
arch/alpha/kernel/core_cia.c:606:1: warning: no previous prototype for 'cia_restore_srm_settings' [-Wmissing-prototypes]
606 | cia_restore_srm_settings(void)
| ^~~~~~~~~~~~~~~~~~~~~~~~
..
vim +2046 include/linux/mm.h
2040
2041 #if defined(CONFIG_MIGRATION) && defined(CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH)
2042 extern void migrc_flush_start(void);
2043 extern void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch);
2044 #else
2045 static inline void migrc_flush_start(void) {}
> 2046 static inline void migrc_flush_end(struct arch_tlbflush_unmap_batch *arch) {}
2047 #endif
2048
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-01-15 23:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-15 8:19 [PATCH v6 0/7] Reduce TLB flushes by 94% by improving folio migration Byungchul Park
2024-01-15 8:19 ` [PATCH v6 1/7] x86/tlb: Add APIs manipulating tlb batch's arch data Byungchul Park
2024-01-15 8:19 ` [PATCH v6 2/7] arm64: tlbflush: " Byungchul Park
2024-01-15 8:19 ` [PATCH v6 3/7] mm/rmap: Recognize read-only TLB entries during batched TLB flush Byungchul Park
2024-01-15 8:19 ` [PATCH v6 4/7] mm: Separate move/undo doing on folio list from migrate_pages_batch() Byungchul Park
2024-01-15 8:19 ` [PATCH v6 5/7] mm: Add APIs to free a folio directly to the buddy bypassing pcp Byungchul Park
2024-01-15 8:19 ` [PATCH v6 6/7] mm: Defer TLB flush by keeping both src and dst folios at migration Byungchul Park
2024-01-15 23:49 ` kernel test robot [this message]
2024-01-16 1:01 ` kernel test robot
2024-01-16 2:12 ` kernel test robot
2024-01-15 8:19 ` [PATCH v6 7/7] mm: Pause migrc mechanism at high memory pressure Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202401160753.u2pxHstH-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=byungchul@sk.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kernel_team@skhynix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rjgolo@gmail.com \
--cc=tglx@linutronix.de \
--cc=vernhao@tencent.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).