From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD2ACC54E49 for ; Mon, 26 Feb 2024 10:47:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 45A5A80009; Mon, 26 Feb 2024 05:47:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E41E94002C; Mon, 26 Feb 2024 05:47:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25BF080009; Mon, 26 Feb 2024 05:47:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0B3F294002C for ; Mon, 26 Feb 2024 05:47:01 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8F0DEA07A8 for ; Mon, 26 Feb 2024 10:47:00 +0000 (UTC) X-FDA: 81833627400.30.FF2BE72 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf19.hostedemail.com (Postfix) with ESMTP id 9D4AD1A0013 for ; Mon, 26 Feb 2024 10:46:57 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=g6HOrIAM; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708944418; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0CUdEbnigVU9mXxGYVPNrIQnBDNCqMVq2aXpPsduCD0=; b=lfuzMGg24gSN67i7GijEo0QHHbOxEF830hzBUGqj0pcr5G2R3wMSPXMvE0GSlx2F0qEKno DOzkN/L7tKiH+/l59bnh2q9HevBQHaEdlbYBcYUS7clmeOXx5ukQm7+NuYOTVODkdhoKLG tQOFt3aLVfPFZWOCIF1HgjOHoL4TcjQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=g6HOrIAM; spf=pass (imf19.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de; dmarc=pass (policy=none) header.from=alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708944418; a=rsa-sha256; cv=none; b=EoWT5LE1EZqa1dT2qLRKJCsJ50g0ymOIhWgm7iFxomMwbo1B2GSilMcrsx0cj3zK394YMl G9NN1tV8d0ikemqUPnJ81MxSaLf8bHy2fYdOdUlGTMgvi4FrCj9jzFmSciDwBkgg0Myjyu dPbhuHZnlVXKXXLqh9bU7kB36T/LEWg= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 4F4E240E00B2; Mon, 26 Feb 2024 10:46:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id U7uW1zKRoeoK; Mon, 26 Feb 2024 10:46:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1708944411; bh=0CUdEbnigVU9mXxGYVPNrIQnBDNCqMVq2aXpPsduCD0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g6HOrIAMBI/QdrQCHnh6KLtisQeavnbe4CIRbk5nJQZFObd2N2xPrKOGuXqYMg2t6 P4Dmj/wJwv1rYMqLn+i4zxnBWaBG9Cebrj+lVhkKl9vyQj4rZ4RpjExeUQsEgNqwER 2PLB98axkXAIPxgZ/CW5yxyV3w7usK4m/N4N82rR1SPvO3mJsmJ17Y44w5CGu4wEeq c/schnPIPTJrw3nOlbFi53BoJXIKJLmF/0L6NWbCMn0lZV7LkHJqla5KSSPh+Ke8Qz rdBfvZoNA1H+jP0+DXhiI+9iRBWMEuUMPl/eBi3ghQpJeRebfYNN9sPRZXoFyjZet5 HSTuZ57hFy4M0Ym+SYqOyeL030DoTjKmHdhiI5wH9RTGzz/Ai+E/Q6YIeAFAiTz/TB +WvD6mlU5YujNYju/yyQfYjp/u+xLdEi8MV0NgOHozqGiHAd70X+cTrQxWco86YUZs lTh4PKq+w3p16TNk2UPgqxUA4Q+zQ8w7VZ9xr8pVsZDI0Fg6+jfplM2ilB8u4VrBz9 ii9/B6ZZ0aoHI/ZVNJm/mh6g4lLPALdPmSoVPo+vLbMHiEhw3VSdleofAGMfkSVQhB BsFAwm40e2IREa1nZCNfc28OgNKKSQ8a0g+2Ul+RVN8/fqPrLxe9cspumL6YxgnBRD piQBTNX/Di/raOX/POmXs3HY= Received: from zn.tnic (pd953021b.dip0.t-ipconnect.de [217.83.2.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DA82840E0196; Mon, 26 Feb 2024 10:46:18 +0000 (UTC) Date: Mon, 26 Feb 2024 11:46:11 +0100 From: Borislav Petkov To: Shuai Xue Cc: rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com Subject: Re: [PATCH v11 2/3] mm: memory-failure: move return value documentation to function declaration Message-ID: <20240226104611.GCZdxr82q-Wcms7R3S@fat_crate.local> References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20240204080144.7977-3-xueshuai@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240204080144.7977-3-xueshuai@linux.alibaba.com> X-Rspamd-Queue-Id: 9D4AD1A0013 X-Rspam-User: X-Stat-Signature: kn1zij153bjp8xkkzmi5ijti3asw1fpy X-Rspamd-Server: rspam01 X-HE-Tag: 1708944417-653066 X-HE-Meta: U2FsdGVkX1+m6OODLL1uD3UM5Mb3WDZFn+C1x5HIIsQTGo5q+9Z7QjnzgE6qnuj8HVB+dzsvMmN5FOZnAB9Gr5sZQ168cL+efPZSQwlOFZws+0eOhqp3TxADo5W5t2ii8iplcC8KZ5KAD/brau20iDq0xGtDfPR/48JdAwY5iyFlI740pkhuNk+aQl9741nVuXVQyV1hk5pcGFZCWwPOmR6gGSFQuHn/TOXHc70/FGKLfQYTI/PowtsTDcgka0qknsThtfo64t/aSk9BLFar1dlG7YSKrSvapCz3ho2p5HI2kouXvQUWQd0RqHFOAzg1I29lfifAknSr6DW9gooywrGgILyorltvtmgp60kwCCUk0Fp/7Rm3GCb/RpdC/HiNGhyZqbttzfHCFcCdWah5IF5XAOM9Rnx7YNMGOtaD15a3al0WOGE4z9lwFtogAt8S9i8gUGo99FrDwvG5IEEdSpnN6HcCmzC9FnGHGc4UCWX35LOJABUcGsiy9jopeQcZzDZfVJK8PyJ3fqQPziLvK5gkQUsk6ID6FoHaZf67M0XVE4gQQ59f0nK4RYVwdymdAsspZgBZjQf0tas7ubZWTw+4anRy5ncRgribLpvCVGyYJpGPyMoMKsH3GpIgwi/IQgfEheR3xPaf4iM3XgkTG1TBP7Cz0tPT6xMilSTEDoZmOxZI6bRcp6tXRGdpzT9MetcP5K/xVG7RUSIR8Q5VIdVSu5EvC5ub2i8uRDu8K3l9VDyoMl3fOez9jP1fbTDznX0Xn6hl6Zuf+RBBSj4I+INOkVlzHIr6oVm/m/F7tAbD/nFJKesjTamLzc+t7QmTqzvnFEVaUArgBBrnv5qefwpD3TpDXrgnxI35Fj3R53Ryq6caXaYhl5D03zthdIK7u0wEtdrKMlD95PBs/uvBvfiBR/ULpsnYJL6VYE+LvZMthgCK+XqGYirrMoBFapqq6qYOlgaTMW7x6O0UjsR O4KIReup 64kT/DJzOvbdsIPNseh3iKaw4w6PS1TCI1GB9D2QlSYevXmec526NDtAUVdAGb4cVLNSoU7x9+ObcVhLUyxFuQGrhmtxKPy+7DD9JBWuPRYe/1zEeNyblRz/OBpChxZ1DWRjHE259fVDiwTq5M6NW4aBM22nvebndIRMnnz1x8GU2ijkkrVgzvPRK1J5E1+Zz9L4Y7TJim9VYuTVwf0Y5D3EtLQpPXiK5RclE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 04, 2024 at 04:01:43PM +0800, Shuai Xue wrote: > Part of return value comments for memory_failure() were originally > documented at the call site. Move those comments to the function > declaration to improve code readability and to provide developers with > immediate access to function usage and return information. > > Signed-off-by: Shuai Xue > --- > arch/x86/kernel/cpu/mce/core.c | 9 +-------- > mm/memory-failure.c | 9 ++++++--- > 2 files changed, 7 insertions(+), 11 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c > index bc39252bc54f..822b21eb48ad 100644 > --- a/arch/x86/kernel/cpu/mce/core.c > +++ b/arch/x86/kernel/cpu/mce/core.c > @@ -1365,17 +1365,10 @@ static void kill_me_maybe(struct callback_head *cb) > return; > } > > - /* > - * -EHWPOISON from memory_failure() means that it already sent SIGBUS > - * to the current process with the proper error info, > - * -EOPNOTSUPP means hwpoison_filter() filtered the error event, > - * > - * In both cases, no further processing is required. > - */ > if (ret == -EHWPOISON || ret == -EOPNOTSUPP) > return; > > - pr_err("Memory error not recovered"); > + pr_err("Sending SIGBUS to current task due to memory error not recovered"); Unrelated change. > kill_me_now(cb); > } > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index 636280d04008..d33729c48eff 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -2175,9 +2175,12 @@ static int memory_failure_dev_pagemap(unsigned long pfn, int flags, > * Must run in process context (e.g. a work queue) with interrupts > * enabled and no spinlocks held. > * > - * Return: 0 for successfully handled the memory error, > - * -EOPNOTSUPP for hwpoison_filter() filtered the error event, > - * < 0(except -EOPNOTSUPP) on failure. > + * Return values: > + * 0 - success > + * -EOPNOTSUPP - hwpoison_filter() filtered the error event. > + * -EHWPOISON - sent SIGBUS to the current process with the proper > + * error info by kill_accessing_process(). kill_accessing_process() is not the only one returning -EHWPOISON. And if you look at the code, it should be: -EHWPOISON - the page was already poisoned, potentially kill process or so. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette