From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 195BDC47DD9 for ; Wed, 28 Feb 2024 22:52:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DD176B009F; Wed, 28 Feb 2024 17:52:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 78D656B00A0; Wed, 28 Feb 2024 17:52:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6547F6B00A1; Wed, 28 Feb 2024 17:52:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 55EEC6B009F for ; Wed, 28 Feb 2024 17:52:24 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1275A14113F for ; Wed, 28 Feb 2024 22:52:24 +0000 (UTC) X-FDA: 81842713008.12.EB08592 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf27.hostedemail.com (Postfix) with ESMTP id 50C2D40006 for ; Wed, 28 Feb 2024 22:52:22 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=toblux-com.20230601.gappssmtp.com header.s=20230601 header.b=gHarNxMl; dmarc=none; spf=none (imf27.hostedemail.com: domain of thorsten.blum@toblux.com has no SPF policy when checking 209.85.218.44) smtp.mailfrom=thorsten.blum@toblux.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709160742; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=p68q64fPKpPRnVU3Ta/zu5aSS1cC7AT3EHsyijjzmko=; b=fvKhmHHzCIUDvLh7uxb4QJqzIlizJoZxneEf+LxrzlY0rszlJD/pJBVJtLcltX6q9Xdeo8 EPhofYaJPjxXC4wFNKLYXEpohNk9xqKOXvCY6kILWWmQXGiye7dCR0NN9RUr+MUGxgngqe Bw7a9zJLujEb+p1vbQU6qffTcGlpD4Q= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=toblux-com.20230601.gappssmtp.com header.s=20230601 header.b=gHarNxMl; dmarc=none; spf=none (imf27.hostedemail.com: domain of thorsten.blum@toblux.com has no SPF policy when checking 209.85.218.44) smtp.mailfrom=thorsten.blum@toblux.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709160742; a=rsa-sha256; cv=none; b=TsaLGCqPjgfSEsBAjGRNLvNyTki275aq2evaeaL9aqMPLtBIeqKIMDmq632gfWqJbb1bPd fYHYXsMsUCjUjTAJAu/KOwSW3XK0GJI1T9vEq6PLmYHtvFCHP+CyvaraBWzyDBebDhvXFY 0VSzfbFtpquPoA6n9GLBzp2catxWPtI= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a28a6cef709so45430366b.1 for ; Wed, 28 Feb 2024 14:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toblux-com.20230601.gappssmtp.com; s=20230601; t=1709160741; x=1709765541; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=p68q64fPKpPRnVU3Ta/zu5aSS1cC7AT3EHsyijjzmko=; b=gHarNxMl8p8KIkMOtW8Ru0XBjO/FFg/R2UtXTVQd8+qZ7aHLwhIXFc82Lac99r/qop TuXJjIynVc4LLSLgDu1W7jLRJCRV+CEwhy8KKU/GTf77lJMQuRvg2bejoHqM1uxIq/Qv AeAOAB0MUDiiNmTn/QaOmmNtkMQehBxB9m1z416z6MFiInLLO2Aecw5KewKnaHdCJR5Y /3vw24F4CTQ8WWKKe4HJ6MTUBAxWTQpQWQ4xF8nMqHdC1NqBbGJ1bXf4UqYmc31Uj7+Y Tha6dC47WAv9y/ecJDG7bZHHY5u8Q2ZN3Ne+VxaW/uW6khGLRaAijdr/BuZp72Vs5IAI uDzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709160741; x=1709765541; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p68q64fPKpPRnVU3Ta/zu5aSS1cC7AT3EHsyijjzmko=; b=RUwaNrcMZy5WkzL1PdYflHtlwE/HE8Xk4UBd8SG7sVzgolve/J3l3vRi29Ger/UhQ9 7UtEgMryEpvgO6Dt8PdTpWAoTyvmEu6DMxAcrvbwmMoU1Lrw83SvPx7ipGoa3dMA/e3C +DYjLc/GDPSMd2jfTOVUgiXRzAeXUpWa9ib7kQi35ajaZS2KbsYFkEeWoLBCuFM8AiXy shF78PFrFEpCDNjNT22hcq3e5ijJ3D/6feBHM/50XW0zhBTcEB7UUjy98TL6W+A6DNgX mhVUGrbW3Tv/f/6RzqIvYs5THwCObw3iV+SK5VRF3ZJKDwSvpF6jnkGJRqiW4iM2oU4a LBWg== X-Gm-Message-State: AOJu0Yx/hL1usA3YTfh2Xv/pWw4lasj6p5mxMn9Bg32tfxF1wewr+izO xXIdkcn6m6nt1FmoIl6LFNIwLlptuT5m3SXFEgqdFggasQKo+XwKXocahzwkN1I= X-Google-Smtp-Source: AGHT+IFXxI9A58dhuw3TFJjV1Gqjef2xeIhS2AJ9dF542nq8/YdvfewX1SoXF9u5MsKEXu0DwDs0DA== X-Received: by 2002:a17:906:b7d4:b0:a3f:7e2:84cc with SMTP id fy20-20020a170906b7d400b00a3f07e284ccmr241976ejb.6.1709160740552; Wed, 28 Feb 2024 14:52:20 -0800 (PST) Received: from fedora.fritz.box (aftr-82-135-80-35.dynamic.mnet-online.de. [82.135.80.35]) by smtp.gmail.com with ESMTPSA id q11-20020a17090622cb00b00a431e4d5deasm2292785eja.155.2024.02.28.14.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 14:52:20 -0800 (PST) From: Thorsten Blum To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Thorsten Blum Subject: [PATCH] mm: page_alloc: Use div64_ul() instead of do_div() Date: Wed, 28 Feb 2024 23:49:12 +0100 Message-ID: <20240228224911.1164-2-thorsten.blum@toblux.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: rye8mjk8m75xu73qqka46t3id4jh187u X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 50C2D40006 X-HE-Tag: 1709160742-763167 X-HE-Meta: U2FsdGVkX18+IZpSn8jzJf78FUtQo4klqwf5ie9Cgo6EN6/RNSE58WdWTdBBTFD7ghumGbnzGlfjxvA6rkesRDvWRe75k8x0eZLjk0X1C18u69ksXLoJH0Ue6HoNwRMAraNv8HCGEOdHYg1WTrSa9fJLt4nyTWgqOSOyA5SmZ71G9QkMdw07jIyeVKRBKcLTDuYBFCfffgLTEnpYFzShBpo5IaLdo8tDodNHDXf8gbUp8R8sQc/IC63NvWNGOXFYtL3TWNJC4/xTY7WRMK32yCECuIdei8W1TIE1SW3YONFI81CrysYKEoXfgFcTftvKg1ngPtb9MFud4yIz9qvC/U7sK0rp/125YC3aAOEkrtVJwP82AORswiq9rRJUz6YQJfXgYoQDjnKrxhquwa56kmbcdybcB7SG7B3/7F8T3ZqpScNPm09ci2DyeHA6iAUlYPT+e9yrcnDfqJK6gfTy70D5mp/n2sue4mdV/jXyN8mGqKhm0TVr+xokAI1yhKHHhDmwfTyR51NsY89IW/p+cMIPYOU9aGuEtP5Wzl21WxO3/J6QXgARxdJWj89UcS0WON1gtD1h8a7MtZO/NzAfEkoQzZ/kmTXmDSy1VBHjTJbnNRSCmqs7jfSYh+LlABubZBqogyC43Lp4F4+lcnDyBqxFczfemylnXD0rF8iQ6M6yGYYSDBUach5Qv7botUiMjBup/OYeR7s+uo0nLPH47WQSvh5h3BrDWYV6X8rvJ6pWP+rKoIgyq0VkG9yXlBB+A929cyBsnMyJHHfT1kBfIQ4kpklx2PgpmtS1+MB9q8+RnRCghWfnA418xMRPbyD0L0Uq4BfWR9Sm2uKYTr+mktY0DH61o8WtRWuRzUuLH4GtYQS5pNasJZg4e0+hHBQCF0p4QFA+VCnk52yvUyp4eGFrPxFS2esu++UR9AlY1HdL0uC5O2eIMElJwMGuJWsAn6LNLGlNgGDee2H8DMH 5RQj7qMb bN0T26cVvirS1+9YPZXtGTSi4cx6+RzWceZJz+FzsDVAv8EL/WnBnZFJdaRU/aGrSWIlmrDAIZSsHmcWGZCXFE1aw/wSq0+monNC67Z0ZBDCtbmbFRrPKzsBzvKm+Eh74arNQ+wDFM5SCTiUVnqZA5wfuefQhmNTzeYrDOdXlnC2LCOX0Pah7gN514Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Fixes Coccinelle/coccicheck warning reported by do_div.cocci. Compared to do_div(), div64_ul() does not implicitly cast the divisor and does not unnecessarily calculate the remainder. Signed-off-by: Thorsten Blum --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 150d4f23b010..dfafec7fba1d 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -5845,7 +5845,7 @@ static void __setup_per_zone_wmarks(void) spin_lock_irqsave(&zone->lock, flags); tmp = (u64)pages_min * zone_managed_pages(zone); - do_div(tmp, lowmem_pages); + tmp = div64_ul(tmp, lowmem_pages); if (is_highmem(zone) || zone_idx(zone) == ZONE_MOVABLE) { /* * __GFP_HIGH and PF_MEMALLOC allocations usually don't -- 2.44.0