From: Hao Ge <gehao@kylinos.cn>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
gehao618@163.com, Hao Ge <gehao@kylinos.cn>
Subject: [PATCH v2] mm/vmstat: Add order's information for extfrag_index and unusable_index
Date: Thu, 29 Feb 2024 22:14:43 +0800 [thread overview]
Message-ID: <20240229141443.99408-1-gehao@kylinos.cn> (raw)
Current cat /sys/kernel/debug/extfrag/extfrag_index and
/sys/kernel/debug/extfrag/unusable_index is not friendly to userspace.
We should add order's information so that users can clearly understand
the situation of each order at a glance like pagetypeinfo.
before:
cat /sys/kernel/debug/extfrag/extfrag_index:
Node 0, zone DMA32 ...... ...... ...... ......
Node 0, zone Normal ...... ...... ...... ......
cat /sys/kernel/debug/extfrag/unusable_index:
Node 0, zone DMA32 ..... ..... ..... .....
Node 0, zone Normal ..... ..... ..... .....
after:
cat /sys/kernel/debug/extfrag/extfrag_index:
Extfrag index at order: 0 1 2 3
Node 0, zone DMA ...... ...... ...... ......
Node 0, zone Normal ...... ...... ...... ......
cat /sys/kernel/debug/extfrag/unusable_index:
Unusable index at order: 0 1 2 3
Node 0, zone DMA ..... ..... ..... .....
Node 0, zone Normal ..... ..... ..... .....
Signed-off-by: Hao Ge <gehao@kylinos.cn>
---
v1 -> v2: Use '.' to replace related values for commit message
---
mm/vmstat.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/mm/vmstat.c b/mm/vmstat.c
index db79935e4a54..fe0b811e9d7f 100644
--- a/mm/vmstat.c
+++ b/mm/vmstat.c
@@ -2178,7 +2178,7 @@ static void unusable_show_print(struct seq_file *m,
int index;
struct contig_page_info info;
- seq_printf(m, "Node %d, zone %8s ",
+ seq_printf(m, "Node %d, zone %11s ",
pgdat->node_id,
zone->name);
for (order = 0; order < NR_PAGE_ORDERS; ++order) {
@@ -2201,12 +2201,19 @@ static void unusable_show_print(struct seq_file *m,
*/
static int unusable_show(struct seq_file *m, void *arg)
{
+ int order;
pg_data_t *pgdat = (pg_data_t *)arg;
/* check memoryless node */
if (!node_state(pgdat->node_id, N_MEMORY))
return 0;
+ /* Print header */
+ seq_printf(m, "%s ", "Unusable index at order:");
+ for (order = 0; order < NR_PAGE_ORDERS; ++order)
+ seq_printf(m, "%5d ", order);
+ seq_putc(m, '\n');
+
walk_zones_in_node(m, pgdat, true, false, unusable_show_print);
return 0;
@@ -2230,7 +2237,7 @@ static void extfrag_show_print(struct seq_file *m,
/* Alloc on stack as interrupts are disabled for zone walk */
struct contig_page_info info;
- seq_printf(m, "Node %d, zone %8s ",
+ seq_printf(m, "Node %d, zone %10s ",
pgdat->node_id,
zone->name);
for (order = 0; order < NR_PAGE_ORDERS; ++order) {
@@ -2247,8 +2254,15 @@ static void extfrag_show_print(struct seq_file *m,
*/
static int extfrag_show(struct seq_file *m, void *arg)
{
+ int order;
pg_data_t *pgdat = (pg_data_t *)arg;
+ /* Print header */
+ seq_printf(m, "%s ", "Extfrag index at order:");
+ for (order = 0; order < NR_PAGE_ORDERS; ++order)
+ seq_printf(m, "%6d ", order);
+ seq_putc(m, '\n');
+
walk_zones_in_node(m, pgdat, true, false, extfrag_show_print);
return 0;
--
2.25.1
next reply other threads:[~2024-02-29 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 14:14 Hao Ge [this message]
2024-02-29 18:40 ` [PATCH v2] mm/vmstat: Add order's information for extfrag_index and unusable_index Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240229141443.99408-1-gehao@kylinos.cn \
--to=gehao@kylinos.cn \
--cc=akpm@linux-foundation.org \
--cc=gehao618@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).