From: Soma Nakata <soma.nakata01@gmail.com>
To: linux-mm@kvack.org
Cc: soma.nakata01@gmail.com,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mm/filemap: set folio->mapping to NULL before xas_store()
Date: Sat, 23 Mar 2024 06:04:54 +0900 [thread overview]
Message-ID: <20240322210455.3738-1-soma.nakata01@gmail.com> (raw)
Functions such as __filemap_get_folio() check the truncation of
folios based on the mapping field. Therefore setting this field to NULL
earlier prevents unnecessary operations on already removed folios.
Signed-off-by: Soma Nakata <soma.nakata01@gmail.com>
---
mm/filemap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 2723104cc06a..79bac7c00084 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -139,11 +139,12 @@ static void page_cache_delete(struct address_space *mapping,
VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio);
+ folio->mapping = NULL;
+ /* Leave page->index set: truncation lookup relies upon it */
+
xas_store(&xas, shadow);
xas_init_marks(&xas);
- folio->mapping = NULL;
- /* Leave page->index set: truncation lookup relies upon it */
mapping->nrpages -= nr;
}
--
2.25.1
next reply other threads:[~2024-03-22 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 21:04 Soma Nakata [this message]
2024-03-26 21:05 ` [PATCH] mm/filemap: set folio->mapping to NULL before xas_store() Andrew Morton
2024-03-26 22:50 ` Matthew Wilcox
2024-03-26 22:52 ` Soma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240322210455.3738-1-soma.nakata01@gmail.com \
--to=soma.nakata01@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).