From: David Hildenbrand <david@redhat.com>
To: John Hubbard <jhubbard@nvidia.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
linux-next@vger.kernel.org, akpm@linux-foundation.org,
jack@suse.cz, kirill@shutemov.name
Cc: borntraeger@de.ibm.com, aarcange@redhat.com, linux-mm@kvack.org,
frankja@linux.ibm.com, sfr@canb.auug.org.au,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2 2/2] mm/gup/writeback: add callbacks for inaccessible pages
Date: Tue, 3 Mar 2020 09:07:32 +0100 [thread overview]
Message-ID: <21c62e25-c0f8-a9d4-5501-49fd660c6c81@redhat.com> (raw)
In-Reply-To: <99903e77-7720-678e-35c5-6eb9e35e7fcb@nvidia.com>
> Your style earlier in the patch was easier on the reader, why not stay consistent
> with that (and with this file, which tends also to do this), so:
>
> if (flags & FOLL_PIN) {
> ret = arch_make_page_accessible(page);
> if (ret) {
> unpin_user_page(page);
> goto pte_unmap;
> }
> }
>
+1
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2020-03-03 8:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 0:25 [PATCH v2 0/2] add callbacks for inaccessible pages Claudio Imbrenda
2020-03-03 0:25 ` [PATCH v2 1/2] mm/gup: fixup for 9947ea2c1e608e32 "mm/gup: track FOLL_PIN pages" Claudio Imbrenda
2020-03-03 5:38 ` John Hubbard
2020-03-03 0:25 ` [PATCH v2 2/2] mm/gup/writeback: add callbacks for inaccessible pages Claudio Imbrenda
2020-03-03 7:59 ` John Hubbard
2020-03-03 8:07 ` David Hildenbrand [this message]
2020-03-03 10:41 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21c62e25-c0f8-a9d4-5501-49fd660c6c81@redhat.com \
--to=david@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=borntraeger@de.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jack@suse.cz \
--cc=jhubbard@nvidia.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).