From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50EC1C77B61 for ; Thu, 13 Apr 2023 11:57:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 858A66B0072; Thu, 13 Apr 2023 07:57:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 807716B0074; Thu, 13 Apr 2023 07:57:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CF55900002; Thu, 13 Apr 2023 07:57:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5DBFE6B0072 for ; Thu, 13 Apr 2023 07:57:33 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 274D3120224 for ; Thu, 13 Apr 2023 11:57:33 +0000 (UTC) X-FDA: 80676217986.23.B3DF443 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id AD87A12000E for ; Thu, 13 Apr 2023 11:57:28 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ixrjqeDO; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681387049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8eCLBo30JEhG/craFWy4JRpaeUSHeOPHom+9kBQBO60=; b=eQoLpLVBOAsHylzU728AwTZmLJ9t9jEGSPnw7U+IZr0Fv6FylquKKSxm7ALxzl/u0iU11w xQfSKDoaGLQaHgQR6PwBWnr8ACGfqt/FsB/dc58YAk0HuechPMZxUFBbQsoZSJsidPTns5 AUBAsBUFqsnn6HDdTiSBgm37k3ANoCM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ixrjqeDO; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681387049; a=rsa-sha256; cv=none; b=RGu6xcsimyAa4+aCY+EKYvmATcniXL/5p3QzagQZg/QTa+JyD7F3b/bQ8rKbTMEQO5lF6y hn585pIeD/j1vS2Eq8MHNT45yeDLYP0aVX0Yxflo1Y94rDC4TibSAAIL/mUEjtRckuv4F5 U2839/kjXURrFLEFLpNZrKXLyG6m5XQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681387047; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8eCLBo30JEhG/craFWy4JRpaeUSHeOPHom+9kBQBO60=; b=ixrjqeDOffDmyD2x++GXX8dH81MZbQIPSXtciUdKgD6Dp6p0xuAYerf2/3SeRYNOMoww+Z w4xAUPJUiY6MH1elu6K/CF6io1SE1bY5j2V4MfmVx3+0ktCc/sUu6Ki3TuYwA7FOxA14wN 8XYMs5Rokxa/BGAdU/2L9X34dvKwboc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-1aohI2w0PGelpvT5LG_j4g-1; Thu, 13 Apr 2023 07:57:26 -0400 X-MC-Unique: 1aohI2w0PGelpvT5LG_j4g-1 Received: by mail-wr1-f72.google.com with SMTP id v16-20020adfa1d0000000b002f64d93cfd4so215062wrv.14 for ; Thu, 13 Apr 2023 04:57:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681387045; x=1683979045; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8eCLBo30JEhG/craFWy4JRpaeUSHeOPHom+9kBQBO60=; b=cD9ipFbS8+jMPuV2Ge25HFvhxpQ5xPp7CHLetxgtDyP26ZWMxgAtFw1b22M6p9MG/U A0XWRf0jkyZ6WD7fDcWRJ/yuvnUbeXq4YRngvNr8LuF60qP0bA8+PRW0vEbpBpPv5NIN ae+ZTyItDpPKv4qDJ9YCYdwOoAIpyChs5HQZ0H/T8OI3zZqeL2NFUZ/WPZc9+ibBlg02 1Hl2bBck7zmYkB0mir+N57ZFQXAr9ddtjBW83rM8bl3jVxdqlKDz0KFcof51Q8WNzLjf dtHuuVDdXnkcFAKKd9qjqWWmgum7psb2lKBiPxZifV2MdNZw93vLGyfFf7C8LGczcQya zxjQ== X-Gm-Message-State: AAQBX9cAhBvU5BCYAq1fRWVKhFxSphz2dnFXkDzw9fU1JwYOaBT08+m8 VijLH4+TWIqsyzG5V0mIsjAz3UTiKE//52JX2s6PYz4UGKOxj/defDiEfTPDD063bCJ0zLrVBos VPyihluZ/c8REyrT1D4Y= X-Received: by 2002:a5d:6a89:0:b0:2f5:ce19:8ec2 with SMTP id s9-20020a5d6a89000000b002f5ce198ec2mr1275465wru.11.1681387045352; Thu, 13 Apr 2023 04:57:25 -0700 (PDT) X-Google-Smtp-Source: AKy350ZpwSb/zonNIwuuMN1BAYppgjZ1EYfUFCmirswM12PndB9SkMrFo2O02MM3m2XE/i7/54vVaw== X-Received: by 2002:a5d:6a89:0:b0:2f5:ce19:8ec2 with SMTP id s9-20020a5d6a89000000b002f5ce198ec2mr1275453wru.11.1681387045019; Thu, 13 Apr 2023 04:57:25 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id b16-20020a5d45d0000000b002ca864b807csm1185678wrs.0.2023.04.13.04.57.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Apr 2023 04:57:24 -0700 (PDT) Message-ID: <22830f0d-720e-ad7d-1540-6d6681301d94@redhat.com> Date: Thu, 13 Apr 2023 13:57:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] mm: huge_memory: Replace obsolete memalign() with posix_memalign() To: Deming Wang , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230413011719.4355-1-wangdeming@inspur.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230413011719.4355-1-wangdeming@inspur.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AD87A12000E X-Stat-Signature: 9zbsetpdeizy6akofomrny3t3h59ww1i X-Rspam-User: X-HE-Tag: 1681387048-437784 X-HE-Meta: U2FsdGVkX198JQznVmJlmfJ9t/GxvZ4MYRoz699amaRE4Pnuj6udfwdU+Jz5+05LqdQOCpXRODXvfWPjoaetEOIQo400YC2mhnVUCs9wzbDtz5LPhsiFGssHmCQhPgfL4R5n9vKWyeX53LM88YW5rLOqXP5pV4BBCU03z9NpM8ZgM5M2FY+wG5lWz4+RxPncgOcomdXScd2wqCcHNR/DvNLOxNWGG0DfZLh51cM1XzZtvX/LfDRDiNUIjl0SDntb0jXaEsjg0vORkyXJ1JfbnwAGUhVP+/EVjJ4bwBDPlpyCY7dP20u8Xw5EDIJ0c8T7+PNkzfEQ2TD+UGBNJ6PBK23yFrupLMNT4r7M8lYd4vvOf7UWhgCP1zDqquyv9YDi6l7aYQqrm+UDfueGtfgw9lYdbqxQKiqY5k2/2q/N0JS6wEVr8YsuwkcbZKdcDYlD8MEydG5fVBGViIVcu4yP2KyiuiH8gHcVvEKcvftHEwGItDuP4w0NJ2P8Z6xIsIvAxYto0G5YSDC63W5n0/vrrDIxrTqfBnYk/jBgUkybBsEo6R4e/JRuWEty5iif2rCDYOa3x9NMF0COb+FwQ2dMDoy3ZQwP95GPMWH42caKQool7/gIn1qyMT6ciGnOAdZRcewyytuqwcuXiktTXb7tKbwtgxX8pm2ZHbS+Eq/gZ+R9ZTwXLb/mR9BMsUY83sa36YzoxBrpr2xQSCc1/VSSPkKqtOIEP4F8bBaUlr4Y1Yas7CVdN534kx9WF2MzxDuSpZDWkF8ypDaar6rkiKID5u91xFfj0yVb8d9lDcMc1JAa/9zBUtjfZ/0mKmk+oVPBK6UvFJ0xacdC8MKF4WtHiHxrqD/f4dpka98U3432M2XYBWo6azzUG81OJaHKdvhCz7MS6X0VVXrKWotShsdNL23+lTQ6YpgqjbUgxOP5IurktOStSY9PCwIaeW1MgMXip/vt65vN2b8A1YIVn12 wteJY5Z/ iPyDZg1q7uh/PNnp+FRl9F8Y4oajPkysnicFmakxQDmioy2e4McPQegX1qFH/o88HITGggepKh6fuTNyu7lX5XaW6M5TN6SM3LcyiRSPpu9jA9YtHC8g10w40RF28yk/NIwZgw8A8OdF8NbnHb47dbEBNuW/HBTgKJ2lWZyzsfGjmVBKemWFXWqddfntEvoB7eWRB2n8QRnE28eM0mTVjIoDRZzJcNryJue933EkENKjMadiqiRWeMjjedtgP+vlocWmoxPn7rgic3xLy0g+fCmVYhwii98NDa1RTIxy4HmceycI29QLgMbtSd1CyiEgxrtbzhEMR3m19I0/EZQMCDMo7HBs6UXPMlG54HLblEhM2Y0Zxd/a6Z/Nygp/7x6rws8AEKfVjb4+mmAc/c+iSNIwxkNcLwmMdVvWpqGTYaiEaqAK0hrM3HoD20XaETQhjhy3Rwh9wOwrqaYhoM7gzOgKV7vUVtseTXh42e7Ie3tW9d3mbonZj6U6m7fhrLE9AZRB3dEEtXPIylPsc8uuiRQY9+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.04.23 03:17, Deming Wang wrote: > memalign() is obsolete according to its manpage. > > Replace memalign() with posix_memalign() > > As a pointer is passed into posix_memalign(), initialize *one_page > to NULL to silence a warning about the function's return value being > used as uninitialized (which is not valid anyway because the error > is properly checked before one_page is returned). ^ I'm getting tired of pointing out the same thing. Please collect similar patches and send them as a series; and stop copy-pasting the same thing into all of the similar patches you send. Last but not least, tag you patches accordingly: "selftests/mm: split_huge_page_test: ..." > > Signed-off-by: Deming Wang > --- > tools/testing/selftests/mm/split_huge_page_test.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c > index cbb5e6893cbf..94c7dffc4d7d 100644 > --- a/tools/testing/selftests/mm/split_huge_page_test.c > +++ b/tools/testing/selftests/mm/split_huge_page_test.c > @@ -96,10 +96,10 @@ void split_pmd_thp(void) > char *one_page; > size_t len = 4 * pmd_pagesize; > size_t i; > + int ret; > > - one_page = memalign(pmd_pagesize, len); > - > - if (!one_page) { > + ret = posix_memalign((void **)&one_page, pmd_pagesize, len); > + if (ret < 0) { > printf("Fail to allocate memory\n"); > exit(EXIT_FAILURE); > } -- Thanks, David / dhildenb