From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66B09C3F2CD for ; Wed, 4 Mar 2020 08:51:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1A7CA2166E for ; Wed, 4 Mar 2020 08:51:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1A7CA2166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 649A36B0003; Wed, 4 Mar 2020 03:51:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F9556B0005; Wed, 4 Mar 2020 03:51:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 535F16B0006; Wed, 4 Mar 2020 03:51:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 3CB5F6B0003 for ; Wed, 4 Mar 2020 03:51:55 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DE0FB1E07C for ; Wed, 4 Mar 2020 08:51:54 +0000 (UTC) X-FDA: 76557062148.09.paste33_84db1157fc543 X-HE-Tag: paste33_84db1157fc543 X-Filterd-Recvd-Size: 2400 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 4 Mar 2020 08:51:51 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01f04455;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---0TrctV1W_1583311905; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TrctV1W_1583311905) by smtp.aliyun-inc.com(127.0.0.1); Wed, 04 Mar 2020 16:51:45 +0800 Subject: Re: [PATCH v9 06/20] mm/thp: narrow lru locking To: "Kirill A. Shutemov" Cc: cgroups@vger.kernel.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, Andrea Arcangeli , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1583146830-169516-1-git-send-email-alex.shi@linux.alibaba.com> <1583146830-169516-7-git-send-email-alex.shi@linux.alibaba.com> <20200304080248.wuj3vqlz46ehhptg@box> From: Alex Shi Message-ID: <23cc4433-fe81-ec31-9281-3c9e8df5643b@linux.alibaba.com> Date: Wed, 4 Mar 2020 16:51:45 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200304080248.wuj3vqlz46ehhptg@box> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =D4=DA 2020/3/4 =CF=C2=CE=E74:02, Kirill A. Shutemov =D0=B4=B5=C0: > On Mon, Mar 02, 2020 at 07:00:16PM +0800, Alex Shi wrote: >> @@ -2564,6 +2565,9 @@ static void __split_huge_page(struct page *page,= struct list_head *list, >> xa_lock(&swap_cache->i_pages); >> } >> =20 >> + /* Lru list would be changed, don't care head's LRU bit. */ >> + spin_lock_irqsave(&pgdat->lru_lock, flags); >> + >> for (i =3D HPAGE_PMD_NR - 1; i >=3D 1; i--) { >> __split_huge_page_tail(head, i, lruvec, list); >> /* Some pages can be beyond i_size: drop them from page cache */ >=20 > You change locking order WRT i_pages lock. Is it safe? >=20 Thanks Kirill, I think so. and lock_dep/proving has no complain. Any problem addressed? Alex