From: Miaohe Lin <linmiaohe@huawei.com>
To: Naoya Horiguchi <nao.horiguchi@gmail.com>, <linux-mm@kvack.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
David Hildenbrand <david@redhat.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Liu Shixin <liushixin2@huawei.com>,
Yang Shi <shy828301@gmail.com>,
Oscar Salvador <osalvador@suse.de>,
Muchun Song <songmuchun@bytedance.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/9] mm, hwpoison: make unpoison aware of raw error info in hwpoisoned hugepage
Date: Mon, 27 Jun 2022 19:48:46 +0800 [thread overview]
Message-ID: <2b6a6b19-c930-6d27-5929-363802e42596@huawei.com> (raw)
In-Reply-To: <ea1d17d8-89df-04b7-29e8-0da53dbd3312@huawei.com>
On 2022/6/27 16:32, Miaohe Lin wrote:
> On 2022/6/24 7:51, Naoya Horiguchi wrote:
>> From: Naoya Horiguchi <naoya.horiguchi@nec.com>
>>
>> Raw error info list needs to be removed when hwpoisoned hugetlb is
>> unpoisioned. And unpoison handler needs to know how many errors there
>> are in the target hugepage. So add them.
>>
>> Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
>
> snip
>
>> @@ -2255,7 +2275,7 @@ int unpoison_memory(unsigned long pfn)
>> unlock_mutex:
>> mutex_unlock(&mf_mutex);
>> if (!ret || freeit) {
>> - num_poisoned_pages_dec();
>> + num_poisoned_pages_sub(count);
>
> IIUC, num_poisoned_pages will only be incremented once for hugetlb page. If many
> subpages are hwpoisoned, they will reach the "else if (res == -EHWPOISON)" path
> in try_memory_failure_hugetlb and thus num_poisoned_pages_inc is ignored. Maybe
> that should be changed so subpages can contribute to the num_poisoned_pages
> or should we just do num_poisoned_pages_dec here? Or am I miss something?
Sorry. I re-read patch 4/9 and I found hugetlb_set_page_hwpoison will increment the
num_poisoned_pages for each subpages. Please ignore this question.
>
> Thanks!
>
>> unpoison_pr_info("Unpoison: Software-unpoisoned page %#lx\n",
>> page_to_pfn(p), &unpoison_rs);
>> }
>>
>
next prev parent reply other threads:[~2022-06-27 11:48 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 23:51 [PATCH v2 0/9] mm, hwpoison: enable 1GB hugepage support (v2) Naoya Horiguchi
2022-06-23 23:51 ` [PATCH v2 1/9] mm/hugetlb: remove checking hstate_is_gigantic() in return_unused_surplus_pages() Naoya Horiguchi
2022-06-24 2:25 ` Miaohe Lin
2022-06-24 8:03 ` Muchun Song
2022-06-24 8:15 ` Miaohe Lin
2022-06-24 8:34 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-24 19:11 ` Mike Kravetz
2022-06-27 6:02 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-27 17:25 ` Mike Kravetz
2022-06-28 3:01 ` Miaohe Lin
2022-06-28 8:38 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-30 2:27 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-23 23:51 ` [PATCH v2 2/9] mm/hugetlb: separate path for hwpoison entry in copy_hugetlb_page_range() Naoya Horiguchi
2022-06-24 9:23 ` Miaohe Lin
2022-06-27 6:06 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-24 20:57 ` Mike Kravetz
2022-06-27 6:48 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-27 7:57 ` Muchun Song
2022-06-23 23:51 ` [PATCH v2 3/9] mm/hugetlb: make pud_huge() and huge_pud() aware of non-present pud entry Naoya Horiguchi
2022-06-24 8:40 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-25 0:02 ` Mike Kravetz
2022-06-27 7:07 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-25 9:42 ` Miaohe Lin
2022-06-27 7:24 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-23 23:51 ` [PATCH v2 4/9] mm, hwpoison, hugetlb: support saving mechanism of raw error pages Naoya Horiguchi
2022-06-27 3:16 ` Miaohe Lin
2022-06-27 7:56 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-27 9:26 ` Muchun Song
2022-06-28 2:41 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-28 6:26 ` Muchun Song
2022-06-28 7:51 ` Muchun Song
2022-06-28 8:17 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-28 10:37 ` Muchun Song
2022-06-23 23:51 ` [PATCH v2 5/9] mm, hwpoison: make unpoison aware of raw error info in hwpoisoned hugepage Naoya Horiguchi
2022-06-27 8:32 ` Miaohe Lin
2022-06-27 11:48 ` Miaohe Lin [this message]
2022-06-23 23:51 ` [PATCH v2 6/9] mm, hwpoison: set PG_hwpoison for busy hugetlb pages Naoya Horiguchi
2022-06-27 8:39 ` Miaohe Lin
2022-06-23 23:51 ` [PATCH v2 7/9] mm, hwpoison: make __page_handle_poison returns int Naoya Horiguchi
2022-06-27 9:02 ` Miaohe Lin
2022-06-28 6:02 ` HORIGUCHI NAOYA(堀口 直也)
2022-06-23 23:51 ` [PATCH v2 8/9] mm, hwpoison: skip raw hwpoison page in freeing 1GB hugepage Naoya Horiguchi
2022-06-27 12:24 ` Miaohe Lin
2022-06-23 23:51 ` [PATCH v2 9/9] mm, hwpoison: enable memory error handling on " Naoya Horiguchi
2022-06-28 2:06 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b6a6b19-c930-6d27-5929-363802e42596@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liushixin2@huawei.com \
--cc=mike.kravetz@oracle.com \
--cc=nao.horiguchi@gmail.com \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=shy828301@gmail.com \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).