From: Vlastimil Babka <vbabka@suse.cz>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Thomas Gleixner <tglx@linutronix.de>,
Luis Chamberlain <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
Mel Gorman <mgorman@techsingularity.net>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH 1/2] mm/compaction: Really limit compact_unevictable_allowed to 0…1
Date: Wed, 4 Mar 2020 09:12:57 +0100 [thread overview]
Message-ID: <2b790b60-72a7-54b9-aa13-42a160c9aa99@suse.cz> (raw)
In-Reply-To: <20200303202054.gsosv7fsx2ma3cic@linutronix.de>
On 3/3/20 9:20 PM, Sebastian Andrzej Siewior wrote:
> The proc file `compact_unevictable_allowed' should allow 0 and 1 only,
> the `extra*' attribues have been set properly but without
> proc_dointvec_minmax() as the `proc_handler' the limit will not be
> enforced.
>
> Use proc_dointvec_minmax() as the `proc_handler' to enfoce the valid
> specified range.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> kernel/sysctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index ad5b88a53c5a8..982203101f961 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -1484,7 +1484,7 @@ static struct ctl_table vm_table[] = {
> .data = &sysctl_compact_unevictable_allowed,
> .maxlen = sizeof(int),
> .mode = 0644,
> - .proc_handler = proc_dointvec,
> + .proc_handler = proc_dointvec_minmax,
> .extra1 = SYSCTL_ZERO,
> .extra2 = SYSCTL_ONE,
> },
>
prev parent reply other threads:[~2020-03-04 8:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 16:10 [PATCH] mm/compaction: Disable compact_unevictable_allowed on RT Sebastian Andrzej Siewior
2020-01-15 22:04 ` Vlastimil Babka
2020-01-16 10:22 ` Sebastian Andrzej Siewior
2020-03-02 17:35 ` [PATCH v2] " Sebastian Andrzej Siewior
2020-03-02 21:25 ` Andrew Morton
2020-03-03 17:59 ` Sebastian Andrzej Siewior
2020-03-03 20:20 ` [PATCH 1/2] =?UTF-8?q?mm/compaction:=20Really=20limit=20compact?= =?UTF-8?q?=5Funevictable=5Fallowed=20to=200=E2=80=A61?= Sebastian Andrzej Siewior
2020-03-03 20:22 ` [PATCH 2/2 v3] mm/compaction: Disable compact_unevictable_allowed on RT Sebastian Andrzej Siewior
2020-03-03 23:56 ` Andrew Morton
2020-03-04 8:19 ` Vlastimil Babka
2020-03-04 9:27 ` Sebastian Andrzej Siewior
2020-03-19 16:39 ` [PATCH 2/2 v4] " Sebastian Andrzej Siewior
2020-03-19 16:49 ` Vlastimil Babka
2020-03-19 16:55 ` [PATCH 2/2 v5] " Sebastian Andrzej Siewior
2020-03-04 8:18 ` [PATCH 2/2 v3] " Vlastimil Babka
2020-03-04 9:25 ` Sebastian Andrzej Siewior
2020-03-04 9:11 ` Mel Gorman
2020-03-04 8:12 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b790b60-72a7-54b9-aa13-42a160c9aa99@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=keescook@chromium.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=tglx@linutronix.de \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).