From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>,
zhong jiang <zhongjiang@huawei.com>
Cc: osalvador@suse.de, khandual@linux.vnet.ibm.com, mhocko@suse.com,
mgorman@techsingularity.net, aarcange@redhat.com,
rcampbell@nvidia.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mempolicy: Fix an incorrect rebind node in mpol_rebind_nodemask
Date: Mon, 27 May 2019 14:23:31 +0200 [thread overview]
Message-ID: <2ff829ea-1d74-9d4b-8501-e9c2ebdc36ef@suse.cz> (raw)
In-Reply-To: <20190525112851.ee196bcbbc33bf9e0d869236@linux-foundation.org>
On 5/25/19 8:28 PM, Andrew Morton wrote:
> (Cc Vlastimil)
Oh dear, 2 years and I forgot all the details about how this works.
> On Sat, 25 May 2019 15:07:23 +0800 zhong jiang <zhongjiang@huawei.com> wrote:
>
>> We bind an different node to different vma, Unluckily,
>> it will bind different vma to same node by checking the /proc/pid/numa_maps.
>> Commit 213980c0f23b ("mm, mempolicy: simplify rebinding mempolicies when updating cpusets")
>> has introduced the issue. when we change memory policy by seting cpuset.mems,
>> A process will rebind the specified policy more than one times.
>> if the cpuset_mems_allowed is not equal to user specified nodes. hence the issue will trigger.
>> Maybe result in the out of memory which allocating memory from same node.
I have a hard time understanding what the problem is. Could you please
write it as a (pseudo) reproducer? I.e. an example of the process/admin
mempolicy/cpuset actions that have some wrong observed results vs the
correct expected result.
>> --- a/mm/mempolicy.c
>> +++ b/mm/mempolicy.c
>> @@ -345,7 +345,7 @@ static void mpol_rebind_nodemask(struct mempolicy *pol, const nodemask_t *nodes)
>> else {
>> nodes_remap(tmp, pol->v.nodes,pol->w.cpuset_mems_allowed,
>> *nodes);
>> - pol->w.cpuset_mems_allowed = tmp;
>> + pol->w.cpuset_mems_allowed = *nodes;
Looks like a mechanical error on my side when removing the code for
step1+step2 rebinding. Before my commit there was
pol->w.cpuset_mems_allowed = step ? tmp : *nodes;
Since 'step' was removed and thus 0, I should have used *nodes indeed.
Thanks for catching that.
>> }
>>
>> if (nodes_empty(tmp))
>
> hm, I'm not surprised the code broke. What the heck is going on in
> there? It used to have a perfunctory comment, but Vlastimil deleted
> it.
Yeah the comment was specific for the case that was being removed.
> Could someone please propose a comment for the above code block
> explaining why we're doing what we do?
I'll have to relearn this first...
next prev parent reply other threads:[~2019-05-27 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 7:07 [PATCH] mm/mempolicy: Fix an incorrect rebind node in mpol_rebind_nodemask zhong jiang
2019-05-25 18:28 ` Andrew Morton
2019-05-27 12:23 ` Vlastimil Babka [this message]
2019-05-27 13:58 ` zhong jiang
2019-06-27 3:57 ` Andrew Morton
2019-06-27 7:47 ` Vlastimil Babka
2019-06-27 9:59 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ff829ea-1d74-9d4b-8501-e9c2ebdc36ef@suse.cz \
--to=vbabka@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rcampbell@nvidia.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).