From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE57AC7619A for ; Wed, 12 Apr 2023 18:41:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D8936B0074; Wed, 12 Apr 2023 14:41:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 061E16B0075; Wed, 12 Apr 2023 14:41:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1E1E900002; Wed, 12 Apr 2023 14:41:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CEABA6B0074 for ; Wed, 12 Apr 2023 14:41:25 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 99FDEAAECB for ; Wed, 12 Apr 2023 18:41:25 +0000 (UTC) X-FDA: 80673606930.12.D86D6DD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id DC1E11C0011 for ; Wed, 12 Apr 2023 18:41:22 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FEX48WCl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681324883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R3VT9Kq9nmC5BmqMQE6Z+3ROnKmsf5SjqX4tT+cT2cg=; b=Ktq6Gqcc0JYiiq9ldEorAMGQXW9bVoICxw0zPiTknCUaJQ5AQlX5Jh4p4EO8b9SsmsrU2g OuBs+sFBErOQUFsq3qpg1WJ3HEAlzGtO31UDVfpxcYF3lYr1cie85ynxW5TUegTKQX9be7 6LKthiy+R/2CGrojWI5QVx85MyNoM44= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FEX48WCl; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681324883; a=rsa-sha256; cv=none; b=EA0sL+QVJYa59ph4oUfjbeS6J1EM78sn0DmNWke09tKQ6dferJikrt5shQBmBtC9GYX174 mZJ4J8WWh0HdXxF9bXC9OKpcb80BejBVtDN1YW4BZ4SLopoc1RyHGE7g3hHuaAF6vTiA5t f0W7LX47Ob5uPcJDQLk0JvLU3Wd+GdE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681324882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R3VT9Kq9nmC5BmqMQE6Z+3ROnKmsf5SjqX4tT+cT2cg=; b=FEX48WCl8jnzMmL81kAHs/Fp6koyZgxMeLiL8o+78TD3D1tpRKJvuQAyuBeNSs/aZk8HYp OG7b6FjS4D54nIMnLnKAmzwaDK0iZvq/5PjH6XbohMII9COy/X0hE3777Wv3I0KI7PyO8/ uYTBlGRMxc15MkA5RaplKlq0XA9XO6Q= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-tbCB1_wxOAG1E493aNbl8Q-1; Wed, 12 Apr 2023 14:41:20 -0400 X-MC-Unique: tbCB1_wxOAG1E493aNbl8Q-1 Received: by mail-wm1-f71.google.com with SMTP id n11-20020a05600c3b8b00b003f04739b77aso16120234wms.9 for ; Wed, 12 Apr 2023 11:41:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681324878; x=1683916878; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R3VT9Kq9nmC5BmqMQE6Z+3ROnKmsf5SjqX4tT+cT2cg=; b=MJsyMkfliFbarxH/JLoAsOfZweTEH8ib0/31L6k8fYAwr4BpPYV/er9Mctta9BmknP WmEbIU91UQ+sDpg9aWtbQ4cOhtcrojZmiQJ86O7YV4OvcXcTJ2PlyjK5aeoBXvC8SuAb xFB2Hdjgt66pRkZ/syjcmdXNK4jNMOj9CCLJpxyxC32hvvm1MVeKBE2HOeEAXl/5Kjp3 +eYMk580UdWkumIO08Yww/zJHCewhmtdmLRF7FDywS7ACN3SdFkKM9lCi/d5Nni8yLLD kMpjp9zzJlkoB4w0x2+WFosvXkNMWEQ+jWN2fku+5Xgo/Jp81X/Rme8wreiW4sOQYs5N QA4g== X-Gm-Message-State: AAQBX9dbYETKqeZam36kLVn4tBnIexIb8yFfYinUQ711QNRfFS6IWaa6 Nj5nYxj6FKczC67VAxkYRb2/ZW5okhgJgxtFiPA8IYLddQAwt5CFHyL4u1dEHgIvGeFrTwKJ73y fPxZ1sot2wGc= X-Received: by 2002:a5d:6b85:0:b0:2f0:2e3a:cc00 with SMTP id n5-20020a5d6b85000000b002f02e3acc00mr7416016wrx.17.1681324878292; Wed, 12 Apr 2023 11:41:18 -0700 (PDT) X-Google-Smtp-Source: AKy350b/QgGGwNJsH1wFuhM7bfB/1noybwNgk32aStiwxtIwKDydODiL5wj6bsintL3P/ESaIIORFg== X-Received: by 2002:a5d:6b85:0:b0:2f0:2e3a:cc00 with SMTP id n5-20020a5d6b85000000b002f02e3acc00mr7415997wrx.17.1681324877919; Wed, 12 Apr 2023 11:41:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4b00:c6fa:b613:dbdc:ab? (p200300cbc7024b00c6fab613dbdc00ab.dip0.t-ipconnect.de. [2003:cb:c702:4b00:c6fa:b613:dbdc:ab]) by smtp.gmail.com with ESMTPSA id k18-20020adff292000000b002f013fb708fsm502627wro.4.2023.04.12.11.41.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 11:41:17 -0700 (PDT) Message-ID: <30b948fe-7983-39dd-9565-9f92ffd9101b@redhat.com> Date: Wed, 12 Apr 2023 20:41:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v6 1/3] mm: add new api to enable ksm per process To: Stefan Roesch Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, willy@infradead.org, Bagas Sanjaya References: <20230412031648.2206875-1-shr@devkernel.io> <20230412031648.2206875-2-shr@devkernel.io> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DC1E11C0011 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: xjygbyxmyjen3gek19tkmbpy7hpsdq5d X-HE-Tag: 1681324882-594691 X-HE-Meta: U2FsdGVkX19aX+tgOSe5czyLcbwg2omhaHF8XG+6rSyORx8GOTYLNGxPvCAi1dzym3H/MODlXPgnKDY4Kqjwj9mQIulmlfs6GQkvZyL+6c5ERdsl9PGe1Loi70MZ6iKHmV73qcxFVgCk02WHayzPRqfF5ZssmqatX2+Zawd+0rf0YItNhUWDFM9U6bDZf1sWgy6vzwfi3REXVcoEYnFEe/CUCC1G20Ls/c4evv7B6IjXs7KWhYdndHHbs0GVirZnvree9ekDX5LvrNFNZadALz5AEvxSvLnYFOl5K0L6uyAPPsPTI7jQpF4ebrjCF3fLWgjfIoloWfqwyYjQX4+gMi6FD+b0H+Y1PC9qScLy+um2Y8/iAR2jS23qokuw7+nwIjlsihSzg4kuwCvWZ8KwxHk+hluNSM5meVat6cWdfPF2BDXZH2eCechRjc974FYTCXmQzdooJXB8X6wXVpVMksYdGGjAhTzFURLciTVGsyb7q+62uBOf53GtSJBesEZxA0vjyOP4rWi6ZIKDV3+KI/gYjbwGMSNR83ghnEYq1N0XVoYLmXzUn+RhcWm0hWwUWXxhV0FBz3uRjckdrp6Jvet7SIcthrdgcCwx2ISYlFBxrZjhthzZJ0+MHbriGclSD62ecMhX7iLWzZev8JKExI6zUGMbu5qtD1bN9uDvsjo6b2NYkZTKw/fXE3SkPDy2fkzeEIxmhHvBPUi4K/MU//nbonVJVbvocJqLO+ha8f8luqis8UaN7IdTmSMystDPzP0ppbxmLjl/ZUTdXjG/wn5I0Yk07vKXQYaxNrdh/TaZBj7f9d5OTkRjdZhd+fEwY1FCpJ1KaFXQjTw4sRZmDvnY5JwcryGIlYoxvQWrxTBuGE4ipQpY+M5H6Pkqs0toT8urWRg9SmUhhEQPxu8R6HhqWJgCqCWG8NcT1nS6fF7reCNULQKsrFjNOO8uS8jle3fyP6pBqT+YbnHJ111 +7dbRbId FTXP4ky41RgS64x9/ZiZa//HebWpqf2bE8RYgpXRZ/n3+WBYCioONgAkqwFUNTDkETnN//d5Mje0Rq2VMRtfk4BbVoiI5pkoIJeUkRbVtTl0iGAHAFSZLbZGb87e7dFO2ciywPEHw1ykXDseql2Vr/DYpDRW2RMjXuIfnUrtaBdUmKrU6V+66qScxiZCWIHP3R5RKJnlcTUU0yas+uFtle+VUDnLoeoCqn+DsqvVY9jMktkMMcHPQvfF0YpU1QDh7XVwLQcvj2JtMWYCgYCAGLU4z1CpQ+3JdOBQXJdavRBrYsbkxDGyiKuF7HpymAeb0XSvRjP+XxndVuAwFMZ8w02cvvyqZib0wdGTBQQIlROaMYsJGke008m+WLNdw3ryK0rgB+wIg1GzCeahH9zjRtnjYUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: [...] > That will work. >> work? IOW, not exporting ksm_add_mm() and not passing a flag to __ksm_enter() -- >> it would simply set MMF_VM_MERGEABLE ? >> > > ksm_add_mm() is also used in prctl (kernel/sys.c). Do you want to make a > similar change there? Yes. >>> + * >>> + * @vma: Pointer to vma >>> + */ >>> +void ksm_add_vma(struct vm_area_struct *vma) >>> +{ >>> + struct mm_struct *mm = vma->vm_mm; >>> + >>> + if (test_bit(MMF_VM_MERGE_ANY, &mm->flags)) >>> + __ksm_add_vma(vma); >>> +} >>> + >>> +/** >>> + * ksm_add_vmas - Mark all vma's of a process as mergeable >>> + * >>> + * @mm: Pointer to mm >>> + */ >>> +void ksm_add_vmas(struct mm_struct *mm) >> >> I'd suggest calling this >> > I guess you forgot your name suggestion? Yeah, I reconsidered because the first idea I had was not particularly good. Maybe ksm_enable_for_all_vmas() But not so sure. If you think the "add" terminology is a good fit, keep it like that. Thanks for bearing with me :) -- Thanks, David / dhildenb