From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D95C77B6E for ; Wed, 12 Apr 2023 07:58:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F12186B0074; Wed, 12 Apr 2023 03:58:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC2A8900003; Wed, 12 Apr 2023 03:58:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8A0B900002; Wed, 12 Apr 2023 03:58:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CA90D6B0074 for ; Wed, 12 Apr 2023 03:58:22 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 844B31A102D for ; Wed, 12 Apr 2023 07:58:22 +0000 (UTC) X-FDA: 80671986444.30.2FFB47F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 43E5C14000C for ; Wed, 12 Apr 2023 07:58:19 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZNYsyT5t; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681286300; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zjQ1TJWbIPwilwTgfQ/RtAH10ukmLWPiORRxbKkLh3A=; b=ooc6Kt0SnNxYvNOT1ximE6xhxXA1rcdeORGvDp/1+2rCYFQyyHCo2jVfRVobyFtR8inaoy 3qSfuiO8Djnlvp3FkWnvhnAn6WtQ8wqs345yOjp/uLRPPch8rkuHET4Je4pWO3kHosdZ5W Xpzh0besOHARIgPOgBqD73FvamCZv6s= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ZNYsyT5t; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681286300; a=rsa-sha256; cv=none; b=SvFfyN74kRWaBJbNcqQw2P4Y2dxFcM/Mxdvgl0/qPGY2Dk8gq7yS8W9tIoZaSqlEkxt5Ga YNKmyyb141s2TNg/MfTwfFajItiwAh1hspBLo/iq4WvJBbweNHFGHXGhDL/yNO1LImK62P 0W+QeQ7W4Ok03T0ET2Dg1SfPX+ktHZg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681286298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zjQ1TJWbIPwilwTgfQ/RtAH10ukmLWPiORRxbKkLh3A=; b=ZNYsyT5tD5ciNAfytDiJZNeFoF4uDLDeO/FFvlCB9m6y9cKY/fXNfAGdQvoSDdbBVdgcOn caz9LFoJhk/quxZbFEqDZtlCFzUb2f09HLet05CFBubRbJszPndCeZqFOM8S1zOknNnygG Sk1/pLnxREBB6s0CkSH0YEo6dXqBd3M= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-yD1vFV-NOeSLH3y4DixuCw-1; Wed, 12 Apr 2023 03:58:17 -0400 X-MC-Unique: yD1vFV-NOeSLH3y4DixuCw-1 Received: by mail-wr1-f69.google.com with SMTP id j15-20020adfb30f000000b002d34203df59so1542093wrd.9 for ; Wed, 12 Apr 2023 00:58:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681286296; x=1683878296; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zjQ1TJWbIPwilwTgfQ/RtAH10ukmLWPiORRxbKkLh3A=; b=E9E+lXMWj+AkQlsnyQvr/+3CYq84dSnUVbZZ5z8RoXjtBCbX5DScGlFafcgIowqYsG vSWglxbjwB2E66RkX1VYpKuSq0ORXSexG9/PA0iJcPP/iK/zegrXtY6VtAe+0N4CKRLg nNxzAHOuTt1SnnYlFKWHh1CW9OoiQUQXPKcNgqJ9JuqvBpBvym2TIIIZriITUaOYuZWG bThTsZSv+Z/j1cwXdsp5Qvab94KMzCdb/CQBsRkvQ4oJLJ3jRDfZrnaCmGGQPiKc7RKE E+o5+A478JmhUl3flzq8mU3f5SRWh5UHtuDZGXKfOGPPj30MV45J2ek9sVKguLPovlro hCGw== X-Gm-Message-State: AAQBX9dEvfmDYKhjJ+woe32zm+nftMzFOOV4CTAwy+Exk+fdlmtV+ST0 cJaSwWOkAf6+KGVg89FazObVByoUpwuI+sa+uJ5UntkS1DYMK8IKiiKOpVE0NFxs4Iepytt5XNu d4M6U8IZRDxg= X-Received: by 2002:adf:f28f:0:b0:2d1:9c50:5746 with SMTP id k15-20020adff28f000000b002d19c505746mr3807988wro.12.1681286296161; Wed, 12 Apr 2023 00:58:16 -0700 (PDT) X-Google-Smtp-Source: AKy350a8RtnbnqlJPtjhTYzbkGi+1dUdGHSmBOkt5INe/PdMi75idUMdVkOgACCGhJCtvZtIy+ZIYw== X-Received: by 2002:adf:f28f:0:b0:2d1:9c50:5746 with SMTP id k15-20020adff28f000000b002d19c505746mr3807980wro.12.1681286295853; Wed, 12 Apr 2023 00:58:15 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4b00:c6fa:b613:dbdc:ab? (p200300cbc7024b00c6fab613dbdc00ab.dip0.t-ipconnect.de. [2003:cb:c702:4b00:c6fa:b613:dbdc:ab]) by smtp.gmail.com with ESMTPSA id a15-20020a5d4d4f000000b002cfe685bfd6sm16548101wru.108.2023.04.12.00.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Apr 2023 00:58:15 -0700 (PDT) Message-ID: <34202ae5-efee-9345-c3de-544304d1ebb4@redhat.com> Date: Wed, 12 Apr 2023 09:58:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH RESEND] mm/vmscan: simplify shrink_node() To: Haifeng Xu , akpm@linux-foundation.org Cc: willy@infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230411061757.12041-1-haifeng.xu@shopee.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230411061757.12041-1-haifeng.xu@shopee.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 43E5C14000C X-Stat-Signature: 3o8jnhc5r91ibke7a5ge5rgze8z3agui X-HE-Tag: 1681286299-482316 X-HE-Meta: U2FsdGVkX18dV8ZmwoUl1M1QdiZE/1VqadVvHdIi6+WGcmKvsOJnDpO1uA3umSxpL7mFDxjbCKheUv+Cc9my3fPdwWJBwGK1YgUUoSFUNKCYRZX1+4l/t41/kVJSlEmpK8FbtinyLVdHdxUHQtCfoJmytEAMjtfdBpZZxUCt5JPxVXe+LRC02wLAfjJzuTdKBmL0w8FO3hfPlHGJ1ainfmBXdleGmqraPbeIHw1I/68r0SVv4MK2bze2RoymtM5JwU2TbkH3ll4XsITC+OK02V4IyfXFmUyC/yW5Vqn3wrgs3cyuQwoynViKx7bD/LXgrvZHbe5eyTqsUmMyKkJJCxvCBveAuSHjLHV2lO87WqkTm1oIv5g6UN+rc9PLn5YEEOpVC+Vm3jZW5ntPGzbnjvJRytZxI2BUpYqeZasHU0uAd634C3Y68/db7is1ruwwCaszePhmZl4OM2YlkCM3GE0hoIZ86jp1JCKZouUHveIwS9ryhl5yEf9NcG/a81PXfb9BghswybWNozUA8bJrX5C3Qcx0f46FKBHlcTzK7X8f6nE1OMwq/yjs9PonczuPSWBqFhgimGkka++akI0KFcc4yhOgLujOEBp3VgVy1JfNkuYoY7DHnm181PNWx6Mn0Fi9TkLmVLcwpz0B2wW3lD9lt0133fQs+PG7qWfxEO971ueVs4bBFw9Fjs5jH9GbZBx0yHRW37zOxSzGZLfip04dEkpynlE1pEBdq/NXyvwSx5I/3MpAUJbovbyFIa3bsrX6W4v7jiiuy6rEWV2FD4mRe0CEMr/LiMchgjy/kzvvB6zkVvhzq3xoUtLymA/0JZTwi6qebUExmIlcFy1PEUYIZaT1A0dsvcsLDOE6FF4CvGNTK/TlTRm3cyejVn/5aENRSERxUufApuprfyKivCU5CO9WyHUnZS6c2WTT5hHUDjgL4oeSiRTBj749cOFr/gSOGmPkk2nruW9fS7B YWzsv9pT tYDV5lyz+t04AH8LD/z4nTYIHJJDW3mswZAJWJKWmCxUB8U0OMtQn11Roy06fZ5PzqHLQ6oBykaDhcdn8q7zz3YE65T0v5NegJB3jAHpkTp9exo889v3Tx9LTUcDXrT+lfZPlDsUshy7V5nVeBWHFCI6ahU12PgjBlnLLli4L9YciaO8Omlj3kE78y7W1phweoGu07cPxrqRiJ5QQGIXj2ghxgxBiONcnuQryaJKzq2KfKblXvnh/WQqk/Rscaau69qPCN4JDD69lIHUZykutHx7OlCYZAfHuVttms2gtgIX93OYLxVAuEM97/JDoB3SNYW4VPP6wkaCHWGPFnALLAng75cByoD7X3iIMWXfaA0qen0sNM9BzDmQCc48rkY7LfzF9rL33QNBzefsDc/fQ/WhZiRThSfoMLOo2jocYOR5y3MV2baK1pCIUA5HgsB/fZc3qGpHuBTOUNE6h5EtBJZlZkgtmAVcBKyxksC7NweSDZ5+lN8xWmny65HgwAH3QdoB3ny7ETeJGdxsH+9SH35zk+Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.04.23 08:17, Haifeng Xu wrote: > The difference between sc->nr_reclaimed and nr_reclaimed is computed > three times. Introduce a new variable to record the value, so it only > needs to be computed once. > > Signed-off-by: Haifeng Xu > --- Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb