From: John Hubbard <jhubbard@nvidia.com>
To: Ira Weiny <ira.weiny@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
"Ilya Dryomov" <idryomov@gmail.com>, Jens Axboe <axboe@kernel.dk>,
<linux-xfs@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-block@vger.kernel.org>, <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast()
Date: Mon, 31 Aug 2020 12:09:12 -0700 [thread overview]
Message-ID: <35f751d4-bae4-e91e-d5f1-ddc38e2091ba@nvidia.com> (raw)
In-Reply-To: <20200831165222.GD1422350@iweiny-DESK2.sc.intel.com>
On 8/31/20 9:52 AM, Ira Weiny wrote:
> On Mon, Aug 31, 2020 at 12:14:39AM -0700, John Hubbard wrote:
>> @@ -1113,8 +1113,8 @@ int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter)
>> } else {
>> if (is_bvec)
>> ret = __bio_iov_bvec_add_pages(bio, iter);
>> - else
>> - ret = __bio_iov_iter_get_pages(bio, iter);
>> + else
>> + ret = __bio_iov_iter_get_pages(bio, iter);
>
> Why the white space change?
>
Yikes, that's an oversight, and...yes, it goes all the way back to v1.
Thanks for spotting it!
There is not supposed to be any diff at all, in that region of code.
I'll restore the hunk to its rightful, undisturbed state, in v4.
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2020-08-31 19:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 7:14 [PATCH v3 0/3] bio: Direct IO: convert to pin_user_pages_fast() John Hubbard
2020-08-31 7:14 ` [PATCH v3 1/3] mm/gup: introduce pin_page() John Hubbard
2020-08-31 7:14 ` [PATCH v3 2/3] iov_iter: introduce iov_iter_pin_pages*() routines John Hubbard
2020-08-31 7:14 ` [PATCH v3 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast() John Hubbard
2020-08-31 16:52 ` Ira Weiny
2020-08-31 19:09 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35f751d4-bae4-e91e-d5f1-ddc38e2091ba@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=ira.weiny@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).