linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	ltp@lists.linux.it, Li Wang <liwang@redhat.com>,
	Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
	Cyril Hrubis <chrubis@suse.cz>,
	xishi.qiuxishi@alibaba-inc.com,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS
Date: Thu, 8 Aug 2019 09:55:45 -0700	[thread overview]
Message-ID: <416ee59e-9ae8-f72d-1b26-4d3d31501330@oracle.com> (raw)
In-Reply-To: <20190808074736.GJ11812@dhcp22.suse.cz>

On 8/8/19 12:47 AM, Michal Hocko wrote:
> On Thu 08-08-19 09:46:07, Michal Hocko wrote:
>> On Wed 07-08-19 17:05:33, Mike Kravetz wrote:
>>> Li Wang discovered that LTP/move_page12 V2 sometimes triggers SIGBUS
>>> in the kernel-v5.2.3 testing.  This is caused by a race between hugetlb
>>> page migration and page fault.
<snip>
>>> Reported-by: Li Wang <liwang@redhat.com>
>>> Fixes: 290408d4a250 ("hugetlb: hugepage migration core")
>>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
>>> Tested-by: Li Wang <liwang@redhat.com>
>>
>> Acked-by: Michal Hocko <mhocko@suse.com>
> 
> Btw. is this worth marking for stable? I haven't seen it triggering
> anywhere but artificial tests. On the other hand the patch is quite
> straightforward so it shouldn't hurt in general.

I don't think this really is material for stable.  I added the tag as the
stable AI logic seems to pick up patches whether marked for stable or not.
For example, here is one I explicitly said did not need to go to stable.

https://lkml.org/lkml/2019/6/1/165

Ironic to find that commit message in a stable backport.

I'm happy to drop the Fixes tag.

Andrew, can you drop the tag?  Or would you like me to resend?
-- 
Mike Kravetz


  reply	other threads:[~2019-08-08 16:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08  0:05 [PATCH] hugetlbfs: fix hugetlb page migration/fault race causing SIGBUS Mike Kravetz
2019-08-08  3:36 ` Naoya Horiguchi
2019-08-08  7:46 ` Michal Hocko
2019-08-08  7:47   ` Michal Hocko
2019-08-08 16:55     ` Mike Kravetz [this message]
2019-08-08 18:53       ` Michal Hocko
2019-08-08 23:39         ` Andrew Morton
2019-08-09  6:46           ` Michal Hocko
2019-08-09 22:17             ` Andrew Morton
2019-08-11 23:46               ` Sasha Levin
2019-08-12  8:45                 ` Michal Hocko
2019-08-12 13:14                   ` Vlastimil Babka
2019-08-12 13:22                     ` Michal Hocko
2019-08-12 15:33                       ` Sasha Levin
2019-08-12 16:09                         ` Qian Cai
2019-08-12 21:37                         ` Andrew Morton
2019-08-13  8:43                         ` Michal Hocko
2019-08-08  2:24 裘稀石(稀石)
2019-08-08  2:44 ` Mike Kravetz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=416ee59e-9ae8-f72d-1b26-4d3d31501330@oracle.com \
    --to=mike.kravetz@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=chrubis@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    --cc=mhocko@kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=xishi.qiuxishi@alibaba-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).