From: "Alejandro Colomar (mailing lists; readonly)" <alx.mailinglists@gmail.com>
To: Huang Ying <ying.huang@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Mel Gorman <mgorman@suse.de>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Rafael Aquini <aquini@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@redhat.com>, Rik van Riel <riel@surriel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Dave Hansen <dave.hansen@intel.com>,
Andi Kleen <ak@linux.intel.com>, Michal Hocko <mhocko@suse.com>,
David Rientjes <rientjes@google.com>,
linux-api@vger.kernel.org
Subject: Re: [PATCH -V6 RESEND 2/3] NOT kernel/man-pages: man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING
Date: Wed, 2 Dec 2020 13:33:13 +0100 [thread overview]
Message-ID: <48e758d7-9961-e28e-26f5-3bb381d36309@gmail.com> (raw)
In-Reply-To: <20201202084234.15797-3-ying.huang@intel.com>
Hi Huang Ying,
Please see a few fixes below.
Michael, as always, some question for you too ;)
Thanks,
Alex
On 12/2/20 9:42 AM, Huang Ying wrote:
> Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
> ---
> man2/set_mempolicy.2 | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2
> index 68011eecb..3754b3e12 100644
> --- a/man2/set_mempolicy.2
> +++ b/man2/set_mempolicy.2
> @@ -113,6 +113,12 @@ A nonempty
> .I nodemask
> specifies node IDs that are relative to the set of
> node IDs allowed by the process's current cpuset.
> +.TP
> +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.11)"
I'd prefer it to be in alphabetical order (rather than just adding at
the bottom).
That way, when lists grow, it's easier to find things.
> +Enable the Linux kernel NUMA balancing for the task if it is supported
> +by kernel.
I'd s/Linux kernel/kernel/ when it doesn't specifically refer to the
Linux kernel to differentiate it from other kernels. It only adds noise
(IMHO). mtk?
wfix:
... supported by _the_ kernel.
> +If the flag isn't supported by Linux kernel, return -1 and errno is
wfix:
If the flag isn't supported by _the_ kernel, ...
> +set to EINVAL.
errno and EINVAL should use .I and .B respectively
> .PP
> .I nodemask
> points to a bit mask of node IDs that contains up to
> @@ -293,6 +299,9 @@ argument specified both
> .B MPOL_F_STATIC_NODES
> and
> .BR MPOL_F_RELATIVE_NODES .
> +Or, the
> +.B MPOL_F_NUMA_BALANCING
> +isn't supported by the Linux kernel.
> .TP
> .B ENOMEM
> Insufficient kernel memory was available.
>
next prev parent reply other threads:[~2020-12-02 12:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 8:42 [PATCH -V6 RESEND 0/3] numa balancing: Migrate on fault among multiple bound nodes Huang Ying
2020-12-02 8:42 ` [PATCH -V6 RESEND 1/3] " Huang Ying
2020-12-02 11:40 ` Mel Gorman
2020-12-03 10:25 ` Peter Zijlstra
2020-12-03 10:53 ` Mel Gorman
2020-12-04 9:19 ` Huang, Ying
2020-12-10 8:21 ` Huang, Ying
2020-12-02 8:42 ` [PATCH -V6 RESEND 2/3] NOT kernel/man-pages: man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING Huang Ying
2020-12-02 11:43 ` Mel Gorman
2020-12-03 1:49 ` Huang, Ying
2020-12-03 9:37 ` Mel Gorman
2020-12-02 12:33 ` Alejandro Colomar (mailing lists; readonly) [this message]
2020-12-08 8:13 ` Huang, Ying
2020-12-18 10:21 ` Alejandro Colomar (mailing lists; readonly)
2020-12-21 1:31 ` Huang, Ying
2020-12-02 8:42 ` [PATCH -V6 RESEND 3/3] NOT kernel/numactl: Support to enable Linux kernel NUMA balancing Huang Ying
2020-12-02 11:45 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48e758d7-9961-e28e-26f5-3bb381d36309@gmail.com \
--to=alx.mailinglists@gmail.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).