From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69A4EC433F5 for ; Mon, 31 Jan 2022 10:54:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E907C6B0073; Mon, 31 Jan 2022 05:54:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E413B6B0074; Mon, 31 Jan 2022 05:54:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D56FB6B0075; Mon, 31 Jan 2022 05:54:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id C4FCE6B0073 for ; Mon, 31 Jan 2022 05:54:24 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8E99B98C16 for ; Mon, 31 Jan 2022 10:54:24 +0000 (UTC) X-FDA: 79090273248.31.3034AEE Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by imf07.hostedemail.com (Postfix) with ESMTP id 4440D40003 for ; Mon, 31 Jan 2022 10:54:24 +0000 (UTC) Received: by mail-lf1-f43.google.com with SMTP id n8so25987342lfq.4 for ; Mon, 31 Jan 2022 02:54:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=FYJ06Pn7KdIiknGNcxtZYxSkpOlwX2UUSY/42OtNl5A=; b=jMMmsemMapD2tIaSffSat5gYTv8s4J+w0YvPP2UBc6Ytt1qnFobM7q5OSEx32iXLWu 6t3Z4qTmPfwOquKxVX1EXBgcIl6wasFvV1X6t0lmgRKpdkGExFByg/0ZGikvDu1bm5W1 fHXO7elszUKu6TOU4VUrvvfBoXqr6WBYpyr4UCWQ5AK5alT2boOAWNLCcww24BEY0QdV WTOMm419FWz2/PE3/8Ev/fMmI/xFDj3Y87m3qB94rkm+uLTGnzbc/ldsbYbRMNlKaVr2 RT2AT4vh63mB3Bmw8V/Slfv0gF9klPA1EmosgUanJ9d1oEA6L+SsFIFLeu5tu7WbtIl5 ujHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=FYJ06Pn7KdIiknGNcxtZYxSkpOlwX2UUSY/42OtNl5A=; b=b3T5XxRADv1S1VWwp043lbb/M+nP+y0h3/qa9uRQFSukgLKT9VSn3xXpYFg38Gtvjk GJc6oyewRqD2BLbUTh3KL7yPE/7tLMfScbIE3VJwxj+VdAt9pD/oXTrnmNsFgY+Nn/qk mQMvAntjvvcHX4nMZ/RwWoWFz8lpcY2WLb3DBlMfKi6FrzN8kEtCoCHESRM3r0GcKK5k bQnQpaxgVSoSZe+VOTc1NtOPNANenGo79TXUSH9s7+D74r+PstVR2vCpkc5Ma2PoO3f8 3qRZumtDR7VYeZFCHRiDlBB8/RCIHEuop8pkBsyePlnAa5n3xqE55Y30ye0o2UKzQFSa /tOQ== X-Gm-Message-State: AOAM531kUTvV2Qo/xOeXnr0TX08lX2Jqmcngq95rYx9ujB0Rxx4RNycE 555kkAzTOcp4HzDKMuxpSKQ= X-Google-Smtp-Source: ABdhPJy7mc/yKZIsj3pfPwCe5VRNQ6hQQWY691137WaoP7WTsYK5IgdWchGjbtuarNRsNzKk7lPb1A== X-Received: by 2002:a05:6512:1599:: with SMTP id bp25mr15166616lfb.678.1643626462679; Mon, 31 Jan 2022 02:54:22 -0800 (PST) Received: from [192.168.50.104] (staticline-31-183-164-222.toya.net.pl. [31.183.164.222]) by smtp.gmail.com with ESMTPSA id i18sm3610720lfv.257.2022.01.31.02.54.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 02:54:22 -0800 (PST) Message-ID: <51a1719144b57f3c17252832d0cd97ca8ff17293.camel@gmail.com> Subject: Re: [PATCH 07/16] tools/include: Add io.h stub From: Karolina Drobnik To: Mike Rapoport Cc: Matthew Wilcox , linux-mm@kvack.org, akpm@linux-foundation.org, mike.rapoport@gmail.com, linux-kernel@vger.kernel.org Date: Mon, 31 Jan 2022 11:54:21 +0100 In-Reply-To: References: <2d9aa000afe81b45157617664134b871207c2067.1643206612.git.karolinadrobnik@gmail.com> <48499a57afb3d27df26b39aa4255b4ba583c1148.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4440D40003 X-Stat-Signature: qhitkyb6qbyhbr8mmo9k3qpp46rtjoeg Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jMMmsemM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf07.hostedemail.com: domain of karolinadrobnik@gmail.com designates 209.85.167.43 as permitted sender) smtp.mailfrom=karolinadrobnik@gmail.com X-Rspam-User: nil X-HE-Tag: 1643626464-651229 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On Sun, 2022-01-30 at 18:10 +0200, Mike Rapoport wrote: > On Fri, Jan 28, 2022 at 12:21:59PM +0100, Karolina Drobnik wrote: > > On Thu, 2022-01-27 at 14:09 +0000, Matthew Wilcox wrote: > > > On Thu, Jan 27, 2022 at 02:21:25PM +0100, Karolina Drobnik wrote: > > > > Add a dummy io.h header. > > >=20 > > > Rather begs the question of what memblock.c needs from > > > linux/io.h. > > >=20 > > > Wouldn't it be better to: > > >=20 > > > +++ b/mm/memblock.c > > > @@ -18,7 +18,6 @@ > > > =C2=A0#include > > >=20 > > > =C2=A0#include > > > -#include > > >=20 > > > =C2=A0#include "internal.h" > > >=20 > >=20 > > That was something I considered in the very beginning, but didn't > > have > > a chance to verify it works for all architectures. I can take a > > look > > after I'm finished with other v2 changes. > >=20 > > > (allmodconfig on x86-64 builds fine with this; I have not done an > > > extended sweep of other arches / build options). >=20 > I did a sweep for defconfigs for all arches and all were fine. Thanks for doing the sweep, it's very helpful. > Karolina, please send the formal patch. Let's see how kbuild bot > reacts. OK, will send something later today. All the best, Karolina