linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: William Kucharski <kucharsk@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
	linux-mm <linux-mm@kvack.org>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
Subject: Re: [PATCH 2/6] mm: Optimise find_subpage for !THP
Date: Thu, 5 Mar 2020 02:54:36 -0700	[thread overview]
Message-ID: <53F12AD8-3517-4817-918E-3FBD2BD7D5FC@gmail.com> (raw)
In-Reply-To: <20200303214751.GW29971@bombadil.infradead.org>



> On Mar 3, 2020, at 2:47 PM, Matthew Wilcox <willy@infradead.org> wrote:
> 
> or maybe it's a good reason to make hpage_nr_pages() check that
> assertion if !CONFIG_TRANSPARENT_HUGEPAGE.

That would be easy enough to do as at present if
!CONFIG_TRANSPARENT_HUGEPAGE, hpage_nr_pages() simply returns 1.

It would give more coverage to the assert at the cost of a slight
performance degradation.

Do you think it would be worth it?



  reply	other threads:[~2020-03-05  9:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03  4:11 [PATCH 0/6] Misc MM patches Matthew Wilcox
2020-03-03  4:11 ` [PATCH 1/6] mm: Use vm_fault error code directly Matthew Wilcox
2020-03-03  4:11 ` [PATCH 2/6] mm: Optimise find_subpage for !THP Matthew Wilcox
2020-03-03 21:28   ` Alexander Duyck
2020-03-03 21:47     ` Matthew Wilcox
2020-03-05  9:54       ` William Kucharski [this message]
2020-03-03  4:11 ` [PATCH 3/6] mm: Remove CONFIG_TRANSPARENT_HUGE_PAGECACHE Matthew Wilcox
2020-03-03 21:52   ` Alexander Duyck
2020-03-03 22:34     ` Matthew Wilcox
2020-03-03 22:54       ` Alexander Duyck
2020-03-04  2:06         ` Matthew Wilcox
2020-03-03  4:11 ` [PATCH 4/6] mm: Use VM_BUG_ON_PAGE in clear_page_dirty_for_io Matthew Wilcox
2020-03-03  4:11 ` [PATCH 5/6] mm: Unexport find_get_entry Matthew Wilcox
2020-03-03  4:11 ` [PATCH 6/6] mm: Rewrite pagecache_get_page documentation Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F12AD8-3517-4817-918E-3FBD2BD7D5FC@gmail.com \
    --to=kucharsk@gmail.com \
    --cc=alexander.duyck@gmail.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).