From: David Hildenbrand <david@redhat.com>
To: Yajun Deng <yajun.deng@linux.dev>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/rmap: convert __page_{set, check}_anon_rmap() to folios
Date: Wed, 12 Apr 2023 10:43:52 +0200 [thread overview]
Message-ID: <5db8766d-2574-7904-f112-80a862335a5d@redhat.com> (raw)
In-Reply-To: <20230412021811.1503281-1-yajun.deng@linux.dev>
On 12.04.23 04:18, Yajun Deng wrote:
> The 2nd parameter in __page_set_anon_rmap() is only used by
> SetPageAnonExclusive(), so there is no need to put
> SetPageAnonExclusive() in __page_set_anon_rmap().
>
> Remove SetPageAnonExclusive() from __page_set_anon_rmap() and modify
> __page_set_anon_rmap() to __folio_set_anon_rmap().
>
> Since __page_check_anon_rmap() needs a folio, we can directly use
> and change it to __folio_check_anon_rmap().
>
Leaking the SetPageAnonExclusive() into all callers is not an improvement.
Not convinced we want this patch TBH. Tentative NAK.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-04-12 8:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 2:18 [PATCH] mm/rmap: convert __page_{set, check}_anon_rmap() to folios Yajun Deng
2023-04-12 8:43 ` David Hildenbrand [this message]
2023-04-12 13:04 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5db8766d-2574-7904-f112-80a862335a5d@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).