From: Mike Rapoport <rppt@kernel.org>
To: Michal Hocko <mhocko@kernel.org>,Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org,linux-mm@kvack.org,linux-xfs@vger.kernel.org,dm-devel@redhat.com,Mikulas
Patocka <mpatocka@redhat.com>,Jens Axboe
<axboe@kernel.dk>,NeilBrown <neilb@suse.de>
Subject: Re: [PATCH 6/6] mm: Add memalloc_nowait
Date: Mon, 29 Jun 2020 16:45:14 +0300 [thread overview]
Message-ID: <6421BC93-CF2F-4697-B5CB-5ECDAA9FCB37@kernel.org> (raw)
In-Reply-To: <20200629125231.GJ32461@dhcp22.suse.cz>
On June 29, 2020 3:52:31 PM GMT+03:00, Michal Hocko <mhocko@kernel.org> wrote:
>On Mon 29-06-20 13:18:16, Matthew Wilcox wrote:
>> On Mon, Jun 29, 2020 at 08:08:51AM +0300, Mike Rapoport wrote:
>> > > @@ -886,8 +868,12 @@ static struct dm_buffer
>*__alloc_buffer_wait_no_callback(struct dm_bufio_client
>> > > return NULL;
>> > >
>> > > if (dm_bufio_cache_size_latch != 1 && !tried_noio_alloc) {
>> > > + unsigned noio_flag;
>> > > +
>> > > dm_bufio_unlock(c);
>> > > - b = alloc_buffer(c, GFP_NOIO | __GFP_NORETRY |
>__GFP_NOMEMALLOC | __GFP_NOWARN);
>> > > + noio_flag = memalloc_noio_save();
>> >
>> > I've read the series twice and I'm still missing the definition of
>> > memalloc_noio_save().
>> >
>> > And also it would be nice to have a paragraph about it in
>> > Documentation/core-api/memory-allocation.rst
>>
>>
>Documentation/core-api/gfp_mask-from-fs-io.rst:``memalloc_nofs_save``,
>``memalloc_nofs_restore`` respectively ``memalloc_noio_save``,
>> Documentation/core-api/gfp_mask-from-fs-io.rst: :functions:
>memalloc_noio_save memalloc_noio_restore
>> Documentation/core-api/gfp_mask-from-fs-io.rst:allows nesting so it
>is safe to call ``memalloc_noio_save`` or
>
>The patch is adding memalloc_nowait* and I suspect Mike had that in
>mind, which would be a fair request.
Right, sorry misprinted that.
> Btw. we are missing
>memalloc_nocma*
>documentation either - I was just reminded of its existence today..
--
Sincerely yours,
Mike
next prev parent reply other threads:[~2020-06-29 13:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 11:31 [PATCH 0/6] Overhaul memalloc_no* Matthew Wilcox (Oracle)
2020-06-25 11:31 ` [PATCH 1/6] mm: Replace PF_MEMALLOC_NOIO with memalloc_noio Matthew Wilcox (Oracle)
2020-06-25 12:22 ` Michal Hocko
2020-06-25 12:34 ` Matthew Wilcox
2020-06-25 12:42 ` Michal Hocko
2020-06-25 11:31 ` [PATCH 2/6] mm: Add become_kswapd and restore_kswapd Matthew Wilcox (Oracle)
2020-06-25 12:31 ` Michal Hocko
2020-06-25 11:31 ` [PATCH 3/6] xfs: Convert to memalloc_nofs_save Matthew Wilcox (Oracle)
2020-06-25 11:31 ` [PATCH 4/6] mm: Replace PF_MEMALLOC_NOFS with memalloc_nofs Matthew Wilcox (Oracle)
2020-06-25 13:35 ` Michal Hocko
2020-06-25 11:31 ` [PATCH 5/6] mm: Replace PF_MEMALLOC_NOIO with memalloc_nocma Matthew Wilcox (Oracle)
2020-06-25 11:31 ` [PATCH 6/6] mm: Add memalloc_nowait Matthew Wilcox (Oracle)
2020-06-25 12:40 ` Michal Hocko
2020-06-25 13:10 ` Matthew Wilcox
2020-06-25 13:34 ` Michal Hocko
2020-06-25 19:05 ` kernel test robot
2020-06-25 23:51 ` kernel test robot
2020-06-29 5:08 ` Mike Rapoport
2020-06-29 12:18 ` Matthew Wilcox
2020-06-29 12:52 ` Michal Hocko
2020-06-29 13:45 ` Mike Rapoport [this message]
2020-06-29 21:28 ` Matthew Wilcox
2020-06-30 6:34 ` Michal Hocko
2020-07-01 4:12 ` Matthew Wilcox
2020-07-01 5:53 ` Michal Hocko
2020-07-01 7:04 ` Mike Rapoport
2020-09-24 0:39 ` Mike Snitzer
2020-09-24 1:10 ` Matthew Wilcox
2020-10-23 14:49 ` Daniel Vetter
2020-06-25 18:48 ` [PATCH 0/6] Overhaul memalloc_no* Darrick J. Wong
2020-06-25 20:34 ` Matthew Wilcox
2020-06-25 20:36 ` Michal Hocko
2020-06-25 20:40 ` Matthew Wilcox
2020-06-26 15:02 ` Mikulas Patocka
2020-06-26 23:08 ` Dave Chinner
2020-06-27 13:09 ` Mikulas Patocka
2020-06-29 0:35 ` Dave Chinner
2020-06-29 13:43 ` Mikulas Patocka
2020-06-29 22:34 ` Dave Chinner
2020-07-03 14:26 ` [PATCH] dm-bufio: do cleanup from a workqueue Mikulas Patocka
2020-06-29 8:22 ` [PATCH 0/6] Overhaul memalloc_no* Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6421BC93-CF2F-4697-B5CB-5ECDAA9FCB37@kernel.org \
--to=rppt@kernel.org \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=mpatocka@redhat.com \
--cc=neilb@suse.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).