From: David Hildenbrand <david@redhat.com>
To: "Huang, Ying" <ying.huang@intel.com>,
"Verma, Vishal L" <vishal.l.verma@intel.com>
Cc: "Jiang, Dave" <dave.jiang@intel.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"osalvador@suse.de" <osalvador@suse.de>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"Jonathan.Cameron@Huawei.com" <Jonathan.Cameron@Huawei.com>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"aneesh.kumar@linux.ibm.com" <aneesh.kumar@linux.ibm.com>,
"jmoyer@redhat.com" <jmoyer@redhat.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mike Rapoport <rppt@kernel.org>,
Bernhard Walle <bernhard.walle@gmx.de>
Subject: Re: [PATCH v2 2/3] mm/memory_hotplug: split memmap_on_memory requests across memblocks
Date: Mon, 14 Aug 2023 09:20:11 +0200 [thread overview]
Message-ID: <6ce08d40-332b-217e-6203-c73dd7203e96@redhat.com> (raw)
In-Reply-To: <87jzty9l6w.fsf@yhuang6-desk2.ccr.corp.intel.com>
On 14.08.23 08:45, Huang, Ying wrote:
> "Verma, Vishal L" <vishal.l.verma@intel.com> writes:
>
>> On Mon, 2023-07-24 at 13:54 +0800, Huang, Ying wrote:
>>> Vishal Verma <vishal.l.verma@intel.com> writes:
>>>
>>>>
>>>> @@ -2035,12 +2056,38 @@ void try_offline_node(int nid)
>>>> }
>>>> EXPORT_SYMBOL(try_offline_node);
>>>>
>>>> -static int __ref try_remove_memory(u64 start, u64 size)
>>>> +static void __ref __try_remove_memory(int nid, u64 start, u64 size,
>>>> + struct vmem_altmap *altmap)
>>>> {
>>>> - struct vmem_altmap mhp_altmap = {};
>>>> - struct vmem_altmap *altmap = NULL;
>>>> - unsigned long nr_vmemmap_pages;
>>>> - int rc = 0, nid = NUMA_NO_NODE;
>>>> + /* remove memmap entry */
>>>> + firmware_map_remove(start, start + size, "System RAM");
>>>
>>> If mhp_supports_memmap_on_memory(), we will call
>>> firmware_map_add_hotplug() for whole range. But here we may call
>>> firmware_map_remove() for part of range. Is it OK?
>>>
>>
>> Good point, this is a discrepancy in the add vs remove path. Can the
>> firmware memmap entries be moved up a bit in the add path, and is it
>> okay to create these for each memblock? Or should these be for the
>> whole range? I'm not familiar with the implications. (I've left it as
>> is for v3 for now, but depending on the direction I can update in a
>> future rev).
>
> Cced more firmware map developers and maintainers.
>
> Per my understanding, we should create one firmware memmap entry for
> each memblock.
Ideally we should create it for the whole range, ti limit the ranges.
But it really only matters for DIMMs; for dax/kmem, we'll not create any
firmware entries.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-08-14 7:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 7:14 [PATCH v2 0/3] mm: use memmap_on_memory semantics for dax/kmem Vishal Verma
2023-07-20 7:14 ` [PATCH v2 1/3] mm/memory_hotplug: Export symbol mhp_supports_memmap_on_memory() Vishal Verma
2023-07-24 6:00 ` Huang, Ying
2023-07-20 7:14 ` [PATCH v2 2/3] mm/memory_hotplug: split memmap_on_memory requests across memblocks Vishal Verma
2023-07-21 12:20 ` Aneesh Kumar K.V
2023-07-23 14:53 ` Aneesh Kumar K.V
2023-07-24 3:16 ` Huang, Ying
2023-08-02 6:02 ` Verma, Vishal L
2023-08-14 6:04 ` Huang, Ying
2023-07-24 5:54 ` Huang, Ying
2023-08-02 6:08 ` Verma, Vishal L
2023-08-14 6:45 ` Huang, Ying
2023-08-14 7:20 ` David Hildenbrand [this message]
2023-07-20 7:14 ` [PATCH v2 3/3] dax/kmem: allow kmem to add memory with memmap_on_memory Vishal Verma
2023-07-25 15:54 ` [PATCH v2 0/3] mm: use memmap_on_memory semantics for dax/kmem David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ce08d40-332b-217e-6203-c73dd7203e96@redhat.com \
--to=david@redhat.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=bernhard.walle@gmx.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmoyer@redhat.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nvdimm@lists.linux.dev \
--cc=osalvador@suse.de \
--cc=rppt@kernel.org \
--cc=vishal.l.verma@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).