From: John Hubbard <jhubbard@nvidia.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Jerome Glisse <jglisse@redhat.com>, Linux-MM <linux-mm@kvack.org>,
<mm-commits@vger.kernel.org>,
Ralph Campbell <rcampbell@nvidia.com>,
"Shuah Khan" <shuah@kernel.org>,
Jason Gary Gunthorpe <jgg@nvidia.com>
Subject: Re: [patch 16/40] selftests/vm: use a common gup_test.h
Date: Mon, 19 Oct 2020 21:13:40 -0700 [thread overview]
Message-ID: <6dd0e8ea-3b86-8289-473d-3ffef99805ba@nvidia.com> (raw)
In-Reply-To: <59c6b448-039a-e56b-1ec6-9f92e316acb0@nvidia.com>
On 10/18/20 12:48 PM, John Hubbard wrote:
> On 10/18/20 12:33 PM, Linus Torvalds wrote:
>> On Sun, Oct 18, 2020 at 12:13 PM John Hubbard <jhubbard@nvidia.com> wrote:
> ...
>
>> Guys, you're looking at the wrong thing.
>>
>> Inside the *tools* subdirectory, that "../../.." thing makes sense.
>> You're in tools/testing/selftests/vm, and those crazy ".." paths are
>> ok. Ugly, but ok.
>>
>> But the thing I objected to wasn't that tools directory ugliness.
>>
>> Let me repeat what I found completely and utterly unacceptable, and
>> what you don't seem to have noticed, and what your patch didn't fix or
>> touch:
>>
>> +++ a/mm/gup_test.c
>> +#include "../../../../mm/gup_test.h"
>>
>> Notice what directory it is in? Notice how "../../.." etc is
>> COMPLETELY UNACCEPTABLE GARBAGE.
>>
>> Linus
>>
>
> aha, yes. yuck. So can we please just fix it up like this? A quick compile
> test shows that it does build as expected:
>
> diff --git a/mm/gup_test.c b/mm/gup_test.c
> index 32770656cc32..e4c396146e90 100644
> --- a/mm/gup_test.c
> +++ b/mm/gup_test.c
> @@ -4,7 +4,7 @@
> #include <linux/uaccess.h>
> #include <linux/ktime.h>
> #include <linux/debugfs.h>
> -#include "../../../../mm/gup_test.h"
> +#include "gup_test.h"
>
> static void put_back_pages(unsigned int cmd, struct page **pages,
> unsigned long nr_pages, unsigned int gup_test_flags)
>
>
Also, if there is anything I can do to unblock this, such as sending a formal
patch, or an updated patch or patchset, please let me know. I realize that
this is a low-priority area, but it would still be nice to get it merged
and behind us.
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2020-10-20 4:13 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 23:13 incoming Andrew Morton
2020-10-17 23:13 ` [patch 01/40] ia64: fix build error with !COREDUMP Andrew Morton
2020-10-17 23:13 ` [patch 02/40] mm, memcg: rework remote charging API to support nesting Andrew Morton
2020-10-17 23:13 ` [patch 03/40] mm: kmem: move memcg_kmem_bypass() calls to get_mem/obj_cgroup_from_current() Andrew Morton
2020-10-17 23:13 ` [patch 04/40] mm: kmem: remove redundant checks from get_obj_cgroup_from_current() Andrew Morton
2020-10-17 23:13 ` [patch 05/40] mm: kmem: prepare remote memcg charging infra for interrupt contexts Andrew Morton
2020-10-17 23:13 ` [patch 06/40] mm: kmem: enable kernel memcg accounting from " Andrew Morton
2020-10-17 23:13 ` [patch 07/40] mm/memory-failure: remove a wrapper for alloc_migration_target() Andrew Morton
2020-10-17 23:14 ` [patch 08/40] mm/memory_hotplug: " Andrew Morton
2020-10-17 23:14 ` [patch 09/40] mm/migrate: avoid possible unnecessary process right check in kernel_move_pages() Andrew Morton
2020-10-17 23:14 ` [patch 10/40] mm/mmap: add inline vma_next() for readability of mmap code Andrew Morton
2020-10-17 23:14 ` [patch 11/40] mm/mmap: add inline munmap_vma_range() for code readability Andrew Morton
2020-10-17 23:14 ` [patch 12/40] mm/gup_benchmark: take the mmap lock around GUP Andrew Morton
2020-10-17 23:14 ` [patch 13/40] binfmt_elf: take the mmap lock around find_extend_vma() Andrew Morton
2020-10-17 23:14 ` [patch 14/40] mm/gup: assert that the mmap lock is held in __get_user_pages() Andrew Morton
2020-10-18 1:28 ` Jann Horn
2020-10-17 23:14 ` [patch 15/40] mm/gup_benchmark: rename to mm/gup_test Andrew Morton
2020-10-17 23:14 ` [patch 16/40] selftests/vm: use a common gup_test.h Andrew Morton
2020-10-18 16:18 ` Linus Torvalds
2020-10-18 16:22 ` Linus Torvalds
2020-10-18 18:50 ` John Hubbard
2020-10-18 19:03 ` Matthew Wilcox
2020-10-18 19:12 ` John Hubbard
2020-10-18 19:33 ` Linus Torvalds
2020-10-18 19:48 ` John Hubbard
2020-10-20 4:13 ` John Hubbard [this message]
2020-10-20 16:45 ` Linus Torvalds
2020-10-20 18:45 ` John Hubbard
2020-10-17 23:14 ` [patch 17/40] selftests/vm: rename run_vmtests --> run_vmtests.sh Andrew Morton
2020-10-17 23:14 ` [patch 18/40] selftests/vm: minor cleanup: Makefile and gup_test.c Andrew Morton
2020-10-17 23:14 ` [patch 19/40] selftests/vm: only some gup_test items are really benchmarks Andrew Morton
2020-10-17 23:14 ` [patch 20/40] selftests/vm: gup_test: introduce the dump_pages() sub-test Andrew Morton
2020-10-17 23:14 ` [patch 21/40] selftests/vm: run_vmtests.sh: update and clean up gup_test invocation Andrew Morton
2020-10-17 23:14 ` [patch 22/40] selftests/vm: hmm-tests: remove the libhugetlbfs dependency Andrew Morton
2020-10-17 23:14 ` [patch 23/40] selftests/vm: 10x speedup for hmm-tests Andrew Morton
2020-10-17 23:14 ` [patch 24/40] mm/madvise: pass mm to do_madvise Andrew Morton
2020-10-17 23:14 ` [patch 25/40] pid: move pidfd_get_pid() to pid.c Andrew Morton
2020-10-17 23:14 ` [patch 26/40] mm/madvise: introduce process_madvise() syscall: an external memory hinting API Andrew Morton
2020-10-17 23:15 ` [patch 27/40] mm: update the documentation for vfree Andrew Morton
2020-10-17 23:15 ` [patch 28/40] mm: add a VM_MAP_PUT_PAGES flag for vmap Andrew Morton
2020-10-17 23:15 ` [patch 29/40] mm: add a vmap_pfn function Andrew Morton
2020-10-17 23:15 ` [patch 30/40] mm: allow a NULL fn callback in apply_to_page_range Andrew Morton
2020-10-17 23:15 ` [patch 31/40] zsmalloc: switch from alloc_vm_area to get_vm_area Andrew Morton
2020-10-17 23:15 ` [patch 32/40] drm/i915: use vmap in shmem_pin_map Andrew Morton
2020-10-17 23:15 ` [patch 33/40] drm/i915: stop using kmap in i915_gem_object_map Andrew Morton
2020-10-17 23:15 ` [patch 34/40] drm/i915: use vmap " Andrew Morton
2020-10-17 23:15 ` [patch 35/40] xen/xenbus: use apply_to_page_range directly in xenbus_map_ring_pv Andrew Morton
2020-10-17 23:15 ` [patch 36/40] x86/xen: open code alloc_vm_area in arch_gnttab_valloc Andrew Morton
2020-10-17 23:15 ` [patch 37/40] mm: remove alloc_vm_area Andrew Morton
2020-10-17 23:15 ` [patch 38/40] mm: cleanup the gfp_mask handling in __vmalloc_area_node Andrew Morton
2020-10-17 23:15 ` [patch 39/40] mm: remove the filename in the top of file comment in vmalloc.c Andrew Morton
2020-10-17 23:15 ` [patch 40/40] mm: remove duplicate include statement in mmu.c Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dd0e8ea-3b86-8289-473d-3ffef99805ba@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=jgg@nvidia.com \
--cc=jglisse@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=rcampbell@nvidia.com \
--cc=shuah@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).