From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 195CCC7619A for ; Wed, 12 Apr 2023 02:54:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5732D6B0075; Tue, 11 Apr 2023 22:54:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5233F6B0078; Tue, 11 Apr 2023 22:54:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 411B0900003; Tue, 11 Apr 2023 22:54:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 317D96B0075 for ; Tue, 11 Apr 2023 22:54:25 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DBC7840EBA for ; Wed, 12 Apr 2023 02:54:24 +0000 (UTC) X-FDA: 80671220448.27.6225968 Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf01.hostedemail.com (Postfix) with ESMTP id 18DB540013 for ; Wed, 12 Apr 2023 02:54:21 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf01.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681268063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zrw7C1E0OO3IWUo6jrIg1Yzw9DTL6Q8bZRbU0ZbZf0Y=; b=Ss/IoEBxQchPQ2KjeMUBoNwpnbgvwxm4/yahwOu+1AK7IIXr7FgfFVvyPiCxxD6RohEruy 9SPND9XddaPccyLizSZ16zBNMRyT3cEpumAkY6vf9X+kqpGPo5n67teuMYJ35te77RZ71a w9hErMo3SyiNrHZPX5xh+tBc9inTILY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf01.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681268063; a=rsa-sha256; cv=none; b=Cyicx++dZ3Tcm3To1glOw+oFNPbr+mS+A0NQcU7KN5eyi1tiRphQhFTx2MtWYKyRnF6Foi 5/zMm9hHS/vMhA+FMekz7TiKpjo7C+ViALXT0GE/ndcKyrHld2hATHwn6gm2T69maL0rxd 7Ik5awzisiVCQw8EnGXTzYiw8JdM0bo= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R491e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=24;SR=0;TI=SMTPD_---0VfuNqmu_1681268054; Received: from 30.240.113.3(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VfuNqmu_1681268054) by smtp.aliyun-inc.com; Wed, 12 Apr 2023 10:54:16 +0800 Message-ID: <6e21acea-9e1b-249a-f809-324fa5a168f5@linux.alibaba.com> Date: Wed, 12 Apr 2023 10:54:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v5 1/2] ACPI: APEI: set memory failure flags as MF_ACTION_REQUIRED on synchronous events Content-Language: en-US To: Kefeng Wang , tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, naoya.horiguchi@nec.com Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, justin.he@arm.com, akpm@linux-foundation.org, ardb@kernel.org, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, bp@alien8.de, cuibixuan@linux.alibaba.com, dave.hansen@linux.intel.com, james.morse@arm.com, jarkko@kernel.org, lenb@kernel.org, linmiaohe@huawei.com, lvying6@huawei.com, rafael@kernel.org, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20230411104842.37079-2-xueshuai@linux.alibaba.com> From: Shuai Xue In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 18DB540013 X-Stat-Signature: ru8k1f1z9jbqzwps7aywstpwp8k7rswj X-HE-Tag: 1681268061-844774 X-HE-Meta: U2FsdGVkX1/CnyO9vbDWuVxju+vg7hntis0cu5S3M8qTVo42l9hHfc44d0L4rgzm9uyOF23PQ5A6XagMJjDSoW/RM8fZzIX0S8Rk+LNbjUgQq7v8y5YcPnH16Mb9K5JjRFb0ExWGOWhNDuKE1twJGUXanT44R1wBZR3TUOVNNqEvbyGGfkjb40AzpLXRCjgOvAIPKLdUK7C+MzvK/t3/8/ZgeWf417lmz+Em1uZZq2jGHTYQRfhDD4cpOwgmCzgEdbMdlJDUn6tAw5xw2A2cNHRK1AqYZUjr3/OpwtlyxzcwU1bWHmWrTxcHKJ3e2Z9rWqZiT5SWdx+dJmAClu9OR20eadN704I3Vy5UPzn+7k1C4xUfipvI+0stc82TkXnzCIwgVT4+eSlKHut6LaMI3uBDNryolXpclHZnAQ6wte8PWjRYd10ZyuCxe4Vsgkrh87Hvzc5x7e0sxB77DH8Q0AH97NN462CMbLYiWZRoiygqQNecAPFNFJdSGkjo+VTdCkXQI6a2btMxdEqdfF9oirBcU9I5IHlEuqx19hiTL8tKVwqbZXwudXHiE1Tq9MBptYVlYIuGtx5goigbiSLhaIGhRSg2/4PRwHAD4YlroGIXPrSI5dvC5g0jj6NzR50JuZaH1o4xxZCkJQG6jP91hwn+941hefolIUE1+FkRpKfV5ofT/aW4wJVu1kFwJMM6me6RTtn3XoLR1K4yiVsB4KEYR8GVuFTuwhWpQsnvu+5wGGQYRXoQc74R3AAWJjMfF1JMzJP+yMpg00kdsZFClDrIFUaGKsqdSmN6QQGLBuhJbPz/gXiQ/mMMCBKVtTJeWx3VpcKz8ZClNCEe/q4XY8yXdR7Z4QqxR83mYc9snAXmqcXBvddgsDrDh1tEwk2bRntLPGevKO0/SgZkRrgCeDJ+I9m+v2lr4K6SIWpVw7oFrFQUG6jfaZEd7VoxUwMK6sM2UxOERBUHxux70/N 3vTF5VUM OByW/G7rmFEDklC/shKdAjZaOgwpGSRlV53iGGD8StblWnS7mvjqL21dKapvGZGKd5IdBqgiiwo+yOPV1XJInFGQG1vT4gvOqxv0Z5bE670+KVXAOX93XCaj86Nkft2lmDsLCVM1bqwHiqilAHxRZ5qIureOmU8cxwk2W2HR9LN/pTj2UBdBvjMjJjqQecWWLQ/RS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/4/11 PM10:17, Kefeng Wang wrote: > Hi Shuai Xue， > > On 2023/4/11 18:48, Shuai Xue wrote: >> There are two major types of uncorrected recoverable (UCR) errors : >> >> - Action Required (AR): The error is detected and the processor already >>    consumes the memory. OS requires to take action (for example, offline >>    failure page/kill failure thread) to recover this uncorrectable error. >> >> - Action Optional (AO): The error is detected out of processor execution >>    context. Some data in the memory are corrupted. But the data have not >>    been consumed. OS is optional to take action to recover this >>    uncorrectable error. >> >> The essential difference between AR and AO errors is that AR is a >> synchronous event, while AO is an asynchronous event. The hardware will >> signal a synchronous exception (Machine Check Exception on X86 and >> Synchronous External Abort on Arm64) when an error is detected and the >> memory access has been architecturally executed. >> >> When APEI firmware first is enabled, a platform may describe one error >> source for the handling of synchronous errors (e.g. MCE or SEA notification >> ), or for handling asynchronous errors (e.g. SCI or External Interrupt >> notification). In other words, we can distinguish synchronous errors by >> APEI notification. For AR errors, kernel will kill current process >> accessing the poisoned page by sending SIGBUS with BUS_MCEERR_AR. In >> addition, for AO errors, kernel will notify the process who owns the >> poisoned page by sending SIGBUS with BUS_MCEERR_AO in early kill mode. >> However, the GHES driver always sets mf_flags to 0 so that all UCR errors >> are handled as AO errors in memory failure. >> >> To this end, set memory failure flags as MF_ACTION_REQUIRED on synchronous >> events. > > As your mentioned in cover-letter, we met same issue, and hope it could be fixed ASAP, this patch looks good to me, > > Reviewed-by: Kefeng Wang Thank you. Cheers, Shuai > >> >> Fixes: ba61ca4aab47 ("ACPI, APEI, GHES: Add hardware memory error recovery support")' >> Signed-off-by: Shuai Xue >> Tested-by: Ma Wupeng >> --- >>   drivers/acpi/apei/ghes.c | 29 +++++++++++++++++++++++------ >>   1 file changed, 23 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c >> index 34ad071a64e9..c479b85899f5 100644 >> --- a/drivers/acpi/apei/ghes.c >> +++ b/drivers/acpi/apei/ghes.c >> @@ -101,6 +101,20 @@ static inline bool is_hest_type_generic_v2(struct ghes *ghes) >>       return ghes->generic->header.type == ACPI_HEST_TYPE_GENERIC_ERROR_V2; >>   } >>   +/* >> + * A platform may describe one error source for the handling of synchronous >> + * errors (e.g. MCE or SEA), or for handling asynchronous errors (e.g. SCI >> + * or External Interrupt). On x86, the HEST notifications are always >> + * asynchronous, so only SEA on ARM is delivered as a synchronous >> + * notification. >> + */ >> +static inline bool is_hest_sync_notify(struct ghes *ghes) >> +{ >> +    u8 notify_type = ghes->generic->notify.type; >> + >> +    return notify_type == ACPI_HEST_NOTIFY_SEA; >> +} >> + >>   /* >>    * This driver isn't really modular, however for the time being, >>    * continuing to use module_param is the easiest way to remain >> @@ -477,7 +491,7 @@ static bool ghes_do_memory_failure(u64 physical_addr, int flags) >>   } >>     static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, >> -                       int sev) >> +                       int sev, bool sync) >>   { >>       int flags = -1; >>       int sec_sev = ghes_severity(gdata->error_severity); >> @@ -491,7 +505,7 @@ static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, >>           (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED)) >>           flags = MF_SOFT_OFFLINE; >>       if (sev == GHES_SEV_RECOVERABLE && sec_sev == GHES_SEV_RECOVERABLE) >> -        flags = 0; >> +        flags = sync ? MF_ACTION_REQUIRED : 0; >>         if (flags != -1) >>           return ghes_do_memory_failure(mem_err->physical_addr, flags); >> @@ -499,9 +513,11 @@ static bool ghes_handle_memory_failure(struct acpi_hest_generic_data *gdata, >>       return false; >>   } >>   -static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, int sev) >> +static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, >> +                       int sev, bool sync) >>   { >>       struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata); >> +    int flags = sync ? MF_ACTION_REQUIRED : 0; >>       bool queued = false; >>       int sec_sev, i; >>       char *p; >> @@ -526,7 +542,7 @@ static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata, int s >>            * and don't filter out 'corrected' error here. >>            */ >>           if (is_cache && has_pa) { >> -            queued = ghes_do_memory_failure(err_info->physical_fault_addr, 0); >> +            queued = ghes_do_memory_failure(err_info->physical_fault_addr, flags); >>               p += err_info->length; >>               continue; >>           } >> @@ -647,6 +663,7 @@ static bool ghes_do_proc(struct ghes *ghes, >>       const guid_t *fru_id = &guid_null; >>       char *fru_text = ""; >>       bool queued = false; >> +    bool sync = is_hest_sync_notify(ghes); >>         sev = ghes_severity(estatus->error_severity); >>       apei_estatus_for_each_section(estatus, gdata) { >> @@ -664,13 +681,13 @@ static bool ghes_do_proc(struct ghes *ghes, >>               atomic_notifier_call_chain(&ghes_report_chain, sev, mem_err); >>                 arch_apei_report_mem_error(sev, mem_err); >> -            queued = ghes_handle_memory_failure(gdata, sev); >> +            queued = ghes_handle_memory_failure(gdata, sev, sync); >>           } >>           else if (guid_equal(sec_type, &CPER_SEC_PCIE)) { >>               ghes_handle_aer(gdata); >>           } >>           else if (guid_equal(sec_type, &CPER_SEC_PROC_ARM)) { >> -            queued = ghes_handle_arm_hw_error(gdata, sev); >> +            queued = ghes_handle_arm_hw_error(gdata, sev, sync); >>           } else { >>               void *err = acpi_hest_get_payload(gdata); >>