From: David Hildenbrand <david@redhat.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Matthew Wilcox <willy@infradead.org>,
Julien Grall <julien.grall@arm.com>
Cc: Juergen Gross <jgross@suse.com>,
k.khlebnikov@samsung.com,
Stefano Stabellini <sstabellini@kernel.org>,
Kees Cook <keescook@chromium.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"VMware, Inc." <pv-drivers@vmware.com>,
osstest service owner <osstest-admin@xenproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Julien Freche <jfreche@vmware.com>,
Nadav Amit <namit@vmware.com>,
xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] xen: Can't insert balloon page into VM userspace (WAS Re: [linux-linus bisection] complete test-arm64-arm64-xl-xsm)
Date: Tue, 12 Mar 2019 20:46:20 +0100 [thread overview]
Message-ID: <6f8aca6c-355b-7862-75aa-68fe566f76fb@redhat.com> (raw)
In-Reply-To: <9a40e1ff-7605-e822-a1d2-502a12d0fba7@redhat.com>
On 12.03.19 19:23, David Hildenbrand wrote:
> On 12.03.19 19:02, Boris Ostrovsky wrote:
>> On 3/12/19 1:24 PM, Andrew Cooper wrote:
>>> On 12/03/2019 17:18, David Hildenbrand wrote:
>>>> On 12.03.19 18:14, Matthew Wilcox wrote:
>>>>> On Tue, Mar 12, 2019 at 05:05:39PM +0000, Julien Grall wrote:
>>>>>> On 3/12/19 3:59 PM, Julien Grall wrote:
>>>>>>> It looks like all the arm test for linus [1] and next [2] tree
>>>>>>> are now failing. x86 seems to be mostly ok.
>>>>>>>
>>>>>>> The bisector fingered the following commit:
>>>>>>>
>>>>>>> commit 0ee930e6cafa048c1925893d0ca89918b2814f2c
>>>>>>> Author: Matthew Wilcox <willy@infradead.org>
>>>>>>> Date: Tue Mar 5 15:46:06 2019 -0800
>>>>>>>
>>>>>>> mm/memory.c: prevent mapping typed pages to userspace
>>>>>>> Pages which use page_type must never be mapped to userspace as it would
>>>>>>> destroy their page type. Add an explicit check for this instead of
>>>>>>> assuming that kernel drivers always get this right.
>>>>> Oh good, it found a real problem.
>>>>>
>>>>>> It turns out the problem is because the balloon driver will call
>>>>>> __SetPageOffline() on allocated page. Therefore the page has a type and
>>>>>> vm_insert_pages will deny the insertion.
>>>>>>
>>>>>> My knowledge is quite limited in this area. So I am not sure how we can
>>>>>> solve the problem.
>>>>>>
>>>>>> I would appreciate if someone could provide input of to fix the mapping.
>>>>> I don't know the balloon driver, so I don't know why it was doing this,
>>>>> but what it was doing was Wrong and has been since 2014 with:
>>>>>
>>>>> commit d6d86c0a7f8ddc5b38cf089222cb1d9540762dc2
>>>>> Author: Konstantin Khlebnikov <k.khlebnikov@samsung.com>
>>>>> Date: Thu Oct 9 15:29:27 2014 -0700
>>>>>
>>>>> mm/balloon_compaction: redesign ballooned pages management
>>>>>
>>>>> If ballooned pages are supposed to be mapped into userspace, you can't mark
>>>>> them as ballooned pages using the mapcount field.
>>>>>
>>>> Asking myself why anybody would want to map balloon inflated pages into
>>>> user space (this just sounds plain wrong but my understanding to what
>>>> XEN balloon driver does might be limited), but I assume the easy fix
>>>> would be to revert
>>> I suspect the bug here is that the balloon driver is (ab)used for a
>>> second purpose
>>
>> Yes. And its name is alloc_xenballooned_pages().
>>
>
> Haven't had a look at the code yet, but would another temporary fix be
> to clear/set PG_offline when allocating/freeing a ballooned page?
> (assuming here that only such pages will be mapped to user space)
>
I guess something like this could do the trick if I understood it correctly:
diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 39b229f9e256..d37dd5bb7a8f 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -604,6 +604,7 @@ int alloc_xenballooned_pages(int nr_pages, struct
page **pages)
while (pgno < nr_pages) {
page = balloon_retrieve(true);
if (page) {
+ __ClearPageOffline(page);
pages[pgno++] = page;
#ifdef CONFIG_XEN_HAVE_PVMMU
/*
@@ -645,8 +646,10 @@ void free_xenballooned_pages(int nr_pages, struct
page **pages)
mutex_lock(&balloon_mutex);
for (i = 0; i < nr_pages; i++) {
- if (pages[i])
+ if (pages[i]) {
+ __SetPageOffline(pages[i]);
balloon_append(pages[i]);
+ }
}
balloon_stats.target_unpopulated -= nr_pages;
At least this way, the pages allocated (and thus eventually mapped to
user space) would not be marked, but the other ones would remain marked
and could be excluded by makedumptool.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-03-12 19:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1h3Uiq-0002L6-Ij@osstest.test-lab.xenproject.org>
[not found] ` <80211e70-5f54-9421-8e8f-2a4fc758ce39@arm.com>
[not found] ` <46118631-61d4-adb6-6ffc-4e7c62ea3da9@arm.com>
2019-03-12 17:14 ` xen: Can't insert balloon page into VM userspace (WAS Re: [Xen-devel] [linux-linus bisection] complete test-arm64-arm64-xl-xsm) Matthew Wilcox
2019-03-12 17:18 ` David Hildenbrand
2019-03-12 17:24 ` [Xen-devel] xen: Can't insert balloon page into VM userspace (WAS " Andrew Cooper
2019-03-12 18:02 ` Boris Ostrovsky
2019-03-12 18:11 ` Andrew Cooper
2019-03-12 18:23 ` David Hildenbrand
2019-03-12 19:46 ` David Hildenbrand [this message]
2019-03-14 8:37 ` Juergen Gross
2019-03-14 14:12 ` Julien Grall
2019-03-14 14:14 ` David Hildenbrand
2019-03-14 14:15 ` Juergen Gross
2019-03-14 14:16 ` David Hildenbrand
2019-03-12 17:39 ` xen: Can't insert balloon page into VM userspace (WAS Re: [Xen-devel] " Julien Grall
2019-03-12 17:49 ` David Hildenbrand
2019-03-12 17:23 ` David Hildenbrand
2019-03-12 17:25 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f8aca6c-355b-7862-75aa-68fe566f76fb@redhat.com \
--to=david@redhat.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jfreche@vmware.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=k.khlebnikov@samsung.com \
--cc=keescook@chromium.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=namit@vmware.com \
--cc=osstest-admin@xenproject.org \
--cc=pv-drivers@vmware.com \
--cc=sstabellini@kernel.org \
--cc=willy@infradead.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).