From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A51C388F7 for ; Tue, 10 Nov 2020 09:30:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E120B20829 for ; Tue, 10 Nov 2020 09:29:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="GzU+IWNB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E120B20829 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=agner.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C12E46B0036; Tue, 10 Nov 2020 04:29:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC2326B005C; Tue, 10 Nov 2020 04:29:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B004C6B005D; Tue, 10 Nov 2020 04:29:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 862E16B0036 for ; Tue, 10 Nov 2020 04:29:58 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 37E678249980 for ; Tue, 10 Nov 2020 09:29:58 +0000 (UTC) X-FDA: 77467986876.17.skate68_4a1038d272f4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 1EFC6180D0184 for ; Tue, 10 Nov 2020 09:29:58 +0000 (UTC) X-HE-Tag: skate68_4a1038d272f4 X-Filterd-Recvd-Size: 6416 Received: from mail.kmu-office.ch (mail.kmu-office.ch [178.209.48.109]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 09:29:56 +0000 (UTC) Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 951625C08E1; Tue, 10 Nov 2020 10:29:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1605000594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8NOI0TwT6xo5ZLvM79HrQZeOfmGCdQyER0VKFIdm4jQ=; b=GzU+IWNBMbtYev7hrwn1TNuh5sjF7lfZtSTfXNgAbzuyKsAXOOC01YRx7AYTKt6kxvH6hG slBloYBBAFIg68pgdeP2RQST8i95aPm9xHkYGmZm8Nnnk6kQN5CCHpQuieJ4qa9b4hwUJD 71xeCBFffdVoOznc2qyUAdcYvZQeFoY= MIME-Version: 1.0 Date: Tue, 10 Nov 2020 10:29:54 +0100 From: Stefan Agner To: Mike Rapoport Cc: minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, akpm@linux-foundation.org, sjenning@linux.vnet.ibm.com, gregkh@linuxfoundation.org, arnd@arndb.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS In-Reply-To: <20201108064659.GD301837@kernel.org> References: <20201108064659.GD301837@kernel.org> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <7782fb694a6b0c500e8f32ecf895b2bf@agner.ch> X-Sender: stefan@agner.ch Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2020-11-08 07:46, Mike Rapoport wrote: > On Sat, Nov 07, 2020 at 04:22:06PM +0100, Stefan Agner wrote: >> Most architectures define MAX_PHYSMEM_BITS in asm/sparsemem.h and don't >> include it in asm/pgtable.h. Include asm/sparsemem.h directly to get >> the MAX_PHYSMEM_BITS define on all architectures. >> >> This fixes a crash when accessing zram on 32-bit ARM platform with LPAE and >> more than 4GB of memory: >> Unable to handle kernel NULL pointer dereference at virtual address 00000000 >> pgd = a27bd01c >> [00000000] *pgd=236a0003, *pmd=1ffa64003 >> Internal error: Oops: 207 [#1] SMP ARM >> Modules linked in: mdio_bcm_unimac(+) brcmfmac cfg80211 brcmutil raspberrypi_hwmon hci_uart crc32_arm_ce bcm2711_thermal phy_generic genet >> CPU: 0 PID: 123 Comm: mkfs.ext4 Not tainted 5.9.6 #1 >> Hardware name: BCM2711 >> PC is at zs_map_object+0x94/0x338 >> LR is at zram_bvec_rw.constprop.0+0x330/0xa64 >> pc : [] lr : [] psr: 60000013 >> sp : e376bbe0 ip : 00000000 fp : c1e2921c >> r10: 00000002 r9 : c1dda730 r8 : 00000000 >> r7 : e8ff7a00 r6 : 00000000 r5 : 02f9ffa0 r4 : e3710000 >> r3 : 000fdffe r2 : c1e0ce80 r1 : ebf979a0 r0 : 00000000 >> Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user >> Control: 30c5383d Table: 235c2a80 DAC: fffffffd >> Process mkfs.ext4 (pid: 123, stack limit = 0x495a22e6) >> Stack: (0xe376bbe0 to 0xe376c000) >> ... >> [] (zs_map_object) from [] (zram_bvec_rw.constprop.0+0x330/0xa64) >> [] (zram_bvec_rw.constprop.0) from [] (zram_submit_bio+0x1a4/0x40c) >> [] (zram_submit_bio) from [] (submit_bio_noacct+0xd0/0x3c8) >> [] (submit_bio_noacct) from [] (submit_bio+0x4c/0x190) >> [] (submit_bio) from [] (submit_bh_wbc+0x188/0x1b8) >> [] (submit_bh_wbc) from [] (__block_write_full_page+0x340/0x5e4) >> [] (__block_write_full_page) from [] (block_write_full_page+0x128/0x170) >> [] (block_write_full_page) from [] (__writepage+0x14/0x68) >> [] (__writepage) from [] (write_cache_pages+0x1bc/0x494) >> [] (write_cache_pages) from [] (generic_writepages+0x58/0x8c) >> [] (generic_writepages) from [] (do_writepages+0x48/0xec) >> [] (do_writepages) from [] (__filemap_fdatawrite_range+0xf0/0x128) >> [] (__filemap_fdatawrite_range) from [] (file_write_and_wait_range+0x48/0x98) >> [] (file_write_and_wait_range) from [] (blkdev_fsync+0x1c/0x44) >> [] (blkdev_fsync) from [] (do_fsync+0x3c/0x70) >> [] (do_fsync) from [] (__sys_trace_return+0x0/0x2c) >> Exception stack(0xe376bfa8 to 0xe376bff0) >> bfa0: 0003d2e0 b6f7b6f0 00000003 00046e40 00001000 00000000 >> bfc0: 0003d2e0 b6f7b6f0 00000000 00000076 00000000 00000000 befcbb20 befcbb28 >> bfe0: b6f4e060 befcbad8 b6f23e0c b6dc4a80 >> Code: e5927000 e0050391 e0871005 e5918018 (e5983000) >> >> Fixes: 61989a80fb3a ("staging: zsmalloc: zsmalloc memory allocation library") >> Signed-off-by: Stefan Agner >> --- >> mm/zsmalloc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c >> index c36fdff9a371..260bd48aacd0 100644 >> --- a/mm/zsmalloc.c >> +++ b/mm/zsmalloc.c >> @@ -40,6 +40,7 @@ >> #include >> #include >> #include >> +#include > > asm/sparsemem.h is not available on some architectures. > It's better to use linux/mmzone.h instead. > Hm, linux/mmzone.h only includes asm/sparsemem.h when CONFIG_SPARSEMEM is enabled. However, on ARM at least I can have configurations without CONFIG_SPARSEMEM and physical address extension on (e.g. multi_v7_defconfig + CONFIG_LPAE + CONFIG_ZSMALLOC). While sparsemem seems to be a good idea with LPAE it really seems not required (see also https://lore.kernel.org/patchwork/patch/567589/). There seem to be also other architectures which define MAX_PHYSMEM_BITS only when SPARSEMEM is enabled, e.g. arch/riscv/include/asm/sparsemem.h... Not sure how to get out of this.. Maybe make ZSMALLOC dependent on SPARSEMEM? It feels a bit silly restricting ZSMALLOC selection only due to a compile time define... -- Stefan >> #include >> #include >> #include >> -- >> 2.29.1 >> >>