From: Richard Palethorpe <rpalethorpe@suse.de>
To: Roman Gushchin <guro@fb.com>
Cc: "Michal Koutný" <mkoutny@suse.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
ltp@lists.linux.it, "Andrew Morton" <akpm@linux-foundation.org>,
"Shakeel Butt" <shakeelb@google.com>,
"Christoph Lameter" <cl@linux.com>,
"Michal Hocko" <mhocko@kernel.org>, "Tejun Heo" <tj@kernel.org>,
"Vlastimil Babka" <vbabka@suse.cz>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"Michal Hocko" <mhocko@suse.com>
Subject: Re: [RFC PATCH] mm: memcg/slab: Stop reparented obj_cgroups from charging root
Date: Tue, 20 Oct 2020 13:02:35 +0100 [thread overview]
Message-ID: <87h7qpw1es.fsf@suse.de> (raw)
In-Reply-To: <87k0vlwhzt.fsf@suse.de>
Hello,
Richard Palethorpe <rpalethorpe@suse.de> writes:
> Hello Roman,
>
> Roman Gushchin <guro@fb.com> writes:
>
>> - page_counter_init(&memcg->memory, NULL);
>> - page_counter_init(&memcg->swap, NULL);
>> - page_counter_init(&memcg->kmem, NULL);
>> - page_counter_init(&memcg->tcpmem, NULL);
>> + /*
>> + * If use_hierarchy == false, consider all page counters direct
>> + * descendants of the corresponding root level counters.
>> + */
>> + page_counter_init(&memcg->memory, &root_mem_cgroup->memory);
>> + page_counter_init(&memcg->swap, &root_mem_cgroup->swap);
>> + page_counter_init(&memcg->kmem, &root_mem_cgroup->kmem);
>> + page_counter_init(&memcg->tcpmem, &root_mem_cgroup->tcpmem);
>> +
>> /*
>> * Deeper hierachy with use_hierarchy == false doesn't make
>> * much sense so let cgroup subsystem know about this
>
> Perhaps in this case, where the hierarchy is broken, objcgs should also
> be reparented directly to root? Otherwise it will still be possible to
> underflow the counter in a descendant of root which has use_hierarchy=0,
> but also has children.
Sorry ignore me, parent_mem_cgroup already selects root. So in the case
of a broken hierarchy objcgs are reparented directly to root.
--
Thank you,
Richard.
next prev parent reply other threads:[~2020-10-20 12:02 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 19:07 [RFC PATCH] mm: memcg/slab: Stop reparented obj_cgroups from charging root Richard Palethorpe
2020-10-14 20:08 ` Roman Gushchin
2020-10-16 5:40 ` Richard Palethorpe
2020-10-16 9:47 ` Michal Koutný
2020-10-16 10:41 ` Richard Palethorpe
2020-10-16 15:05 ` Richard Palethorpe
2020-10-16 17:26 ` Michal Koutný
2020-10-16 14:53 ` Johannes Weiner
2020-10-16 17:02 ` Roman Gushchin
2020-10-16 17:15 ` Michal Koutný
2020-10-19 8:45 ` Richard Palethorpe
2020-10-19 9:58 ` [PATCH v3] " Richard Palethorpe
2020-10-19 16:58 ` Shakeel Butt
2020-10-20 5:52 ` Richard Palethorpe
2020-10-20 13:49 ` Richard Palethorpe
2020-10-20 16:56 ` Shakeel Butt
2020-10-21 20:32 ` Roman Gushchin
2020-10-20 17:24 ` Michal Koutný
2020-10-22 7:04 ` Richard Palethorpe
2020-10-22 12:28 ` [PATCH v4] " Richard Palethorpe
2020-10-22 16:37 ` Shakeel Butt
2020-10-22 17:25 ` Roman Gushchin
2020-10-22 23:59 ` Shakeel Butt
2020-10-23 0:40 ` Roman Gushchin
2020-10-23 15:44 ` Johannes Weiner
2020-10-23 16:41 ` Shakeel Butt
2020-10-26 7:32 ` Richard Palethorpe
2020-10-26 23:14 ` Roman Gushchin
2020-10-19 22:28 ` [RFC PATCH] " Roman Gushchin
2020-10-20 6:04 ` Richard Palethorpe
2020-10-20 12:02 ` Richard Palethorpe [this message]
2020-10-20 14:48 ` Richard Palethorpe
2020-10-20 16:27 ` Michal Koutný
2020-10-20 17:07 ` Roman Gushchin
2020-10-20 18:18 ` Johannes Weiner
2020-10-21 19:33 ` Roman Gushchin
2020-10-23 16:30 ` Johannes Weiner
2020-11-10 1:27 ` Roman Gushchin
2020-11-10 15:11 ` Shakeel Butt
2020-11-10 19:13 ` Roman Gushchin
2020-11-20 17:46 ` Michal Koutný
2020-11-03 13:22 ` Michal Hocko
2020-11-03 21:30 ` Roman Gushchin
2020-10-20 16:55 ` Shakeel Butt
2020-10-20 17:17 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7qpw1es.fsf@suse.de \
--to=rpalethorpe@suse.de \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ltp@lists.linux.it \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=mkoutny@suse.com \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).