From: John Ogness <john.ogness@linutronix.de>
To: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Michal Hocko <mhocko@suse.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH] printk: Enough to disable preemption in printk deferred context
Date: Wed, 19 Apr 2023 11:11:52 +0206 [thread overview]
Message-ID: <87r0sg5jin.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20230419074210.17646-1-pmladek@suse.com>
On 2023-04-19, Petr Mladek <pmladek@suse.com> wrote:
> it is safe to interrupt one writer now. The preemption still
> has to be disabled because the deferred context is CPU specific.
Really it is enough to disable migration.
We need to keep an eye on the usage of this function. By allowing
interrupts and preemption, it means that other printk's on that CPU will
also be deferred if the context interrupted within the deferred block.
John
next prev parent reply other threads:[~2023-04-19 9:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 7:42 [PATCH] printk: Enough to disable preemption in printk deferred context Petr Mladek
2023-04-19 8:23 ` Sergey Senozhatsky
2023-04-19 8:23 ` Michal Hocko
2023-04-19 10:31 ` Petr Mladek
2023-04-19 9:05 ` John Ogness [this message]
2023-04-19 12:03 ` Petr Mladek
2023-04-19 12:14 ` Michal Hocko
2023-04-19 13:45 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0sg5jin.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).