From: David Hildenbrand <david@redhat.com>
To: Tyler Sanderson <tysand@google.com>
Cc: David Hildenbrand <david@redhat.com>,
Michal Hocko <mhocko@kernel.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
virtualization@lists.linux-foundation.org,
"Michael S . Tsirkin" <mst@redhat.com>,
Wei Wang <wei.w.wang@intel.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
David Rientjes <rientjes@google.com>,
Nadav Amit <namit@vmware.com>
Subject: Re: [PATCH v1 3/3] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM
Date: Fri, 14 Feb 2020 22:17:26 +0100 [thread overview]
Message-ID: <8B1B3CD6-10D5-46D3-B8E5-A6AD0B8E41BC@redhat.com> (raw)
In-Reply-To: <CAJuQAmpGKcyWo8Ojnia_pXZAaOt98u0c_Sk-8ieCO218hutW1g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]
> Am 14.02.2020 um 21:49 schrieb Tyler Sanderson <tysand@google.com>:
>
>
> Regarding Wei's patch that modifies the shrinker implementation, versus this patch which reverts to OOM notifier:
> I am in favor of both patches. But I do want to make sure a fix gets back ported to 4.19 where the performance regression was first introduced.
> My concern with reverting to the OOM notifier is, as mst@ put it (in the other thread):
> "when linux hits OOM all kind of error paths are being hit, latent bugs start triggering, latency goes up drastically."
Yeah, and that was the default behavior for years, so it‘s not big news :)
> The guest could be in a lot of pain before the OOM notifier is invoked, and it seems like the shrinker API might allow more fine grained control of when we deflate.
>
> On the other hand, I'm not totally convinced that Wei's patch is an expected use of the shrinker/page-cache APIs, and maybe it is fragile. Needs more testing and scrutiny.
>
> It seems to me like the shrinker API is the right API in the long run, perhaps with some fixes and modifications. But maybe reverting to OOM notifier is the best patch to back
I think that‘s a good idea. Revert to the old state we had for years and then implement a proper, fully tested solution (e.g., shrinkers with priorities).
Cheers!
[-- Attachment #2: Type: text/html, Size: 1967 bytes --]
next prev parent reply other threads:[~2020-02-14 21:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 16:33 [PATCH v1 0/3] virtio-balloon: Fixes + switch back to OOM handler David Hildenbrand
2020-02-05 16:34 ` [PATCH v1 1/3] virtio-balloon: Fix memory leak when unloading while hinting is in progress David Hildenbrand
2020-02-06 8:36 ` Michael S. Tsirkin
2020-02-05 16:34 ` [PATCH v1 2/3] virtio_balloon: Fix memory leaks on errors in virtballoon_probe() David Hildenbrand
2020-02-06 8:36 ` Michael S. Tsirkin
2020-02-05 16:34 ` [PATCH v1 3/3] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM David Hildenbrand
2020-02-05 22:37 ` Tyler Sanderson
2020-02-05 22:52 ` David Hildenbrand
2020-02-05 23:06 ` Tyler Sanderson
2020-02-06 7:40 ` Michael S. Tsirkin
2020-02-06 8:42 ` David Hildenbrand
2020-02-06 8:57 ` Michael S. Tsirkin
2020-02-06 9:05 ` David Hildenbrand
2020-02-06 9:09 ` Michael S. Tsirkin
2020-02-06 8:57 ` Wang, Wei W
2020-02-06 9:11 ` Michael S. Tsirkin
2020-02-06 9:12 ` Michael S. Tsirkin
2020-02-06 9:21 ` David Hildenbrand
2020-02-14 9:51 ` David Hildenbrand
2020-02-14 13:31 ` Wang, Wei W
2020-02-16 9:47 ` Michael S. Tsirkin
2020-02-21 3:29 ` Tyler Sanderson
2020-03-08 4:47 ` Tyler Sanderson
2020-03-09 9:03 ` David Hildenbrand
2020-03-09 10:14 ` Michael S. Tsirkin
2020-03-09 10:59 ` David Hildenbrand
2020-03-09 10:24 ` Michael S. Tsirkin
2020-02-14 14:06 ` Michal Hocko
2020-02-14 14:18 ` David Hildenbrand
2020-02-14 20:48 ` Tyler Sanderson
2020-02-14 21:17 ` David Hildenbrand [this message]
2020-02-16 9:46 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8B1B3CD6-10D5-46D3-B8E5-A6AD0B8E41BC@redhat.com \
--to=david@redhat.com \
--cc=alexander.h.duyck@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=namit@vmware.com \
--cc=rientjes@google.com \
--cc=tysand@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).