From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E5DCC433C1 for ; Wed, 24 Mar 2021 02:40:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9769661580 for ; Wed, 24 Mar 2021 02:40:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9769661580 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 095BA6B01F3; Tue, 23 Mar 2021 22:40:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 033A16B01F4; Tue, 23 Mar 2021 22:40:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3DAE6B0253; Tue, 23 Mar 2021 22:40:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id C99B66B01F3 for ; Tue, 23 Mar 2021 22:40:38 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 847D4181AEF31 for ; Wed, 24 Mar 2021 02:40:38 +0000 (UTC) X-FDA: 77953214556.06.2EFDEA0 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf27.hostedemail.com (Postfix) with ESMTP id 630F480192E1 for ; Wed, 24 Mar 2021 02:40:36 +0000 (UTC) Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4F4sqZ00ywz19HGZ; Wed, 24 Mar 2021 10:38:33 +0800 (CST) Received: from [10.174.178.163] (10.174.178.163) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.498.0; Wed, 24 Mar 2021 10:40:28 +0800 Subject: Re: [PATCH v2 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on putback_movable_page() To: David Hildenbrand CC: , , , , , , Andrew Morton References: <20210323135405.65059-1-linmiaohe@huawei.com> <20210323135405.65059-2-linmiaohe@huawei.com> <0017dfc4-05a4-1989-59dc-3f34f7b3517c@redhat.com> From: Miaohe Lin Message-ID: <8a25f3e9-c502-068e-ca40-242cce875584@huawei.com> Date: Wed, 24 Mar 2021 10:40:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <0017dfc4-05a4-1989-59dc-3f34f7b3517c@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US X-Originating-IP: [10.174.178.163] X-CFilter-Loop: Reflected X-Stat-Signature: i7bdr9jzmsqbg8p5h6ztz5ic5mo4daoy X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 630F480192E1 Received-SPF: none (huawei.com>: No applicable sender policy available) receiver=imf27; identity=mailfrom; envelope-from=""; helo=szxga04-in.huawei.com; client-ip=45.249.212.190 X-HE-DKIM-Result: none/none X-HE-Tag: 1616553636-661094 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021/3/23 22:27, David Hildenbrand wrote: > On 23.03.21 14:54, Miaohe Lin wrote: >> The !PageLocked() check is implicitly done in PageMovable(). Remove th= is >> explicit one. >> >> Signed-off-by: Miaohe Lin >> --- >> =C2=A0 mm/migrate.c | 1 - >> =C2=A0 1 file changed, 1 deletion(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index 47df0df8f21a..facec65c7374 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -145,7 +145,6 @@ void putback_movable_page(struct page *page) >> =C2=A0 { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct address_space *mapping; >> =C2=A0 -=C2=A0=C2=A0=C2=A0 VM_BUG_ON_PAGE(!PageLocked(page), page); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 VM_BUG_ON_PAGE(!PageMovable(page), page= ); >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 VM_BUG_ON_PAGE(!PageIsolated(page), pag= e); >> =C2=A0 >=20 > Reviewed-by: David Hildenbrand Many thanks for your review. But I'am going to change this patch, so this= Reviewed-by tag may not applies any more. Sorry about it! >=20