linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	<catalin.marinas@arm.com>, <will@kernel.org>,
	<akpm@linux-foundation.org>, <guohanjun@huawei.com>,
	<sudeep.holla@arm.com>, <song.bao.hua@hisilicon.com>,
	<ardb@kernel.org>, <anshuman.khandual@arm.com>,
	<stable@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	Li Huafei <lihuafei1@huawei.com>
Subject: Re: [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA
Date: Wed, 23 Jun 2021 14:59:59 +0800	[thread overview]
Message-ID: <8b0a4f25-0803-9341-f3a4-277d16802295@huawei.com> (raw)
In-Reply-To: <31cd8432-2466-555d-7617-ae48cbcd4244@huawei.com>

Hi Greg,

There are two more patches about the ZONE_DMA[32] changes, especially 
the second one, both them need be backported, thanks.

791ab8b2e3db - arm64: Ignore any DMA offsets in the max_zone_phys() 
calculation
2687275a5843 - arm64: Force NO_BLOCK_MAPPINGS if crashkernel reservation 
is required



On 2021/5/11 20:35, Kefeng Wang wrote:
> 
> 
> On 2021/3/8 17:58, Greg KH wrote:
>> On Mon, Mar 08, 2021 at 11:20:03AM +0800, Jing Xiangfeng wrote:
>>>
>>>
>>> On 2021/3/7 23:24, Greg KH wrote:
>>>> On Thu, Mar 04, 2021 at 04:09:28PM +0100, Nicolas Saenz Julienne wrote:
>>>>> On Thu, 2021-03-04 at 15:17 +0100, Greg KH wrote:
>>>>>> On Thu, Mar 04, 2021 at 03:05:32PM +0100, Nicolas Saenz Julienne 
>>>>>> wrote:
>>>>>>> Hi Greg.
>>>>>>>
>>>>>>> On Thu, 2021-03-04 at 14:46 +0100, Greg KH wrote:
>>>>>>>> On Wed, Mar 03, 2021 at 03:33:12PM +0800, Jing Xiangfeng wrote:
>>>>>>>>> Using two distinct DMA zones turned out to be problematic. 
>>>>>>>>> Here's an
>>>>>>>>> attempt go back to a saner default.
>>>>>>>> What problem does this solve?  How does this fit into the stable 
>>>>>>>> kernel
>>>>>>>> rules?
>>>>>>> We changed the way we setup memory zones in arm64 in order to 
>>>>>>> cater for
>>>>>>> Raspberry Pi 4's weird DMA constraints: ZONE_DMA spans the lower 
>>>>>>> 1GB of memory
>>>>>>> and ZONE_DMA32 the rest of the 32bit address space. Since you 
>>>>>>> can't allocate
>>>>>>> memory that crosses zone boundaries, this broke crashkernel 
>>>>>>> allocations on big
>>>>>>> machines. This series fixes all this by parsing the HW 
>>>>>>> description and checking
>>>>>>> for DMA constrained buses. When not found, the unnecessary zone 
>>>>>>> creation is
>>>>>>> skipped.
>>>>>> What kernel/commit caused this "breakage"?
>>>>> 1a8e1cef7603 arm64: use both ZONE_DMA and ZONE_DMA32
>>>> Thanks for the info, all now queued up.
>>> There is a fix in 5.11. Please consider applying the following commit to
>>> 5.10.y:
>>>
>>> aed5041ef9a3 of: unittest: Fix build on architectures without
>>> CONFIG_OF_ADDRES
>>
>> Thanks, now queued up.
> 
> Hi Grep, another commit d78050ee3544 "arm64: Remove 
> arm64_dma32_phys_limit and its uses" should be involved, thanks.
> 
> "Prior to this patch, disabling CONFIG_ZONE_DMA32 leads to CMA
> allocation from the whole RAM as arm64_dma32_phys_limit becomes
> PHYS_MASK+1." from Catalin, see more from the link
> https://www.spinics.net/lists/arm-kernel/msg867356.html
>>
>> greg k-h
>> .
>>


  parent reply	other threads:[~2021-06-23  7:01 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03  7:33 [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA Jing Xiangfeng
2021-03-03  7:33 ` [PATCH stable v5.10 1/7] arm64: mm: Move reserve_crashkernel() into mem_init() Jing Xiangfeng
2021-03-07 15:25   ` Patch "arm64: mm: Move reserve_crashkernel() into mem_init()" has been added to the 5.10-stable tree gregkh
2021-03-03  7:33 ` [PATCH stable v5.10 2/7] arm64: mm: Move zone_dma_bits initialization into zone_sizes_init() Jing Xiangfeng
2021-03-07 15:25   ` Patch "arm64: mm: Move zone_dma_bits initialization into zone_sizes_init()" has been added to the 5.10-stable tree gregkh
2021-03-03  7:33 ` [PATCH stable v5.10 3/7] of/address: Introduce of_dma_get_max_cpu_address() Jing Xiangfeng
2021-03-07 15:25   ` Patch "of/address: Introduce of_dma_get_max_cpu_address()" has been added to the 5.10-stable tree gregkh
2021-03-03  7:33 ` [PATCH stable v5.10 4/7] of: unittest: Add test for of_dma_get_max_cpu_address() Jing Xiangfeng
2021-03-07 15:25   ` Patch "of: unittest: Add test for of_dma_get_max_cpu_address()" has been added to the 5.10-stable tree gregkh
2021-03-03  7:33 ` [PATCH stable v5.10 5/7] arm64: mm: Set ZONE_DMA size based on devicetree's dma-ranges Jing Xiangfeng
2021-03-07 15:25   ` Patch "arm64: mm: Set ZONE_DMA size based on devicetree's dma-ranges" has been added to the 5.10-stable tree gregkh
2021-03-03  7:33 ` [PATCH stable v5.10 6/7] arm64: mm: Set ZONE_DMA size based on early IORT scan Jing Xiangfeng
2021-03-07 15:25   ` Patch "arm64: mm: Set ZONE_DMA size based on early IORT scan" has been added to the 5.10-stable tree gregkh
2021-03-03  7:33 ` [PATCH stable v5.10 7/7] mm: Remove examples from enum zone_type comment Jing Xiangfeng
2021-03-07 15:25   ` Patch "mm: Remove examples from enum zone_type comment" has been added to the 5.10-stable tree gregkh
2021-03-04 13:46 ` [PATCH stable v5.10 0/7] arm64: Default to 32-bit wide ZONE_DMA Greg KH
2021-03-04 14:05   ` Nicolas Saenz Julienne
2021-03-04 14:17     ` Greg KH
2021-03-04 15:09       ` Nicolas Saenz Julienne
2021-03-07 15:24         ` Greg KH
2021-03-08  3:20           ` Jing Xiangfeng
2021-03-08  9:58             ` Greg KH
2021-05-11 12:35               ` Kefeng Wang
2021-05-12 12:06                 ` Greg KH
2021-06-23  6:59                 ` Kefeng Wang [this message]
2021-06-23  7:12                   ` Greg KH
2021-06-23  7:25                     ` Kefeng Wang
2021-06-23  7:34                       ` Greg KH
2021-06-23  8:01                         ` Kefeng Wang
2021-06-25 10:19                           ` Greg KH
2021-06-26  1:19                             ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b0a4f25-0803-9341-f3a4-277d16802295@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guohanjun@huawei.com \
    --cc=jingxiangfeng@huawei.com \
    --cc=lihuafei1@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=song.bao.hua@hisilicon.com \
    --cc=stable@vger.kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).